* hwrng: exynos - add CONFIG_PM_RUNTIME to suspend/resume functions
@ 2013-03-21 23:47 Jingoo Han
2013-03-22 1:55 ` [PATCH] " Jingoo Han
0 siblings, 1 reply; 4+ messages in thread
From: Jingoo Han @ 2013-03-21 23:47 UTC (permalink / raw)
To: 'Andrew Morton'
Cc: linux-kernel, 'Matt Mackall', 'Herbert Xu',
'David Rientjes', 'Jingoo Han'
Add CONFIG_PM_RUNTIME to suspend/resume functions to fix the build
error. It is because UNIVERSAL_DEV_PM_OPS macro is related to both
CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME.
drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_suspend' undeclared here (not in a function)
drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_resume' undeclared here (not in a function)
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Reported-by: David Rientjes <rientjes@google.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
---
drivers/char/hw_random/exynos-rng.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/hw_random/exynos-rng.c b/drivers/char/hw_random/exynos-rng.c
index b7e48a2..402ccfb 100644
--- a/drivers/char/hw_random/exynos-rng.c
+++ b/drivers/char/hw_random/exynos-rng.c
@@ -144,7 +144,7 @@ static int exynos_rng_remove(struct platform_device *pdev)
return 0;
}
-#ifdef CONFIG_PM_SLEEP
+#if defined(CONFIG_PM_SLEEP) || defined(CONFIG_PM_RUNTIME)
static int exynos_rng_runtime_suspend(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
--
1.7.2.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] hwrng: exynos - add CONFIG_PM_RUNTIME to suspend/resume functions
2013-03-21 23:47 hwrng: exynos - add CONFIG_PM_RUNTIME to suspend/resume functions Jingoo Han
@ 2013-03-22 1:55 ` Jingoo Han
2013-03-22 9:38 ` David Rientjes
0 siblings, 1 reply; 4+ messages in thread
From: Jingoo Han @ 2013-03-22 1:55 UTC (permalink / raw)
To: 'Andrew Morton'
Cc: linux-kernel, 'Matt Mackall', 'Herbert Xu',
'David Rientjes', 'Jingoo Han'
Add CONFIG_PM_RUNTIME to suspend/resume functions to fix the build
error. It is because UNIVERSAL_DEV_PM_OPS macro is related to both
CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME.
drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_suspend' undeclared here (not in a function)
drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_resume' undeclared here (not in a function)
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Reported-by: David Rientjes <rientjes@google.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
---
drivers/char/hw_random/exynos-rng.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/hw_random/exynos-rng.c b/drivers/char/hw_random/exynos-rng.c
index b7e48a2..402ccfb 100644
--- a/drivers/char/hw_random/exynos-rng.c
+++ b/drivers/char/hw_random/exynos-rng.c
@@ -144,7 +144,7 @@ static int exynos_rng_remove(struct platform_device *pdev)
return 0;
}
-#ifdef CONFIG_PM_SLEEP
+#if defined(CONFIG_PM_SLEEP) || defined(CONFIG_PM_RUNTIME)
static int exynos_rng_runtime_suspend(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
--
1.7.2.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hwrng: exynos - add CONFIG_PM_RUNTIME to suspend/resume functions
2013-03-22 1:55 ` [PATCH] " Jingoo Han
@ 2013-03-22 9:38 ` David Rientjes
2013-03-22 10:15 ` Herbert Xu
0 siblings, 1 reply; 4+ messages in thread
From: David Rientjes @ 2013-03-22 9:38 UTC (permalink / raw)
To: Jingoo Han; +Cc: Andrew Morton, linux-kernel, Matt Mackall, Herbert Xu
On Fri, 22 Mar 2013, Jingoo Han wrote:
> Add CONFIG_PM_RUNTIME to suspend/resume functions to fix the build
> error. It is because UNIVERSAL_DEV_PM_OPS macro is related to both
> CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME.
>
> drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_suspend' undeclared here (not in a function)
> drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_resume' undeclared here (not in a function)
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> Reported-by: David Rientjes <rientjes@google.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: David Rientjes <rientjes@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hwrng: exynos - add CONFIG_PM_RUNTIME to suspend/resume functions
2013-03-22 9:38 ` David Rientjes
@ 2013-03-22 10:15 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2013-03-22 10:15 UTC (permalink / raw)
To: David Rientjes; +Cc: Jingoo Han, Andrew Morton, linux-kernel, Matt Mackall
On Fri, Mar 22, 2013 at 02:38:53AM -0700, David Rientjes wrote:
> On Fri, 22 Mar 2013, Jingoo Han wrote:
>
> > Add CONFIG_PM_RUNTIME to suspend/resume functions to fix the build
> > error. It is because UNIVERSAL_DEV_PM_OPS macro is related to both
> > CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME.
> >
> > drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_suspend' undeclared here (not in a function)
> > drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_resume' undeclared here (not in a function)
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > Reported-by: David Rientjes <rientjes@google.com>
> > Cc: Herbert Xu <herbert@gondor.apana.org.au>
>
> Acked-by: David Rientjes <rientjes@google.com>
Thanks, I've folded this into the original patch and rebased
the tree so that it is bisectable.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-22 10:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-21 23:47 hwrng: exynos - add CONFIG_PM_RUNTIME to suspend/resume functions Jingoo Han
2013-03-22 1:55 ` [PATCH] " Jingoo Han
2013-03-22 9:38 ` David Rientjes
2013-03-22 10:15 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome