* [PATCH v4 2/2] drm/radeon/uvd: Fix forgotten unmap buffer objects
@ 2022-02-08 8:14 zhanglianjie
2022-02-08 8:17 ` Christian König
0 siblings, 1 reply; 4+ messages in thread
From: zhanglianjie @ 2022-02-08 8:14 UTC (permalink / raw)
To: Christian König
Cc: Alex Deucher, PanXinhui, David Airlie, Daniel Vetter, amd-gfx,
dri-devel, linux-kernel, zhanglianjie
after the buffer object is successfully mapped, call radeon_bo_kunmap before the function returns.
Signed-off-by: zhanglianjie <zhanglianjie@uniontech.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c b/drivers/gpu/drm/radeon/radeon_uvd.c
index 377f9cdb5b53..0558d928d98d 100644
--- a/drivers/gpu/drm/radeon/radeon_uvd.c
+++ b/drivers/gpu/drm/radeon/radeon_uvd.c
@@ -497,6 +497,7 @@ static int radeon_uvd_cs_msg(struct radeon_cs_parser *p, struct radeon_bo *bo,
handle = msg[2];
if (handle == 0) {
+ radeon_bo_kunmap(bo);
DRM_ERROR("Invalid UVD handle!\n");
return -EINVAL;
}
@@ -559,12 +560,10 @@ static int radeon_uvd_cs_msg(struct radeon_cs_parser *p, struct radeon_bo *bo,
return 0;
default:
-
DRM_ERROR("Illegal UVD message type (%d)!\n", msg_type);
- return -EINVAL;
}
- BUG();
+ radeon_bo_kunmap(bo);
return -EINVAL;
}
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4 2/2] drm/radeon/uvd: Fix forgotten unmap buffer objects
2022-02-08 8:14 [PATCH v4 2/2] drm/radeon/uvd: Fix forgotten unmap buffer objects zhanglianjie
@ 2022-02-08 8:17 ` Christian König
[not found] ` <400b7279-b738-5614-dff7-0e2f6f395a0e@uniontech.com>
0 siblings, 1 reply; 4+ messages in thread
From: Christian König @ 2022-02-08 8:17 UTC (permalink / raw)
To: zhanglianjie
Cc: Alex Deucher, PanXinhui, David Airlie, Daniel Vetter, amd-gfx,
dri-devel, linux-kernel
I'm scratching my head what you are doing here?
That's the fives time you send out the same patch, so something is going
wrong here :)
Please double check why that lands in your outbox over and over again.
Regards,
Christian.
Am 08.02.22 um 09:14 schrieb zhanglianjie:
> after the buffer object is successfully mapped, call radeon_bo_kunmap before the function returns.
>
> Signed-off-by: zhanglianjie <zhanglianjie@uniontech.com>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c b/drivers/gpu/drm/radeon/radeon_uvd.c
> index 377f9cdb5b53..0558d928d98d 100644
> --- a/drivers/gpu/drm/radeon/radeon_uvd.c
> +++ b/drivers/gpu/drm/radeon/radeon_uvd.c
> @@ -497,6 +497,7 @@ static int radeon_uvd_cs_msg(struct radeon_cs_parser *p, struct radeon_bo *bo,
> handle = msg[2];
>
> if (handle == 0) {
> + radeon_bo_kunmap(bo);
> DRM_ERROR("Invalid UVD handle!\n");
> return -EINVAL;
> }
> @@ -559,12 +560,10 @@ static int radeon_uvd_cs_msg(struct radeon_cs_parser *p, struct radeon_bo *bo,
> return 0;
>
> default:
> -
> DRM_ERROR("Illegal UVD message type (%d)!\n", msg_type);
> - return -EINVAL;
> }
>
> - BUG();
> + radeon_bo_kunmap(bo);
> return -EINVAL;
> }
>
> --
> 2.20.1
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4 2/2] drm/radeon/uvd: Fix forgotten unmap buffer objects
[not found] ` <400b7279-b738-5614-dff7-0e2f6f395a0e@uniontech.com>
@ 2022-02-08 8:33 ` Christian König
2022-02-08 17:37 ` Alex Deucher
0 siblings, 1 reply; 4+ messages in thread
From: Christian König @ 2022-02-08 8:33 UTC (permalink / raw)
To: zhanglianjie
Cc: Alex Deucher, PanXinhui, David Airlie, Daniel Vetter, amd-gfx,
dri-devel, linux-kernel
I think so, Alex will probably pick that up.
Thanks,
Christian.
Am 08.02.22 um 09:28 schrieb zhanglianjie:
> I am very sorry that I submitted many times due to the character
> coding problem. Can PATCH V4 be used?
>
>> I'm scratching my head what you are doing here?
>>
>> That's the fives time you send out the same patch, so something is
>> going wrong here :)
>>
>> Please double check why that lands in your outbox over and over again.
>>
>> Regards,
>> Christian.
>>
>> Am 08.02.22 um 09:14 schrieb zhanglianjie:
>>> after the buffer object is successfully mapped, call
>>> radeon_bo_kunmap before the function returns.
>>>
>>> Signed-off-by: zhanglianjie <zhanglianjie@uniontech.com>
>>> Reviewed-by: Christian König <christian.koenig@amd.com>
>>>
>>> diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c
>>> b/drivers/gpu/drm/radeon/radeon_uvd.c
>>> index 377f9cdb5b53..0558d928d98d 100644
>>> --- a/drivers/gpu/drm/radeon/radeon_uvd.c
>>> +++ b/drivers/gpu/drm/radeon/radeon_uvd.c
>>> @@ -497,6 +497,7 @@ static int radeon_uvd_cs_msg(struct
>>> radeon_cs_parser *p, struct radeon_bo *bo,
>>> handle = msg[2];
>>>
>>> if (handle == 0) {
>>> + radeon_bo_kunmap(bo);
>>> DRM_ERROR("Invalid UVD handle!\n");
>>> return -EINVAL;
>>> }
>>> @@ -559,12 +560,10 @@ static int radeon_uvd_cs_msg(struct
>>> radeon_cs_parser *p, struct radeon_bo *bo,
>>> return 0;
>>>
>>> default:
>>> -
>>> DRM_ERROR("Illegal UVD message type (%d)!\n", msg_type);
>>> - return -EINVAL;
>>> }
>>>
>>> - BUG();
>>> + radeon_bo_kunmap(bo);
>>> return -EINVAL;
>>> }
>>>
>>> --
>>> 2.20.1
>>>
>>>
>>>
>>
>>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4 2/2] drm/radeon/uvd: Fix forgotten unmap buffer objects
2022-02-08 8:33 ` Christian König
@ 2022-02-08 17:37 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2022-02-08 17:37 UTC (permalink / raw)
To: Christian König
Cc: zhanglianjie, David Airlie, PanXinhui, LKML,
Maling list - DRI developers, amd-gfx list, Daniel Vetter,
Alex Deucher
Applied the series. Thanks!
Alex
On Tue, Feb 8, 2022 at 3:33 AM Christian König <christian.koenig@amd.com> wrote:
>
> I think so, Alex will probably pick that up.
>
> Thanks,
> Christian.
>
> Am 08.02.22 um 09:28 schrieb zhanglianjie:
> > I am very sorry that I submitted many times due to the character
> > coding problem. Can PATCH V4 be used?
> >
> >> I'm scratching my head what you are doing here?
> >>
> >> That's the fives time you send out the same patch, so something is
> >> going wrong here :)
> >>
> >> Please double check why that lands in your outbox over and over again.
> >>
> >> Regards,
> >> Christian.
> >>
> >> Am 08.02.22 um 09:14 schrieb zhanglianjie:
> >>> after the buffer object is successfully mapped, call
> >>> radeon_bo_kunmap before the function returns.
> >>>
> >>> Signed-off-by: zhanglianjie <zhanglianjie@uniontech.com>
> >>> Reviewed-by: Christian König <christian.koenig@amd.com>
> >>>
> >>> diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c
> >>> b/drivers/gpu/drm/radeon/radeon_uvd.c
> >>> index 377f9cdb5b53..0558d928d98d 100644
> >>> --- a/drivers/gpu/drm/radeon/radeon_uvd.c
> >>> +++ b/drivers/gpu/drm/radeon/radeon_uvd.c
> >>> @@ -497,6 +497,7 @@ static int radeon_uvd_cs_msg(struct
> >>> radeon_cs_parser *p, struct radeon_bo *bo,
> >>> handle = msg[2];
> >>>
> >>> if (handle == 0) {
> >>> + radeon_bo_kunmap(bo);
> >>> DRM_ERROR("Invalid UVD handle!\n");
> >>> return -EINVAL;
> >>> }
> >>> @@ -559,12 +560,10 @@ static int radeon_uvd_cs_msg(struct
> >>> radeon_cs_parser *p, struct radeon_bo *bo,
> >>> return 0;
> >>>
> >>> default:
> >>> -
> >>> DRM_ERROR("Illegal UVD message type (%d)!\n", msg_type);
> >>> - return -EINVAL;
> >>> }
> >>>
> >>> - BUG();
> >>> + radeon_bo_kunmap(bo);
> >>> return -EINVAL;
> >>> }
> >>>
> >>> --
> >>> 2.20.1
> >>>
> >>>
> >>>
> >>
> >>
> >
> >
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-08 17:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-08 8:14 [PATCH v4 2/2] drm/radeon/uvd: Fix forgotten unmap buffer objects zhanglianjie
2022-02-08 8:17 ` Christian König
[not found] ` <400b7279-b738-5614-dff7-0e2f6f395a0e@uniontech.com>
2022-02-08 8:33 ` Christian König
2022-02-08 17:37 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®