* [PATCH] backlight: adp8870: add missing braces
@ 2013-03-11 9:37 Jingoo Han
0 siblings, 0 replies; only message in thread
From: Jingoo Han @ 2013-03-11 9:37 UTC (permalink / raw)
To: 'Andrew Morton'
Cc: 'LKML', 'Richard Purdie', 'Jingoo Han'
This patch adds missing braces to include error message.
The error message is related to the return value for
sysfs_create_group(). However, sysfs_create_group() is called
when pdata->en_ambl_sens is not zero. Thus, the checking return
value should be included in the if statement.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/adp8870_bl.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/video/backlight/adp8870_bl.c b/drivers/video/backlight/adp8870_bl.c
index 712c25a..7930ab3 100644
--- a/drivers/video/backlight/adp8870_bl.c
+++ b/drivers/video/backlight/adp8870_bl.c
@@ -895,13 +895,13 @@ static int adp8870_probe(struct i2c_client *client,
data->bl = bl;
- if (pdata->en_ambl_sens)
+ if (pdata->en_ambl_sens) {
ret = sysfs_create_group(&bl->dev.kobj,
&adp8870_bl_attr_group);
-
- if (ret) {
- dev_err(&client->dev, "failed to register sysfs\n");
- goto out1;
+ if (ret) {
+ dev_err(&client->dev, "failed to register sysfs\n");
+ goto out1;
+ }
}
ret = adp8870_bl_setup(bl);
--
1.7.2.5
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-03-11 9:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-11 9:37 [PATCH] backlight: adp8870: add missing braces Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®