* Re: [PATCH -next] backlight: adp8870: fix error return code in adp8870_led_probe()
[not found] <CAPgLHd_V1M9DaO-XfrVh5k7on7cYRiLONQiu+SGrQM81MT5+Qg@mail.gmail.com>
@ 2013-03-25 4:31 ` Jingoo Han
0 siblings, 0 replies; only message in thread
From: Jingoo Han @ 2013-03-25 4:31 UTC (permalink / raw)
To: 'Wei Yongjun'
Cc: 'Andrew Morton',
linux-kernel, rpurdie, FlorianSchandinat, yongjun_wei,
linux-fbdev, 'Jingoo Han'
On Friday, March 22, 2013 8:31 PM, Wei Yongjun wrote:
>
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as returned elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
CC'ed Andrdew Morton, linux-kernel@vger.kernel.org
Acked-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/adp8870_bl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/video/backlight/adp8870_bl.c b/drivers/video/backlight/adp8870_bl.c
> index 302c800..759bf23 100644
> --- a/drivers/video/backlight/adp8870_bl.c
> +++ b/drivers/video/backlight/adp8870_bl.c
> @@ -274,12 +274,14 @@ static int adp8870_led_probe(struct i2c_client *client)
> if (led_dat->id > 7 || led_dat->id < 1) {
> dev_err(&client->dev, "Invalid LED ID %d\n",
> led_dat->id);
> + ret = -EINVAL;
> goto err;
> }
>
> if (pdata->bl_led_assign & (1 << (led_dat->id - 1))) {
> dev_err(&client->dev, "LED %d used by Backlight\n",
> led_dat->id);
> + ret = -EBUSY;
> goto err;
> }
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] only message in thread