* [PATCH] arm64: dts: qcom: Add PMIC thermal support for Agatti QRB2210-RB1 platform
@ 2026-08-24 14:49 Raj Aryan
2026-09-03 9:02 ` Konrad Dybcio
2026-09-03 9:04 ` Konrad Dybcio
0 siblings, 2 replies; 3+ messages in thread
From: Raj Aryan @ 2026-08-24 14:49 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Raj Aryan
Add ADC channels for msm, quiet and xo thermistors along with
their ADC thermal bridge nodes and thermal zones for PMIC
thermal mitigation.
Signed-off-by: Raj Aryan <raj.aryan@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 91 ++++++++++++++++++++++++++++++++
1 file changed, 91 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts
index bf6fb12ad990..c4038c1f1e88 100644
--- a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts
+++ b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts
@@ -7,6 +7,7 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/leds/common.h>
+#include <dt-bindings/iio/qcom,spmi-vadc.h>
#include "agatti.dtsi"
#include "pm4125.dtsi"
@@ -33,6 +34,68 @@ clk40m: can-clk {
};
};
+ msm_therm_bridge: msm-therm-bridge {
+ compatible = "generic-adc-thermal";
+ io-channels = <&pm4125_adc ADC5_AMUX_THM3_100K_PU>;
+ io-channel-names = "sensor-channel";
+ #thermal-sensor-cells = <0>;
+ };
+
+ quiet_therm_bridge: quiet-therm-bridge {
+ compatible = "generic-adc-thermal";
+ io-channels = <&pm4125_adc ADC5_AMUX_THM2_100K_PU>;
+ io-channel-names = "sensor-channel";
+ #thermal-sensor-cells = <0>;
+ };
+
+ xo_therm_bridge: xo-therm-bridge {
+ compatible = "generic-adc-thermal";
+ io-channels = <&pm4125_adc ADC5_XO_THERM_100K_PU>;
+ io-channel-names = "sensor-channel";
+ #thermal-sensor-cells = <0>;
+ };
+
+ thermal-zones {
+ sys-1-thermal {
+ polling-delay-passive = <2000>;
+ thermal-sensors = <&msm_therm_bridge>;
+
+ trips {
+ active-config0 {
+ temperature = <80000>;
+ hysteresis = <2000>;
+ type = "hot";
+ };
+ };
+ };
+
+ sys-2-thermal {
+ polling-delay-passive = <2000>;
+ thermal-sensors = <&quiet_therm_bridge>;
+
+ trips {
+ active-config0 {
+ temperature = <80000>;
+ hysteresis = <2000>;
+ type = "hot";
+ };
+ };
+ };
+
+ sys-3-thermal {
+ polling-delay-passive = <2000>;
+ thermal-sensors = <&xo_therm_bridge>;
+
+ trips {
+ active-config0 {
+ temperature = <80000>;
+ hysteresis = <2000>;
+ type = "hot";
+ };
+ };
+ };
+ };
+
gpio-keys {
compatible = "gpio-keys";
label = "gpio-keys";
@@ -333,6 +396,34 @@ vreg_l7p: ldo7 {
};
};
+&pm4125_adc {
+ status = "okay";
+
+ channel@4c {
+ reg = <ADC5_XO_THERM_100K_PU>;
+ label = "xo_therm";
+ qcom,ratiometric;
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ };
+
+ channel@4e {
+ reg = <ADC5_AMUX_THM2_100K_PU>;
+ label = "quiet_therm";
+ qcom,ratiometric;
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ };
+
+ channel@4f {
+ reg = <ADC5_AMUX_THM3_100K_PU>;
+ label = "msm_therm";
+ qcom,ratiometric;
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ };
+};
+
&i2c2_gpio {
clock-frequency = <400000>;
status = "okay";
---
base-commit: 3d08ff75a47a3e7e2ab45a3bcab6723b4d906422
change-id: 20260812-pm4125-adc-thermal-4c0f713737fa
prerequisite-message-id: 20260809-shikra_adc_support-v5-0-bf6882d18bad@oss.qualcomm.com
prerequisite-patch-id: 7c371f4d9b9af04a9765b0b5b084c498e8979fb6
prerequisite-patch-id: dde0d9ae1d46c16407cfcfa818dd427904748af8
prerequisite-patch-id: 391360a3fcb2c44648ec62930e3af61d4eb12001
prerequisite-patch-id: a1c862130f572ca027bc9c482dede8da183e51b1
Best regards,
--
Raj Aryan <raj.aryan@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: Add PMIC thermal support for Agatti QRB2210-RB1 platform
2026-08-24 14:49 [PATCH] arm64: dts: qcom: Add PMIC thermal support for Agatti QRB2210-RB1 platform Raj Aryan
@ 2026-09-03 9:02 ` Konrad Dybcio
2026-09-03 9:04 ` Konrad Dybcio
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2026-09-03 9:02 UTC (permalink / raw)
To: Raj Aryan, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 8/24/26 4:49 PM, Raj Aryan wrote:
> Add ADC channels for msm, quiet and xo thermistors along with
> their ADC thermal bridge nodes and thermal zones for PMIC
> thermal mitigation.
>
> Signed-off-by: Raj Aryan <raj.aryan@oss.qualcomm.com>
> ---
[...]
> + msm_therm_bridge: msm-therm-bridge {
> + compatible = "generic-adc-thermal";
> + io-channels = <&pm4125_adc ADC5_AMUX_THM3_100K_PU>;
> + io-channel-names = "sensor-channel";
> + #thermal-sensor-cells = <0>;
> + };
> +
> + quiet_therm_bridge: quiet-therm-bridge {
> + compatible = "generic-adc-thermal";
> + io-channels = <&pm4125_adc ADC5_AMUX_THM2_100K_PU>;
> + io-channel-names = "sensor-channel";
> + #thermal-sensor-cells = <0>;
> + };
> +
> + xo_therm_bridge: xo-therm-bridge {
> + compatible = "generic-adc-thermal";
> + io-channels = <&pm4125_adc ADC5_XO_THERM_100K_PU>;
> + io-channel-names = "sensor-channel";
> + #thermal-sensor-cells = <0>;
> + };
I see the SoM also has a PA_THERM0 thermistor at AMUX1
> +
> + thermal-zones {
> + sys-1-thermal {
Please give these meaningful names
Also, the XO one can go to the PMIC DTSI since it's always there
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: Add PMIC thermal support for Agatti QRB2210-RB1 platform
2026-08-24 14:49 [PATCH] arm64: dts: qcom: Add PMIC thermal support for Agatti QRB2210-RB1 platform Raj Aryan
2026-09-03 9:02 ` Konrad Dybcio
@ 2026-09-03 9:04 ` Konrad Dybcio
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2026-09-03 9:04 UTC (permalink / raw)
To: Raj Aryan, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 8/24/26 4:49 PM, Raj Aryan wrote:
> Add ADC channels for msm, quiet and xo thermistors along with
> their ADC thermal bridge nodes and thermal zones for PMIC
> thermal mitigation.
>
> Signed-off-by: Raj Aryan <raj.aryan@oss.qualcomm.com>
> ---
[...]
> ---
> base-commit: 3d08ff75a47a3e7e2ab45a3bcab6723b4d906422
> change-id: 20260812-pm4125-adc-thermal-4c0f713737fa
> prerequisite-message-id: 20260809-shikra_adc_support-v5-0-bf6882d18bad@oss.qualcomm.com
> prerequisite-patch-id: 7c371f4d9b9af04a9765b0b5b084c498e8979fb6
> prerequisite-patch-id: dde0d9ae1d46c16407cfcfa818dd427904748af8
> prerequisite-patch-id: 391360a3fcb2c44648ec62930e3af61d4eb12001
> prerequisite-patch-id: a1c862130f572ca027bc9c482dede8da183e51b1
In this section you say:
"""
I need the 4 patches titled:
arm64: dts: qcom: pm4125: Add VADC and temp alarm nodes
arm64: dts: qcom: pm8005: Add temp alarm node
arm64: dts: qcom: Add PMIC thermal support for Shikra CQ2390M SoM platform
arm64: dts: qcom: Add PMIC thermal support for Shikra IQ2390S SoM platform
to land before this may be accepted
"""
which is overly broad and you're hurting your work by introducing
unnecessary dependencies (because you don't need the entirety of that
series and you don't know whether it'll all be accepted at once)
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-03 9:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-24 14:49 [PATCH] arm64: dts: qcom: Add PMIC thermal support for Agatti QRB2210-RB1 platform Raj Aryan
2026-09-03 9:02 ` Konrad Dybcio
2026-09-03 9:04 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®