From: Joe Perches <joe@perches.com>
To: Ross Schmidt <ross.schm.dev@gmail.com>, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: rtl8723bs: os_dep: fixed spacing around operators issue
Date: Mon, 14 Sep 2020 19:30:02 -0700 [thread overview]
Message-ID: <00e6faaceed28ceb81777a63caffc512885a6efb.camel@perches.com> (raw)
In-Reply-To: <20200915001731.28986-3-ross.schm.dev@gmail.com>
On Mon, 2020-09-14 at 19:17 -0500, Ross Schmidt wrote:
> Fixed a coding style issue by adding spaces around operators in
> sdio_ops_linux.c to fix checkpatch checks.
Hello Ross.
If you want to do more than fix whitespace,
please look at the #define for DBG_871X.
All the uses with a KERN_<LEVEL> are broken
and should be modified as _dbgdump is just
printk and DRIVER_PREFIX is "RTL8723BS: "
so the KERN_<LEVEL> after the DRIVER_PREFIX.
That's just broken.
#define DBG_871X(...) do {\
_dbgdump(DRIVER_PREFIX __VA_ARGS__);\
} while (0)
Realistically, the DBG_871X macro family should just
use pr_debug and all the KERN_<LEVEL> uses should be
removed.
The define and uses of RT_TRACE should also just be
converted to use pr_debug or some other function
to perhaps reduce overall object size
prev parent reply other threads:[~2020-09-15 2:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 0:17 [PATCH 1/3] staging: rtl8723bs: os_dep: fixed trailing statements Ross Schmidt
2020-09-15 0:17 ` [PATCH 2/3] staging: rtl8723bs: os_dep: fixed bracing issue Ross Schmidt
2020-09-15 0:17 ` [PATCH 3/3] staging: rtl8723bs: os_dep: fixed spacing around operators issue Ross Schmidt
2020-09-15 2:30 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00e6faaceed28ceb81777a63caffc512885a6efb.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ross.schm.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome