From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Sibi Sankar <quic_sibis@quicinc.com>, andersson@kernel.org
Cc: agross@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
konrad.dybcio@somainline.org, robimarko@gmail.com,
quic_gurus@quicinc.com
Subject: Re: [PATCH V8 2/2] firmware: qcom: scm: Add wait-queue handling logic
Date: Wed, 11 Jan 2023 16:01:58 +0000 [thread overview]
Message-ID: <00e70137-3cc3-877e-5435-ac15f750f466@linaro.org> (raw)
In-Reply-To: <20230111101718.9225-3-quic_sibis@quicinc.com>
On 11/01/2023 10:17, Sibi Sankar wrote:
> +static int qcom_scm_waitq_wakeup(struct qcom_scm *scm, unsigned int wq_ctx, bool wake_all)
> +{
> + int ret;
> +
> + ret = qcom_scm_assert_valid_wq_ctx(wq_ctx);
> + if (ret)
> + return ret;
> +
> + if (wake_all)
> + complete_all(&__scm->waitq_comp);
As you explained in v7 that there will be only one caller at any point
in time and that will be synchronous, so complete_all here is a dead
code, isn't it?
Adding complete_all here is missleading and will require reinit
completion in case you want to reuse the same completion.
AFAIU, you should remove support to wake_all in this patchset and add it
when we really can do multiple scm calls simultaneously.
--srini
--srini
> + else
> + complete(&__scm->waitq_comp);
> +
next prev parent reply other threads:[~2023-01-11 16:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 10:17 [PATCH V8 0/2] SCM: Add support for wait-queue aware firmware Sibi Sankar
2023-01-11 10:17 ` [PATCH V8 1/2] dt-bindings: firmware: qcom,scm: Add optional interrupt Sibi Sankar
2023-01-11 10:17 ` [PATCH V8 2/2] firmware: qcom: scm: Add wait-queue handling logic Sibi Sankar
2023-01-11 16:01 ` Srinivas Kandagatla [this message]
2023-01-12 18:42 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00e70137-3cc3-877e-5435-ac15f750f466@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_gurus@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®