* [PATCH v7 0/2] arm64: dts: fsd: Add Ethernet support for FSD SoC [not found] <CGME20250220073939epcas5p24b926b2dd3bcfda426b03309d8c29590@epcas5p2.samsung.com> @ 2025-02-20 7:35 ` Swathi K S [not found] ` <CGME20250220073944epcas5p495ee305ca577a7e1be51ff916f20fc53@epcas5p4.samsung.com> [not found] ` <CGME20250220073948epcas5p1d90c5111fda1ccc4395dbe918066caca@epcas5p1.samsung.com> 0 siblings, 2 replies; 5+ messages in thread From: Swathi K S @ 2025-02-20 7:35 UTC (permalink / raw) To: krzk+dt, linux-fsd, robh, conor+dt, richardcochran, alim.akhtar Cc: jayati.sahu, swathi.ks, linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel, netdev, pankaj.dubey, ravi.patel, gost.dev FSD platform has two instances of EQoS IP, one is in FSYS0 block and another one is in PERIC block. This patch series add required DT file modifications for the same. Changes since v1: 1. Addressed the format related corrections. 2. Addressed the MAC address correction. Changes since v2: 1. Corrected intendation issues. Changes since v3: 1. Removed alias names of ethernet nodes Changes since v4: 1. Added more details to the commit message as per review comment. Changes since v5: 1. Avoided inserting node in the end and inserted it in between as per address. 2. Changed the node label. 3. Separating DT patches from net patches and posting in different branches. Changes since v6: 1. Addressed Andrew's review comment and removed phy-mode from .dtsi to .dts Here is the link to v6 patches for reference: https://lore.kernel.org/netdev/20250213132328.4405-1-swathi.ks@samsung.com/ This patch depends on the DT binding patch https://lore.kernel.org/netdev/20250220043712.31966-2-swathi.ks@samsung.com/ And the driver patch https://lore.kernel.org/netdev/20250220043712.31966-3-swathi.ks@samsung.com/ Swathi K S (2): arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC arm64: dts: fsd: Add Ethernet support for PERIC Block of FSD SoC arch/arm64/boot/dts/tesla/fsd-evb.dts | 20 ++++ arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 112 +++++++++++++++++++++ arch/arm64/boot/dts/tesla/fsd.dtsi | 47 +++++++++ 3 files changed, 179 insertions(+) -- 2.17.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <CGME20250220073944epcas5p495ee305ca577a7e1be51ff916f20fc53@epcas5p4.samsung.com>]
* [PATCH v7 1/2] arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC [not found] ` <CGME20250220073944epcas5p495ee305ca577a7e1be51ff916f20fc53@epcas5p4.samsung.com> @ 2025-02-20 7:35 ` Swathi K S 2025-03-01 13:59 ` Krzysztof Kozlowski 0 siblings, 1 reply; 5+ messages in thread From: Swathi K S @ 2025-02-20 7:35 UTC (permalink / raw) To: krzk+dt, linux-fsd, robh, conor+dt, richardcochran, alim.akhtar Cc: jayati.sahu, swathi.ks, linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel, netdev, pankaj.dubey, ravi.patel, gost.dev The FSD SoC contains two instances of Synopsys DWC QoS Ethernet IP, one in FSYS0 block and other in PERIC block. The ethernet interface is managed by a switch which is not managed by Linux. Adds device tree node for Ethernet in FSYS0 Block and enables the same for FSD platform. Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> Signed-off-by: Jayati Sahu <jayati.sahu@samsung.com> Signed-off-by: Swathi K S <swathi.ks@samsung.com> --- arch/arm64/boot/dts/tesla/fsd-evb.dts | 10 ++++ arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 56 ++++++++++++++++++++++ arch/arm64/boot/dts/tesla/fsd.dtsi | 20 ++++++++ 3 files changed, 86 insertions(+) diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts b/arch/arm64/boot/dts/tesla/fsd-evb.dts index 8d7794642900..321270a07651 100644 --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts @@ -64,6 +64,16 @@ }; }; +ðernet0 { + status = "okay"; + + phy-mode = "rgmii-id"; + fixed-link { + speed = <1000>; + full-duplex; + }; +}; + &fin_pll { clock-frequency = <24000000>; }; diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi index 3f898cf4874c..cb437483ff6e 100644 --- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi +++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi @@ -64,6 +64,62 @@ samsung,pin-pud = <FSD_PIN_PULL_UP>; samsung,pin-drv = <FSD_PIN_DRV_LV4>; }; + + eth0_tx_clk: eth0-tx-clk-pins { + samsung,pins = "gpf0-0"; + samsung,pin-function = <FSD_PIN_FUNC_2>; + samsung,pin-pud = <FSD_PIN_PULL_DOWN>; + samsung,pin-drv = <FSD_PIN_DRV_LV6>; + }; + + eth0_tx_data: eth0-tx-data-pins { + samsung,pins = "gpf0-1", "gpf0-2", "gpf0-3", "gpf0-4"; + samsung,pin-function = <FSD_PIN_FUNC_2>; + samsung,pin-pud = <FSD_PIN_PULL_UP>; + samsung,pin-drv = <FSD_PIN_DRV_LV6>; + }; + + eth0_tx_ctrl: eth0-tx-ctrl-pins { + samsung,pins = "gpf0-5"; + samsung,pin-function = <FSD_PIN_FUNC_2>; + samsung,pin-pud = <FSD_PIN_PULL_UP>; + samsung,pin-drv = <FSD_PIN_DRV_LV6>; + }; + + eth0_phy_intr: eth0-phy-intr-pins { + samsung,pins = "gpf0-6"; + samsung,pin-function = <FSD_PIN_FUNC_2>; + samsung,pin-pud = <FSD_PIN_PULL_NONE>; + samsung,pin-drv = <FSD_PIN_DRV_LV4>; + }; + + eth0_rx_clk: eth0-rx-clk-pins { + samsung,pins = "gpf1-0"; + samsung,pin-function = <FSD_PIN_FUNC_2>; + samsung,pin-pud = <FSD_PIN_PULL_UP>; + samsung,pin-drv = <FSD_PIN_DRV_LV6>; + }; + + eth0_rx_data: eth0-rx-data-pins { + samsung,pins = "gpf1-1", "gpf1-2", "gpf1-3", "gpf1-4"; + samsung,pin-function = <FSD_PIN_FUNC_2>; + samsung,pin-pud = <FSD_PIN_PULL_UP>; + samsung,pin-drv = <FSD_PIN_DRV_LV6>; + }; + + eth0_rx_ctrl: eth0-rx-ctrl-pins { + samsung,pins = "gpf1-5"; + samsung,pin-function = <FSD_PIN_FUNC_2>; + samsung,pin-pud = <FSD_PIN_PULL_UP>; + samsung,pin-drv = <FSD_PIN_DRV_LV6>; + }; + + eth0_mdio: eth0-mdio-pins { + samsung,pins = "gpf1-6", "gpf1-7"; + samsung,pin-function = <FSD_PIN_FUNC_2>; + samsung,pin-pud = <FSD_PIN_PULL_NONE>; + samsung,pin-drv = <FSD_PIN_DRV_LV4>; + }; }; &pinctrl_peric { diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi index 690b4ed9c29b..01850fbf761f 100644 --- a/arch/arm64/boot/dts/tesla/fsd.dtsi +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi @@ -1007,6 +1007,26 @@ clocks = <&clock_fsys0 UFS0_MPHY_REFCLK_IXTAL26>; clock-names = "ref_clk"; }; + + ethernet0: ethernet@15300000 { + compatible = "tesla,fsd-ethqos"; + reg = <0x0 0x15300000 0x0 0x10000>; + interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "macirq"; + clocks = <&clock_fsys0 FSYS0_EQOS_TOP0_IPCLKPORT_CLK_PTP_REF_I>, + <&clock_fsys0 FSYS0_EQOS_TOP0_IPCLKPORT_ACLK_I>, + <&clock_fsys0 FSYS0_EQOS_TOP0_IPCLKPORT_HCLK_I>, + <&clock_fsys0 FSYS0_EQOS_TOP0_IPCLKPORT_RGMII_CLK_I>, + <&clock_fsys0 FSYS0_EQOS_TOP0_IPCLKPORT_CLK_RX_I>; + clock-names = "ptp_ref", "master_bus", "slave_bus", "tx", "rx"; + pinctrl-names = "default"; + pinctrl-0 = <ð0_tx_clk>, <ð0_tx_data>, <ð0_tx_ctrl>, + <ð0_phy_intr>, <ð0_rx_clk>, <ð0_rx_data>, + <ð0_rx_ctrl>, <ð0_mdio>; + local-mac-address = [00 00 00 00 00 00]; + iommus = <&smmu_fsys0 0x0 0x1>; + status = "disabled"; + }; }; }; -- 2.17.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v7 1/2] arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC 2025-02-20 7:35 ` [PATCH v7 1/2] arm64: dts: fsd: Add Ethernet support for FSYS0 Block of " Swathi K S @ 2025-03-01 13:59 ` Krzysztof Kozlowski 2025-03-06 3:48 ` Swathi K S 0 siblings, 1 reply; 5+ messages in thread From: Krzysztof Kozlowski @ 2025-03-01 13:59 UTC (permalink / raw) To: Swathi K S, krzk+dt, linux-fsd, robh, conor+dt, richardcochran, alim.akhtar Cc: jayati.sahu, linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel, netdev, pankaj.dubey, ravi.patel, gost.dev On 20/02/2025 08:35, Swathi K S wrote: > &pinctrl_peric { > diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi > index 690b4ed9c29b..01850fbf761f 100644 > --- a/arch/arm64/boot/dts/tesla/fsd.dtsi > +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi > @@ -1007,6 +1007,26 @@ > clocks = <&clock_fsys0 UFS0_MPHY_REFCLK_IXTAL26>; > clock-names = "ref_clk"; > }; > + > + ethernet0: ethernet@15300000 { > + compatible = "tesla,fsd-ethqos"; I don't see bindings in the linux-next, so I am dropping this patch from my queue. Please resend when the bindings hit the linux-next. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v7 1/2] arm64: dts: fsd: Add Ethernet support for FSYS0 Block of FSD SoC 2025-03-01 13:59 ` Krzysztof Kozlowski @ 2025-03-06 3:48 ` Swathi K S 0 siblings, 0 replies; 5+ messages in thread From: Swathi K S @ 2025-03-06 3:48 UTC (permalink / raw) To: 'Krzysztof Kozlowski', krzk+dt, linux-fsd, robh, conor+dt, richardcochran, alim.akhtar Cc: jayati.sahu, linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel, netdev, pankaj.dubey, ravi.patel, gost.dev > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 01 March 2025 19:29 > To: Swathi K S <swathi.ks@samsung.com>; krzk+dt@kernel.org; linux- > fsd@tesla.com; robh@kernel.org; conor+dt@kernel.org; > richardcochran@gmail.com; alim.akhtar@samsung.com > Cc: jayati.sahu@samsung.com; linux-arm-kernel@lists.infradead.org; linux- > samsung-soc@vger.kernel.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; netdev@vger.kernel.org; > pankaj.dubey@samsung.com; ravi.patel@samsung.com; > gost.dev@samsung.com > Subject: Re: [PATCH v7 1/2] arm64: dts: fsd: Add Ethernet support for FSYS0 > Block of FSD SoC > > On 20/02/2025 08:35, Swathi K S wrote: > > &pinctrl_peric { > > diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi > > b/arch/arm64/boot/dts/tesla/fsd.dtsi > > index 690b4ed9c29b..01850fbf761f 100644 > > --- a/arch/arm64/boot/dts/tesla/fsd.dtsi > > +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi > > @@ -1007,6 +1007,26 @@ > > clocks = <&clock_fsys0 > UFS0_MPHY_REFCLK_IXTAL26>; > > clock-names = "ref_clk"; > > }; > > + > > + ethernet0: ethernet@15300000 { > > + compatible = "tesla,fsd-ethqos"; > > I don't see bindings in the linux-next, so I am dropping this patch from my > queue. Please resend when the bindings hit the linux-next. Thanks for informing me. I have posted v8 of DT bindings: https://lore.kernel.org/netdev/89dcfb2a-d093-48f9-b6d7-af99b383a1bc@kernel.org/ Will wait for some time for the DT binding to reflect on linux-next before posting v8 patches of DT files. - Swathi > > Best regards, > Krzysztof ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <CGME20250220073948epcas5p1d90c5111fda1ccc4395dbe918066caca@epcas5p1.samsung.com>]
* [PATCH v7 2/2] arm64: dts: fsd: Add Ethernet support for PERIC Block of FSD SoC [not found] ` <CGME20250220073948epcas5p1d90c5111fda1ccc4395dbe918066caca@epcas5p1.samsung.com> @ 2025-02-20 7:35 ` Swathi K S 0 siblings, 0 replies; 5+ messages in thread From: Swathi K S @ 2025-02-20 7:35 UTC (permalink / raw) To: krzk+dt, linux-fsd, robh, conor+dt, richardcochran, alim.akhtar Cc: jayati.sahu, swathi.ks, linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel, netdev, pankaj.dubey, ravi.patel, gost.dev The FSD SoC contains two instances of Synopsys DWC QoS Ethernet IP, one in FSYS0 block and other in PERIC block. The ethernet interface is connected to a switch which is not managed by Linux. Adds device tree node for Ethernet in PERIC Block and enables the same for FSD platform. Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> Signed-off-by: Jayati Sahu <jayati.sahu@samsung.com> Signed-off-by: Swathi K S <swathi.ks@samsung.com> --- arch/arm64/boot/dts/tesla/fsd-evb.dts | 10 ++++ arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 56 ++++++++++++++++++++++ arch/arm64/boot/dts/tesla/fsd.dtsi | 27 +++++++++++ 3 files changed, 93 insertions(+) diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts b/arch/arm64/boot/dts/tesla/fsd-evb.dts index 321270a07651..9ff22e1c8723 100644 --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts @@ -74,6 +74,16 @@ }; }; +ðernet1 { + status = "okay"; + + phy-mode = "rgmii-id"; + fixed-link { + speed = <1000>; + full-duplex; + }; +}; + &fin_pll { clock-frequency = <24000000>; }; diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi index cb437483ff6e..6f4658f57453 100644 --- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi +++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi @@ -437,6 +437,62 @@ samsung,pin-pud = <FSD_PIN_PULL_DOWN>; samsung,pin-drv = <FSD_PIN_DRV_LV4>; }; + + eth1_tx_clk: eth1-tx-clk-pins { + samsung,pins = "gpf2-0"; + samsung,pin-function = <FSD_PIN_FUNC_2>; + samsung,pin-pud = <FSD_PIN_PULL_DOWN>; + samsung,pin-drv = <FSD_PIN_DRV_LV6>; + }; + + eth1_tx_data: eth1-tx-data-pins { + samsung,pins = "gpf2-1", "gpf2-2", "gpf2-3", "gpf2-4"; + samsung,pin-function = <FSD_PIN_FUNC_2>; + samsung,pin-pud = <FSD_PIN_PULL_UP>; + samsung,pin-drv = <FSD_PIN_DRV_LV6>; + }; + + eth1_tx_ctrl: eth1-tx-ctrl-pins { + samsung,pins = "gpf2-5"; + samsung,pin-function = <FSD_PIN_FUNC_2>; + samsung,pin-pud = <FSD_PIN_PULL_UP>; + samsung,pin-drv = <FSD_PIN_DRV_LV6>; + }; + + eth1_phy_intr: eth1-phy-intr-pins { + samsung,pins = "gpf2-6"; + samsung,pin-function = <FSD_PIN_FUNC_2>; + samsung,pin-pud = <FSD_PIN_PULL_UP>; + samsung,pin-drv = <FSD_PIN_DRV_LV4>; + }; + + eth1_rx_clk: eth1-rx-clk-pins { + samsung,pins = "gpf3-0"; + samsung,pin-function = <FSD_PIN_FUNC_2>; + samsung,pin-pud = <FSD_PIN_PULL_UP>; + samsung,pin-drv = <FSD_PIN_DRV_LV6>; + }; + + eth1_rx_data: eth1-rx-data-pins { + samsung,pins = "gpf3-1", "gpf3-2", "gpf3-3", "gpf3-4"; + samsung,pin-function = <FSD_PIN_FUNC_2>; + samsung,pin-pud = <FSD_PIN_PULL_UP>; + samsung,pin-drv = <FSD_PIN_DRV_LV6>; + }; + + eth1_rx_ctrl: eth1-rx-ctrl-pins { + samsung,pins = "gpf3-5"; + samsung,pin-function = <FSD_PIN_FUNC_2>; + samsung,pin-pud = <FSD_PIN_PULL_UP>; + samsung,pin-drv = <FSD_PIN_DRV_LV6>; + }; + + eth1_mdio: eth1-mdio-pins { + samsung,pins = "gpf3-6", "gpf3-7"; + samsung,pin-function = <FSD_PIN_FUNC_2>; + samsung,pin-pud = <FSD_PIN_PULL_UP>; + samsung,pin-drv = <FSD_PIN_DRV_LV4>; + }; }; &pinctrl_pmu { diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi index 01850fbf761f..f96a69e25156 100644 --- a/arch/arm64/boot/dts/tesla/fsd.dtsi +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi @@ -979,6 +979,33 @@ memory-region = <&mfc_left>; }; + ethernet1: ethernet@14300000 { + compatible = "tesla,fsd-ethqos"; + reg = <0x0 0x14300000 0x0 0x10000>; + interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "macirq"; + clocks = <&clock_peric PERIC_EQOS_TOP_IPCLKPORT_CLK_PTP_REF_I>, + <&clock_peric PERIC_EQOS_TOP_IPCLKPORT_ACLK_I>, + <&clock_peric PERIC_EQOS_TOP_IPCLKPORT_HCLK_I>, + <&clock_peric PERIC_EQOS_TOP_IPCLKPORT_RGMII_CLK_I>, + <&clock_peric PERIC_EQOS_TOP_IPCLKPORT_CLK_RX_I>, + <&clock_peric PERIC_BUS_D_PERIC_IPCLKPORT_EQOSCLK>, + <&clock_peric PERIC_BUS_P_PERIC_IPCLKPORT_EQOSCLK>, + <&clock_peric PERIC_EQOS_PHYRXCLK_MUX>, + <&clock_peric PERIC_EQOS_PHYRXCLK>, + <&clock_peric PERIC_DOUT_RGMII_CLK>; + clock-names = "ptp_ref", "master_bus", "slave_bus", "tx", "rx", + "master2_bus", "slave2_bus", "eqos_rxclk_mux", + "eqos_phyrxclk", "dout_peric_rgmii_clk"; + pinctrl-names = "default"; + pinctrl-0 = <ð1_tx_clk>, <ð1_tx_data>, <ð1_tx_ctrl>, + <ð1_phy_intr>, <ð1_rx_clk>, <ð1_rx_data>, + <ð1_rx_ctrl>, <ð1_mdio>; + local-mac-address = [00 00 00 00 00 00]; + iommus = <&smmu_peric 0x0 0x1>; + status = "disabled"; + }; + ufs: ufs@15120000 { compatible = "tesla,fsd-ufs"; reg = <0x0 0x15120000 0x0 0x200>, /* 0: HCI standard */ -- 2.17.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-03-06 3:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20250220073939epcas5p24b926b2dd3bcfda426b03309d8c29590@epcas5p2.samsung.com>
2025-02-20 7:35 ` [PATCH v7 0/2] arm64: dts: fsd: Add Ethernet support for FSD SoC Swathi K S
[not found] ` <CGME20250220073944epcas5p495ee305ca577a7e1be51ff916f20fc53@epcas5p4.samsung.com>
2025-02-20 7:35 ` [PATCH v7 1/2] arm64: dts: fsd: Add Ethernet support for FSYS0 Block of " Swathi K S
2025-03-01 13:59 ` Krzysztof Kozlowski
2025-03-06 3:48 ` Swathi K S
[not found] ` <CGME20250220073948epcas5p1d90c5111fda1ccc4395dbe918066caca@epcas5p1.samsung.com>
2025-02-20 7:35 ` [PATCH v7 2/2] arm64: dts: fsd: Add Ethernet support for PERIC " Swathi K S
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®