Re: [PATCH 1/2] net: thunder_bgx: fix fwnode leak in bgx_init_of_phy()

Re: [PATCH 1/2] net: thunder_bgx: fix fwnode leak in bgx_init_of_phy()

[Markus Elfring]

> If a child returned by device_for_each_child_node() is not backed by
> a device_node, to_of_node() returns NULL and the loop is aborted with
> a bare break, without releasing the reference on the current fwnode
> that device_for_each_child_node() took. Call fwnode_handle_put()
> before breaking out of the loop, mirroring the existing of_node_put()
> call a few lines below for the "lmac == bgx->max_lmac" exit path.

How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.2#n145
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v7.2#n34

https://elixir.bootlin.com/linux/v7.2/source/drivers/net/ethernet/cavium/thunder/thunder_bgx.c#L1466-L1531

See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/maintainer-netdev.rst?id=v7.2#n3


Would a cover letter be helpful also for the presented small “patch series”?

Regards,
Markus