From: Manuel Ebner <manuelebnerli@mailbox.org>
To: Alexandre Courbot <acourbot@nvidia.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Lyude Paul <lyude@redhat.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/gem/shmem: fix documentation of __drm_gem_shmem_free_sgt_locked
Date: Mon, 19 Oct 2026 20:44:38 +0200 [thread overview]
Message-ID: <011f1b7bc698d01789f01e9d3263d7b012149693.camel@mailbox.org> (raw)
In-Reply-To: <20260622-b4-gem_shmem_free_doc-v1-1-85496c597b18@nvidia.com>
On Mon, 2026-06-22 at 22:13 +0900, Alexandre Courbot wrote:
> The kernel-doc comment for __drm_gem_shmem_free_sgt_locked erroneously
> mentions __drm_gem_shmem_release_sgt_locked, triggering the following
> warning when building with W=e:
>
> Warning: drivers/gpu/drm/drm_gem_shmem_helper.c:174 expecting prototype for __drm_gem_shmem_release_sgt_locked(). Prototype was for __drm_gem_shmem_free_sgt_locked() instead
>
> Fixes: b78dab829760 ("drm/gem/shmem: Introduce __drm_gem_shmem_free_sgt_locked()")
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Reviewed-by: Manuel Ebner <manuelebnerli@mailbox.org>
> ---
> drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
> index c989459eb215..6319fe44a2da 100644
> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
> @@ -159,7 +159,7 @@ struct drm_gem_shmem_object *drm_gem_shmem_create(struct drm_device *dev, size_t
> EXPORT_SYMBOL_GPL(drm_gem_shmem_create);
>
> /**
> - * __drm_gem_shmem_release_sgt_locked - Unpin and DMA unmap pages, and release the
> + * __drm_gem_shmem_free_sgt_locked - Unpin and DMA unmap pages, and release the
> * cached scatter/gather table for an shmem GEM object.
> * @shmem: shmem GEM object
> *
>
> ---
> base-commit: f0c1bb8ead8a9790e7d0339354598b50a9c6789a
> change-id: 20260622-b4-gem_shmem_free_doc-6dd48f97cd48
>
> Best regards,
> --
> Alexandre Courbot <acourbot@nvidia.com>
prev parent reply other threads:[~2026-10-19 18:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 13:13 Alexandre Courbot
2026-06-22 13:28 ` Thomas Zimmermann
2026-10-19 18:44 ` Manuel Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=011f1b7bc698d01789f01e9d3263d7b012149693.camel@mailbox.org \
--to=manuelebnerli@mailbox.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®