[PATCH] drm/gem/shmem: fix documentation of __drm_gem_shmem_free_sgt_locked

[PATCH] drm/gem/shmem: fix documentation of __drm_gem_shmem_free_sgt_locked

[Alexandre Courbot]

The kernel-doc comment for __drm_gem_shmem_free_sgt_locked erroneously
mentions __drm_gem_shmem_release_sgt_locked, triggering the following
warning when building with W=e:

    Warning: drivers/gpu/drm/drm_gem_shmem_helper.c:174 expecting prototype for __drm_gem_shmem_release_sgt_locked(). Prototype was for __drm_gem_shmem_free_sgt_locked() instead

Fixes: b78dab829760 ("drm/gem/shmem: Introduce __drm_gem_shmem_free_sgt_locked()")
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
 drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
index c989459eb215..6319fe44a2da 100644
--- a/drivers/gpu/drm/drm_gem_shmem_helper.c
+++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
@@ -159,7 +159,7 @@ struct drm_gem_shmem_object *drm_gem_shmem_create(struct drm_device *dev, size_t
 EXPORT_SYMBOL_GPL(drm_gem_shmem_create);
 
 /**
- * __drm_gem_shmem_release_sgt_locked - Unpin and DMA unmap pages, and release the
+ * __drm_gem_shmem_free_sgt_locked - Unpin and DMA unmap pages, and release the
  * cached scatter/gather table for an shmem GEM object.
  * @shmem: shmem GEM object
  *

---
base-commit: f0c1bb8ead8a9790e7d0339354598b50a9c6789a
change-id: 20260622-b4-gem_shmem_free_doc-6dd48f97cd48

Best regards,
--  
Alexandre Courbot <acourbot@nvidia.com>

Re: [PATCH] drm/gem/shmem: fix documentation of __drm_gem_shmem_free_sgt_locked

[Thomas Zimmermann]

Am 22.06.26 um 15:13 schrieb Alexandre Courbot:
> The kernel-doc comment for __drm_gem_shmem_free_sgt_locked erroneously
> mentions __drm_gem_shmem_release_sgt_locked, triggering the following
> warning when building with W=e:
>
>      Warning: drivers/gpu/drm/drm_gem_shmem_helper.c:174 expecting prototype for __drm_gem_shmem_release_sgt_locked(). Prototype was for __drm_gem_shmem_free_sgt_locked() instead
>
> Fixes: b78dab829760 ("drm/gem/shmem: Introduce __drm_gem_shmem_free_sgt_locked()")
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
> index c989459eb215..6319fe44a2da 100644
> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
> @@ -159,7 +159,7 @@ struct drm_gem_shmem_object *drm_gem_shmem_create(struct drm_device *dev, size_t
>   EXPORT_SYMBOL_GPL(drm_gem_shmem_create);
>   
>   /**
> - * __drm_gem_shmem_release_sgt_locked - Unpin and DMA unmap pages, and release the
> + * __drm_gem_shmem_free_sgt_locked - Unpin and DMA unmap pages, and release the
>    * cached scatter/gather table for an shmem GEM object.
>    * @shmem: shmem GEM object
>    *
>
> ---
> base-commit: f0c1bb8ead8a9790e7d0339354598b50a9c6789a
> change-id: 20260622-b4-gem_shmem_free_doc-6dd48f97cd48
>
> Best regards,
> --
> Alexandre Courbot <acourbot@nvidia.com>
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)

Re: [PATCH] drm/gem/shmem: fix documentation of __drm_gem_shmem_free_sgt_locked

[Manuel Ebner]

On Mon, 2026-06-22 at 22:13 +0900, Alexandre Courbot wrote:
> The kernel-doc comment for __drm_gem_shmem_free_sgt_locked erroneously
> mentions __drm_gem_shmem_release_sgt_locked, triggering the following
> warning when building with W=e:
> 
>     Warning: drivers/gpu/drm/drm_gem_shmem_helper.c:174 expecting prototype for __drm_gem_shmem_release_sgt_locked(). Prototype was for __drm_gem_shmem_free_sgt_locked() instead
> 
> Fixes: b78dab829760 ("drm/gem/shmem: Introduce __drm_gem_shmem_free_sgt_locked()")
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>

Reviewed-by: Manuel Ebner <manuelebnerli@mailbox.org>

> ---
>  drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
> index c989459eb215..6319fe44a2da 100644
> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
> @@ -159,7 +159,7 @@ struct drm_gem_shmem_object *drm_gem_shmem_create(struct drm_device *dev, size_t
>  EXPORT_SYMBOL_GPL(drm_gem_shmem_create);
>  
>  /**
> - * __drm_gem_shmem_release_sgt_locked - Unpin and DMA unmap pages, and release the
> + * __drm_gem_shmem_free_sgt_locked - Unpin and DMA unmap pages, and release the
>   * cached scatter/gather table for an shmem GEM object.
>   * @shmem: shmem GEM object
>   *
> 
> ---
> base-commit: f0c1bb8ead8a9790e7d0339354598b50a9c6789a
> change-id: 20260622-b4-gem_shmem_free_doc-6dd48f97cd48
> 
> Best regards,
> --  
> Alexandre Courbot <acourbot@nvidia.com>