mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Satya Priya Kakitapalli (Temp)" <quic_c_skakit@quicinc.com>
To: Mark Brown <broonie@kernel.org>,
	David Collins <quic_collinsd@quicinc.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>, <swboyd@chromium.org>,
	<subbaram@codeaurora.org>, Das Srinagesh <gurus@codeaurora.org>,
	<linux-arm-msm@vger.kernel.org>, Lee Jones <lee.jones@linaro.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V4 1/6] dt-bindings: regulator: Add "regulator-min-dropout-voltage-microvolt"
Date: Mon, 3 Jan 2022 20:05:40 +0530	[thread overview]
Message-ID: <012a0a96-ab0e-e844-12e1-f2272bf2506d@quicinc.com> (raw)
In-Reply-To: <YbPCjbnH6cXQqy6S@sirena.org.uk>


On 12/11/2021 2:41 AM, Mark Brown wrote:
> On Wed, Dec 08, 2021 at 04:56:48PM -0800, David Collins wrote:
>> On 12/7/21 7:19 AM, Mark Brown wrote:
>>> On Tue, Dec 07, 2021 at 08:36:11PM +0530, Satya Priya Kakitapalli (Temp) wrote:
>>> that regulator.  We absolutely can and do expect this to be board
>>> independent, it's a function of the design of the regulator.  Sharing
>>> the input supply has no impact on this, the input voltage that the
>>> regulator needs just get fed into the requiremnts on the supply voltage.
>> The PM8008 LDOs are low noise LDOs intended to supply noise sensitive
>> camera sensor hardware.  They can maintain output regulation with a
>> fixed headroom voltage.  However, in order to guarantee high PSRR, the
>> headroom voltage must be scaled according to the peak load expected from
>> the each LDO on a given board.  Thus, we included support for a DT
>> property to specify the headroom per LDO to meet noise requirements
>> across boards.
> Interesting...  how much extra headroom are we talking about here?  I'd
> be unsurprised to see this usually just quoted as part of the standard
> headroom requirement and this smells like the sort of thing that's going
> to be frequently misused.  If the gains are something worth writing home
> about


> I'd think we should consider if it's better to support this
> dynamically at runtime based on load information and provide options for
> configuring the peak load information through DT instead for static
> configurations.  That would fit in with the stuff we have for managing
> modes on DCDCs (which isn't really deployed but is there) and the API we
> have for allowing client drivers to indicate their load requirements at
> runtime that fits in with that.  That'd allow us to only boost the
> headroom when it's really needed.

This means Dynamic headroom control feature needs to be implemented. I 
need to explore more on this and gather info from team, Could we merge 
the present driver with "static headroom" for now? I'll do a follow up 
series to implement this feature.



  reply	other threads:[~2022-01-03 14:37 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19  9:42 [PATCH V4 0/6] Add Qualcomm Technologies, Inc. PM8008 regulator driver Satya Priya
2021-11-19  9:42 ` [PATCH V4 1/6] dt-bindings: regulator: Add "regulator-min-dropout-voltage-microvolt" Satya Priya
2021-11-25 15:17   ` Mark Brown
2021-12-06 13:03     ` Satya Priya Kakitapalli (Temp)
2021-12-06 18:25       ` Mark Brown
2021-12-07 15:06         ` Satya Priya Kakitapalli (Temp)
2021-12-07 15:19           ` Mark Brown
2021-12-09  0:56             ` David Collins
2021-12-10 21:11               ` Mark Brown
2022-01-03 14:35                 ` Satya Priya Kakitapalli (Temp) [this message]
2022-01-04 14:54                   ` Mark Brown
2021-11-19  9:42 ` [PATCH V4 2/6] dt-bindings: regulator: Add pm8008 regulator bindings Satya Priya
2021-11-25 15:24   ` Mark Brown
2021-12-06 13:43     ` Satya Priya Kakitapalli (Temp)
2021-12-06 13:47       ` Mark Brown
2021-12-20 12:44         ` Satya Priya Kakitapalli (Temp)
     [not found]           ` <07dc5ba4-790b-0cb2-bc3e-2ce8d7e3e09d@quicinc.com>
2022-01-10 14:21             ` Mark Brown
2022-01-11 12:15               ` Satya Priya Kakitapalli (Temp)
2022-01-11 13:59                 ` Mark Brown
2021-11-19  9:42 ` [PATCH V4 3/6] dt-bindings: mfd: pm8008: Add pm8008 regulator node Satya Priya
2021-11-19  9:42 ` [PATCH V4 4/6] regulator: Add a regulator driver for the PM8008 PMIC Satya Priya
2021-11-25 15:45   ` Mark Brown
2021-12-06 14:43     ` Satya Priya Kakitapalli (Temp)
2021-12-06 15:09       ` Mark Brown
2021-12-20 10:44         ` Satya Priya Kakitapalli (Temp)
2021-11-19  9:42 ` [PATCH V4 5/6] arm64: dts: qcom: pm8008: Add base dts file Satya Priya
2021-11-19  9:42 ` [PATCH V4 6/6] arm64: dts: qcom: sc7280: Add pm8008 regulators support for sc7280-idp Satya Priya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=012a0a96-ab0e-e844-12e1-f2272bf2506d@quicinc.com \
    --to=quic_c_skakit@quicinc.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gurus@codeaurora.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_collinsd@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=subbaram@codeaurora.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®