From: "Satya Priya Kakitapalli (Temp)" <quic_c_skakit@quicinc.com>
To: Mark Brown <broonie@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>, <swboyd@chromium.org>,
<collinsd@codeaurora.org>, <subbaram@codeaurora.org>,
Das Srinagesh <gurus@codeaurora.org>,
<linux-arm-msm@vger.kernel.org>,
"Lee Jones" <lee.jones@linaro.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V4 1/6] dt-bindings: regulator: Add "regulator-min-dropout-voltage-microvolt"
Date: Tue, 7 Dec 2021 20:36:11 +0530 [thread overview]
Message-ID: <6a44cb99-6894-c9ce-4f1e-5dee0939598c@quicinc.com> (raw)
In-Reply-To: <Ya5VhkggWdjYyTHL@sirena.org.uk>
On 12/6/2021 11:55 PM, Mark Brown wrote:
> On Mon, Dec 06, 2021 at 06:33:26PM +0530, Satya Priya Kakitapalli (Temp) wrote:
>> On 11/25/2021 8:47 PM, Mark Brown wrote:
>>> Usually this is a fixed property of the regulator rather than something
>>> that varies per board - why have a DT property?
>> The min-dropout value (headroom) varies with boards, that's why we have a DT
>> property for it. We overwrite the default value in driver with actual value
>> read from DT
> Interesting. How exactly does that end up happening - presumably other
> systems are going to run into it?
The parent supplies such as "vdd-l1-l2" are coming from other pmic
regulators, which are shared supplies with other subsystems like BT,
Display etc, they vary between boards as per requirements, so we cannot
expect these to be fixed and so are the headroom values. We get the
headroom values from PMIC systems team for every target.
> If you do have board designs which somehow managed to introduce
> additional dropouts (seems pretty concerning TBH) then I think the best
> way to handle that is to add a generic property for it and have that
> either added on to or override the requirements of the regulator itself
> which should continue to be defined in the driver. That way only boards
> with issues need to do anything which will avoid bugs with the property
> being omitted in what should be the common case.
next prev parent reply other threads:[~2021-12-07 15:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 9:42 [PATCH V4 0/6] Add Qualcomm Technologies, Inc. PM8008 regulator driver Satya Priya
2021-11-19 9:42 ` [PATCH V4 1/6] dt-bindings: regulator: Add "regulator-min-dropout-voltage-microvolt" Satya Priya
2021-11-25 15:17 ` Mark Brown
2021-12-06 13:03 ` Satya Priya Kakitapalli (Temp)
2021-12-06 18:25 ` Mark Brown
2021-12-07 15:06 ` Satya Priya Kakitapalli (Temp) [this message]
2021-12-07 15:19 ` Mark Brown
2021-12-09 0:56 ` David Collins
2021-12-10 21:11 ` Mark Brown
2022-01-03 14:35 ` Satya Priya Kakitapalli (Temp)
2022-01-04 14:54 ` Mark Brown
2021-11-19 9:42 ` [PATCH V4 2/6] dt-bindings: regulator: Add pm8008 regulator bindings Satya Priya
2021-11-25 15:24 ` Mark Brown
2021-12-06 13:43 ` Satya Priya Kakitapalli (Temp)
2021-12-06 13:47 ` Mark Brown
2021-12-20 12:44 ` Satya Priya Kakitapalli (Temp)
[not found] ` <07dc5ba4-790b-0cb2-bc3e-2ce8d7e3e09d@quicinc.com>
2022-01-10 14:21 ` Mark Brown
2022-01-11 12:15 ` Satya Priya Kakitapalli (Temp)
2022-01-11 13:59 ` Mark Brown
2021-11-19 9:42 ` [PATCH V4 3/6] dt-bindings: mfd: pm8008: Add pm8008 regulator node Satya Priya
2021-11-19 9:42 ` [PATCH V4 4/6] regulator: Add a regulator driver for the PM8008 PMIC Satya Priya
2021-11-25 15:45 ` Mark Brown
2021-12-06 14:43 ` Satya Priya Kakitapalli (Temp)
2021-12-06 15:09 ` Mark Brown
2021-12-20 10:44 ` Satya Priya Kakitapalli (Temp)
2021-11-19 9:42 ` [PATCH V4 5/6] arm64: dts: qcom: pm8008: Add base dts file Satya Priya
2021-11-19 9:42 ` [PATCH V4 6/6] arm64: dts: qcom: sc7280: Add pm8008 regulators support for sc7280-idp Satya Priya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a44cb99-6894-c9ce-4f1e-5dee0939598c@quicinc.com \
--to=quic_c_skakit@quicinc.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=gurus@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=subbaram@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®