From: Lars-Peter Clausen <lars@metafoo.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Mugilraj Dhavachelvan <dmugil2000@gmail.com>
Cc: "Bogdan, Dragos" <Dragos.Bogdan@analog.com>,
Darius <Darius.Berghe@analog.com>,
Rob Herring <robh+dt@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Guenter Roeck <linux@roeck-us.net>,
Chris Packham <chris.packham@alliedtelesis.co.nz>,
Slawomir Stepien <sst@poczta.fm>,
Krzysztof Kozlowski <krzk@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Alexandru Ardelean <alexandru.ardelean@analog.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: potentiometer: Add driver support for AD5110
Date: Wed, 11 Aug 2021 10:15:09 +0200 [thread overview]
Message-ID: <013bcb79-c496-44d8-2e93-57eb57834ee0@metafoo.de> (raw)
In-Reply-To: <CAHp75Ve=D1d5wFZgNseP=wGpteEkZHnmAi7j9ykKC+u_NrR5xw@mail.gmail.com>
On 8/10/21 2:49 PM, Andy Shevchenko wrote:
>
>> + data->tol = data->cfg->kohms * (val & GENMASK(6, 0)) * 10 / 8;
>> + if (!(val & BIT(7)))
>> + data->tol *= -1;
> Shouldn't you simple use corresponding sign_extend*()?
The data is encoded a sign-magnitude. sign_extend() works for two's
complement numbers.
next prev parent reply other threads:[~2021-08-11 8:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 7:57 [PATCH v2 0/2] " Mugilraj Dhavachelvan
2021-08-09 7:57 ` [PATCH v2 1/2] dt-bindings: iio: potentiometer: Add AD5110 in trivial-devices Mugilraj Dhavachelvan
2021-08-13 20:57 ` Rob Herring
2021-08-09 7:57 ` [PATCH v2 2/2] iio: potentiometer: Add driver support for AD5110 Mugilraj Dhavachelvan
2021-08-09 20:05 ` Jonathan Cameron
2021-08-10 12:49 ` Andy Shevchenko
2021-08-11 5:45 ` Mugilraj Dhavachelvan
2021-08-11 7:03 ` Andy Shevchenko
2021-08-11 7:05 ` Andy Shevchenko
2021-08-11 8:11 ` Mugilraj Dhavachelvan
2021-08-11 8:15 ` Lars-Peter Clausen [this message]
2021-08-11 16:06 ` Andy Shevchenko
2021-08-12 16:53 ` Mugilraj Dhavachelvan
2021-08-14 8:18 ` Mugilraj Dhavachelvan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=013bcb79-c496-44d8-2e93-57eb57834ee0@metafoo.de \
--to=lars@metafoo.de \
--cc=Darius.Berghe@analog.com \
--cc=Dragos.Bogdan@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandru.ardelean@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=dmugil2000@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=sst@poczta.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®