From: Markus Elfring <Markus.Elfring@web.de>
To: Akashi Takahiro <takahiro.akashi@linaro.org>,
Ben Chuang <ben.chuang@genesyslogic.com.tw>,
Victor Shih <victor.shih@genesyslogic.com.tw>,
linux-mmc@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ben Chuang <benchuanggli@gmail.com>,
Daniil Lunev <dlunev@chromium.org>,
Greg Tu <greg.tu@genesyslogic.com.tw>,
HL.Liu@genesyslogic.com.tw,
Lucas Lai <Lucas.Lai@genesyslogic.com.tw>
Subject: Re: [PATCH V22 08/22] mmc: sdhci: add UHS-II related definitions in headers
Date: Fri, 13 Sep 2024 22:00:10 +0200 [thread overview]
Message-ID: <014449ba-6b9d-4fb3-8dda-4cbdfa74b9be@web.de> (raw)
In-Reply-To: <20240913102836.6144-9-victorshihgli@gmail.com>
…
> +++ b/drivers/mmc/host/sdhci-uhs2.h
> @@ -0,0 +1,177 @@
…
> +#ifndef __SDHCI_UHS2_H
> +#define __SDHCI_UHS2_H
…
I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier
Regards,
Markus
next prev parent reply other threads:[~2024-09-13 20:05 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 10:28 [PATCH V22 00/22] Add support UHS-II for GL9755 and GL9767 Victor Shih
2024-09-13 10:28 ` [PATCH V22 01/22] mmc: core: Cleanup printing of speed mode at card insertion Victor Shih
2024-09-13 10:28 ` [PATCH V22 02/22] mmc: core: Prepare to support SD UHS-II cards Victor Shih
2024-10-08 19:56 ` Kees Bakker
2024-10-09 10:37 ` Ulf Hansson
2024-09-13 10:28 ` [PATCH V22 03/22] mmc: core: Announce successful insertion of an SD UHS-II card Victor Shih
2024-09-13 10:28 ` [PATCH V22 04/22] mmc: core: Extend support for mmc regulators with a vqmmc2 Victor Shih
2024-09-13 10:28 ` [PATCH V22 05/22] mmc: core: Add definitions for SD UHS-II cards Victor Shih
2024-09-13 10:28 ` [PATCH V22 06/22] mmc: core: Add New function to re-factoring the code Victor Shih
2024-09-13 10:28 ` [PATCH V22 07/22] mmc: core: Support UHS-II card control and access Victor Shih
2024-10-07 15:36 ` Ulf Hansson
2024-10-10 6:20 ` Victor Shih
2024-10-10 11:21 ` Ulf Hansson
2024-10-18 10:39 ` Victor Shih
2024-10-18 10:47 ` Victor Shih
2024-09-13 10:28 ` [PATCH V22 08/22] mmc: sdhci: add UHS-II related definitions in headers Victor Shih
2024-09-13 20:00 ` Markus Elfring [this message]
2024-09-13 10:28 ` [PATCH V22 09/22] mmc: sdhci: add UHS-II module and add a kernel configuration Victor Shih
2024-09-13 16:42 ` Markus Elfring
2024-09-13 10:28 ` [PATCH V22 10/22] mmc: sdhci-uhs2: dump UHS-II registers Victor Shih
2024-09-13 10:28 ` [PATCH V22 11/22] mmc: sdhci-uhs2: add reset function Victor Shih
2024-09-13 10:28 ` [PATCH V22 12/22] mmc: sdhci-uhs2: add set_power() to support vdd2 Victor Shih
2024-09-13 10:28 ` [PATCH V22 13/22] mmc: sdhci-uhs2: add set_timeout() Victor Shih
2024-09-13 10:28 ` [PATCH V22 14/22] mmc: sdhci-uhs2: add add_host() and others to set up the driver Victor Shih
2024-09-13 10:28 ` [PATCH V22 15/22] mmc: sdhci-uhs2: add set_ios() Victor Shih
2024-09-13 10:28 ` [PATCH V22 16/22] mmc: sdhci-uhs2: add related functions to initialize the interface Victor Shih
2024-09-13 10:28 ` [PATCH V22 17/22] mmc: sdhci-uhs2: add irq() and others Victor Shih
2024-09-13 15:17 ` Markus Elfring
2024-09-13 10:28 ` [PATCH V22 18/22] mmc: sdhci-uhs2: add request() " Victor Shih
2024-09-13 10:28 ` [PATCH V22 19/22] mmc: sdhci-uhs2: add pre-detect_init hook Victor Shih
2024-09-13 10:28 ` [PATCH V22 20/22] mmc: sdhci-pci: add UHS-II support framework Victor Shih
2024-09-13 10:28 ` [PATCH V22 21/22] mmc: sdhci-pci-gli: enable UHS-II mode for GL9755 Victor Shih
2024-09-13 10:28 ` [PATCH V22 22/22] mmc: sdhci-pci-gli: enable UHS-II mode for GL9767 Victor Shih
2024-09-18 4:47 ` [PATCH V22 00/22] Add support UHS-II for GL9755 and GL9767 Adrian Hunter
2024-09-30 10:46 ` Victor Shih
2024-10-04 11:54 ` Ulf Hansson
2024-10-07 15:33 ` Ulf Hansson
2024-10-10 6:20 ` Victor Shih
2024-10-10 9:57 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=014449ba-6b9d-4fb3-8dda-4cbdfa74b9be@web.de \
--to=markus.elfring@web.de \
--cc=HL.Liu@genesyslogic.com.tw \
--cc=Lucas.Lai@genesyslogic.com.tw \
--cc=adrian.hunter@intel.com \
--cc=ben.chuang@genesyslogic.com.tw \
--cc=benchuanggli@gmail.com \
--cc=dlunev@chromium.org \
--cc=greg.tu@genesyslogic.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=takahiro.akashi@linaro.org \
--cc=ulf.hansson@linaro.org \
--cc=victor.shih@genesyslogic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®