From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Krishna Kurapati <quic_kriskura@quicinc.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Conor Dooley <conor+dt@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, quic_ppratap@quicinc.com,
quic_jackp@quicinc.com
Subject: Re: [PATCH] RFC: arm64: dts: qcom: Disable USB U1/U2 entry for QC targets
Date: Sat, 30 Nov 2024 15:39:53 +0100 [thread overview]
Message-ID: <01673652-e1fe-4478-bbeb-f532e3358e8f@oss.qualcomm.com> (raw)
In-Reply-To: <1d6bb573-6366-49d1-a921-cb04136627a8@quicinc.com>
On 10.11.2024 8:15 PM, Krishna Kurapati wrote:
>
>
> On 11/9/2024 2:22 AM, Konrad Dybcio wrote:
>> On 7.11.2024 8:36 AM, Krishna Kurapati wrote:
>>> Enabling U1 and U2 power-saving states can lead to stability and
>>> performance issues, particularly for latency-sensitive or high-
>>> throughput applications. These low-power link states are intended
>>> to reduce power consumption by allowing the device to enter partial
>>> low-power modes during idle periods. However, they can sometimes
>>> result in unexpected behavior. Over the years, some of the issues
>>> seen are as follows:
>>>
>>> 1. In device mode of operation, when UVC is active, enabling U1/U2
>>> is sometimes causing packets drops due to delay in entry/exit of
>>> intermittent low power states. These packet drops are often reflected
>>> as Missed Isochronous transfers as the controller was not able to
>>> send the packet in that microframe interval and hence glitches are
>>> seen on the final transmitted video output.
>>>
>>> 2. On QCS6490-Rb3Gen2 Vision kit, ADB connection is heavily unstable
>>> when U1/U2 is enabled. Often when link enters U2, there is a re-
>>> enumeration seen and device is unusable for many use cases.
>>
>> Would be nice to enable it on there too, then ;)
>>
>> Generally per-file commits are preferred to make potential reverts
>> easier down the road
>>
>
> Hi Konrad,
>
> I agree with you. After the SoB and the "---", I added a paragraph mentioning that if this RFC patch looks fine, I will send a series and make this change for all SM and QCS targets.
>
> Let me know if the above commit text makes sense. Although I don't have all the debug details, I didn't want others in the community face the issues we faced and hence the patch.
lgtm
Konrad
prev parent reply other threads:[~2024-11-30 14:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 7:36 Krishna Kurapati
2024-11-07 11:03 ` Dmitry Baryshkov
2024-11-08 3:30 ` Krishna Kurapati
2024-11-08 20:52 ` Konrad Dybcio
2024-11-10 19:15 ` Krishna Kurapati
2024-11-30 14:39 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01673652-e1fe-4478-bbeb-f532e3358e8f@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_jackp@quicinc.com \
--cc=quic_kriskura@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®