mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krishna Kurapati <quic_kriskura@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <quic_ppratap@quicinc.com>,
	<quic_jackp@quicinc.com>
Subject: Re: [PATCH] RFC: arm64: dts: qcom: Disable USB U1/U2 entry for QC targets
Date: Fri, 8 Nov 2024 09:00:52 +0530	[thread overview]
Message-ID: <f26bd7ac-5a01-4c9b-b2a0-aa9e65dff6e5@quicinc.com> (raw)
In-Reply-To: <trrbjd574futtatooisumtqp4idqerb5ji2g3nvdesiedlitdd@c6u7wuqhh4r3>



On 11/7/2024 4:33 PM, Dmitry Baryshkov wrote:
> On Thu, Nov 07, 2024 at 01:06:50PM +0530, Krishna Kurapati wrote:
>> Enabling U1 and U2 power-saving states can lead to stability and
>> performance issues, particularly for latency-sensitive or high-
>> throughput applications. These low-power link states are intended
>> to reduce power consumption by allowing the device to enter partial
>> low-power modes during idle periods. However, they can sometimes
>> result in unexpected behavior. Over the years, some of the issues
>> seen are as follows:
>>
>> 1. In device mode of operation, when UVC is active, enabling U1/U2
>> is sometimes causing packets drops due to delay in entry/exit of
>> intermittent low power states. These packet drops are often reflected
>> as Missed Isochronous transfers as the controller was not able to
>> send the packet in that microframe interval and hence glitches are
>> seen on the final transmitted video output.
>>
>> 2. On QCS6490-Rb3Gen2 Vision kit, ADB connection is heavily unstable
>> when U1/U2 is enabled. Often when link enters U2, there is a re-
>> enumeration seen and device is unusable for many use cases.
>>
>> 3. On QCS8300/QCS9100, it is observed that when Link enters U2, when
>> the cable is disconnected and reconnected to host PC in HS, there
>> is no link status change interrupt seen and the plug-in in HS doesn't
>> show up a bus reset and enumeration failure happens.
>>
>> 4. On older targets like SM8150/SM8250/SM8350, there have been
>> throughput issues seen during tethering use cases.
>>
>> To avoid such issues, the USB team at Qualcomm added these quirks
>> to all targets in the past 4-5 years and extensive testing was done.
>> Although these are intermittent power states, disabling them didn't
>> cause any major increase in power numbers.
>>
>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
>> ---
>> If this is fine, the patch would be made into a series, disabling
>> U1/U2 for all mobile and QCS targets.
>>
>>   arch/arm64/boot/dts/qcom/sm8150.dtsi | 4 ++++
>>   arch/arm64/boot/dts/qcom/sm8250.dtsi | 4 ++++
>>   arch/arm64/boot/dts/qcom/sm8350.dtsi | 4 ++++
>>   arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 ++
> 
> Should the same set of quirks be applied to SAR2130P too?

Yes, these two quirks have been added to and tested on SAR2130 
downstream. I see that you have added them in your upstream DTSI file 
too. Thanks for that.

Regards,
Krishna,

  reply	other threads:[~2024-11-08  3:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-07  7:36 Krishna Kurapati
2024-11-07 11:03 ` Dmitry Baryshkov
2024-11-08  3:30   ` Krishna Kurapati [this message]
2024-11-08 20:52 ` Konrad Dybcio
2024-11-10 19:15   ` Krishna Kurapati
2024-11-30 14:39     ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f26bd7ac-5a01-4c9b-b2a0-aa9e65dff6e5@quicinc.com \
    --to=quic_kriskura@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_jackp@quicinc.com \
    --cc=quic_ppratap@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®