RE: [PATCHv2 09/11] unicore32 core architecture: timer and time handling

["Guan Xuetao" <gxt@mprc.pku.edu.cn>]

> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@arndb.de]
> Sent: Tuesday, February 22, 2011 11:21 PM
> To: Guan Xuetao
> Cc: linux-kernel@vger.kernel.org; linux-arch@vger.kernel.org; 'Greg KH'
> Subject: Re: [PATCHv2 09/11] unicore32 core architecture: timer and time handling
> 
> On Tuesday 22 February 2011, Guan Xuetao wrote:
> > > > +#if defined(CONFIG_PUV3_DB0913)                \
> > > > +       || defined(CONFIG_PUV3_NB0916)  \
> > > > +       || defined(CONFIG_PUV3_SMW0919)
> > > > +
> > > > +#define  CLOCK_TICK_RATE         (14318000)
> > > > +
> > > > +#endif
> > >
> > > I believe that we don't use CLOCK_TICK_RATE in the kernel any more,
> > > so there is no reason to define it.
> > CLOCK_TICK_RATE is an important value for the kernel.
> > And perhaps I misunderstanding your meaning...
> 
> We just discussed the same thing for a new ARM platform. You are
> right that CLOCK_TICK_RATE is currently still being used, but
> we are trying to get rid of it.
> 
> Most importantly, it should not be configuration specific any more.
> If you use CLOCK_TICK_RATE in unicore32 specific code, it would
> be best to rename that variable and device it in a board specific
> file.
> 
> The definition in timex.h can basically contain any value that is
> a multiple of CONFIG_HZ. Don't worry about this one, we will fix
> it for good for the entire kernel.
> 
> 	Arnd
Ok, I see.

Thanks & Regards.
Guan Xuetao