mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tapio Reijonen <tapio.reijonen@vaisala.com>
To: sashiko-reviews@lists.linux.dev
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	linux-kernel@vger.kernel.org,
	Hugo Villeneuve <hvilleneuve@dimonoff.com>,
	Maarten Brock <Maarten.Brock@sttls.nl>,
	Tapio Reijonen <tapio.reijonen@kolumbus.fi>,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH v8 8/9] serial: max310x: drive RTS in software when hardware delays are too short
Date: Wed, 14 Oct 2026 10:12:22 +0300	[thread overview]
Message-ID: <018d3782-ba8f-498d-a514-382e5cda103f@vaisala.com> (raw)
In-Reply-To: <sashiko-outbox-163982@kernel.org>

On 10/8/26 13:03, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 6 potential issue(s) to consider:

All six were reviewed; none is introduced by this series, and the
concurrency ones describe windows this patch already bounds by design:

- the "Critical" remove() use-after-free is the pre-existing
  cancel-before-unregister ordering (see the reply on patch 7);
- the RTS worker reads the envelope state lock-free by design and
  re-derives the pin level on every run: a stale run is flushed on an
  RS485 disable, re-queued after the termios settle, and the hold
  expiry re-asserts under break ownership - RS485-disable landing in
  every envelope phase was exercised on hardware, 20/20 with no
  spurious re-assert;
- the delayed-stop check runs from the TX-empty path, where an empty
  FIFO is ground truth, and the armed hold includes one extra
  character for the shift register; the regression matrix and a two
  hour stress soak show no early release;
- the hrtimer-running window resolves inside the timer callback
  itself, which re-checks the cancel flag and state under port->lock.

Tapio

  parent reply	other threads:[~2026-10-14  7:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-08  9:48 [PATCH v8 0/9] serial: max310x: RS485 delay and RTS fixes, software-timed delays Tapio Reijonen
2026-10-08  9:48 ` [PATCH v8 1/9] serial: max310x: don't clobber the TX break bit in set_termios Tapio Reijonen
2026-10-08  9:48 ` [PATCH v8 2/9] serial: max310x: fix breaks not reaching the wire in RS485 mode Tapio Reijonen
2026-10-08  9:48 ` [PATCH v8 3/9] serial: max310x: centralize the RS485 transceiver programming Tapio Reijonen
2026-10-08  9:48 ` [PATCH v8 4/9] serial: max310x: fix RS485 delays being programmed as bit-times Tapio Reijonen
2026-10-08  9:48 ` [PATCH v8 5/9] serial: max310x: don't power down the port mid-transmission on close Tapio Reijonen
2026-10-08  9:48 ` [PATCH v8 6/9] serial: max310x: support active-low RTS on the hardware path Tapio Reijonen
2026-10-08  9:48 ` [PATCH v8 7/9] serial: max310x: schedule tx_work directly from the IRQ handler Tapio Reijonen
     [not found]   ` <sashiko-outbox-163987@kernel.org>
2026-10-14  7:08     ` Tapio Reijonen
2026-10-08  9:48 ` [PATCH v8 8/9] serial: max310x: drive RTS in software when hardware delays are too short Tapio Reijonen
     [not found]   ` <sashiko-outbox-163982@kernel.org>
2026-10-14  7:12     ` Tapio Reijonen [this message]
2026-10-08  9:48 ` [PATCH v8 9/9] serial: max310x: don't transmit while an RS485 reconfigure is pending Tapio Reijonen
     [not found]   ` <sashiko-outbox-163985@kernel.org>
2026-10-14  7:17     ` Tapio Reijonen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=018d3782-ba8f-498d-a514-382e5cda103f@vaisala.com \
    --to=tapio.reijonen@vaisala.com \
    --cc=Maarten.Brock@sttls.nl \
    --cc=gregkh@linuxfoundation.org \
    --cc=hvilleneuve@dimonoff.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tapio.reijonen@kolumbus.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®