From: Tapio Reijonen <tapio.reijonen@vaisala.com>
To: sashiko-reviews@lists.linux.dev
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
Maarten Brock <Maarten.Brock@sttls.nl>,
Tapio Reijonen <tapio.reijonen@kolumbus.fi>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v8 9/9] serial: max310x: don't transmit while an RS485 reconfigure is pending
Date: Wed, 14 Oct 2026 10:17:52 +0300 [thread overview]
Message-ID: <6bed8bd2-0104-4803-869f-3d3aa8aee697@vaisala.com> (raw)
In-Reply-To: <sashiko-outbox-163985@kernel.org>
On 10/8/26 13:03, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- tx_work continuing through a pending reconfigure is an in-flight
transfer, which the reconfigure helper adopts with RTS held - the
gate's documented scope is transmissions that have not started;
- max310x_handle_tx() has exactly one consumer, tx_work, so the kfifo
single-consumer contract holds;
- rs_work not being cancelled in shutdown() predates this series
(2016); it belongs to the same teardown-ordering follow-up as the
patch-7 note.
Tapio
prev parent reply other threads:[~2026-10-14 7:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 9:48 [PATCH v8 0/9] serial: max310x: RS485 delay and RTS fixes, software-timed delays Tapio Reijonen
2026-10-08 9:48 ` [PATCH v8 1/9] serial: max310x: don't clobber the TX break bit in set_termios Tapio Reijonen
2026-10-08 9:48 ` [PATCH v8 2/9] serial: max310x: fix breaks not reaching the wire in RS485 mode Tapio Reijonen
2026-10-08 9:48 ` [PATCH v8 3/9] serial: max310x: centralize the RS485 transceiver programming Tapio Reijonen
2026-10-08 9:48 ` [PATCH v8 4/9] serial: max310x: fix RS485 delays being programmed as bit-times Tapio Reijonen
2026-10-08 9:48 ` [PATCH v8 5/9] serial: max310x: don't power down the port mid-transmission on close Tapio Reijonen
2026-10-08 9:48 ` [PATCH v8 6/9] serial: max310x: support active-low RTS on the hardware path Tapio Reijonen
2026-10-08 9:48 ` [PATCH v8 7/9] serial: max310x: schedule tx_work directly from the IRQ handler Tapio Reijonen
[not found] ` <sashiko-outbox-163987@kernel.org>
2026-10-14 7:08 ` Tapio Reijonen
2026-10-08 9:48 ` [PATCH v8 8/9] serial: max310x: drive RTS in software when hardware delays are too short Tapio Reijonen
[not found] ` <sashiko-outbox-163982@kernel.org>
2026-10-14 7:12 ` Tapio Reijonen
2026-10-08 9:48 ` [PATCH v8 9/9] serial: max310x: don't transmit while an RS485 reconfigure is pending Tapio Reijonen
[not found] ` <sashiko-outbox-163985@kernel.org>
2026-10-14 7:17 ` Tapio Reijonen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bed8bd2-0104-4803-869f-3d3aa8aee697@vaisala.com \
--to=tapio.reijonen@vaisala.com \
--cc=Maarten.Brock@sttls.nl \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tapio.reijonen@kolumbus.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®