From: Michal Simek <michal.simek@xilinx.com>
To: linux-kernel@vger.kernel.org, monstr@monstr.eu
Cc: "Naga Sureshkumar Relli" <naga.sureshkumar.relli@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Borislav Petkov" <bp@alien8.de>,
linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org
Subject: [PATCH v2 6/6] edac: synopsys: Enable CE and UE interrupts for ZynqMP DDRC
Date: Mon, 7 Aug 2017 09:39:28 +0200 [thread overview]
Message-ID: <01ba1fac5b05242546c4d97dbe9a2800c1019cd8.1502091561.git.michal.simek@xilinx.com> (raw)
In-Reply-To: <91fd6532076e4c905b5a228d852bba4941c54a28.1502091561.git.michal.simek@xilinx.com>
In-Reply-To: <91fd6532076e4c905b5a228d852bba4941c54a28.1502091561.git.michal.simek@xilinx.com>
From: Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
This patch enables Corrected and Uncorrected Error
interrupts for ZynqMP DDRC controller
Signed-off-by: Naga Sureshkumar Relli <nagasure@xilinx.com>
Reviewed-by: Punnaiah Choudary Kalluri <punnaia@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
Changes in v2:
- Fix function alignment
- Fix macro indentation
drivers/edac/synopsys_edac.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c
index 24490334a4f2..f185a28d2db3 100644
--- a/drivers/edac/synopsys_edac.c
+++ b/drivers/edac/synopsys_edac.c
@@ -165,6 +165,8 @@
#define DDR_QOSUE_MASK 0x4
#define DDR_QOSCE_MASK 0x2
#define ECC_CE_UE_INTR_MASK 0x6
+#define DDR_QOS_IRQ_EN_OFST 0x20208
+#define DDR_QOS_IRQ_DB_OFST 0x2020C
/* ECC Corrected Error Register Mask and Shifts*/
#define ECC_CEADDR0_RW_MASK 0x3FFFF
@@ -1112,6 +1114,10 @@ static int synps_edac_mc_probe(struct platform_device *pdev)
edac_printk(KERN_ERR, EDAC_MC, "Failed to request Irq\n");
goto free_edac_mc;
}
+
+ /* Enable UE/CE Interrupts */
+ writel((DDR_QOSUE_MASK | DDR_QOSCE_MASK),
+ priv->baseaddr + DDR_QOS_IRQ_EN_OFST);
}
rc = edac_mc_add_mc(mci);
@@ -1154,6 +1160,10 @@ static int synps_edac_mc_remove(struct platform_device *pdev)
struct synps_edac_priv *priv;
priv = mci->pvt_info;
+ if (priv->p_data->quirks & DDR_ECC_INTR_SUPPORT)
+ /* Disable UE/CE Interrupts */
+ writel((DDR_QOSUE_MASK | DDR_QOSCE_MASK),
+ priv->baseaddr + DDR_QOS_IRQ_DB_OFST);
edac_mc_del_mc(&pdev->dev);
if (priv->p_data->quirks & DDR_ECC_DATA_POISON_SUPPORT)
synps_edac_remove_sysfs_attributes(mci);
--
1.9.1
next prev parent reply other threads:[~2017-08-07 7:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 7:39 [PATCH v2 1/6] devicetree: Extend synopsys ddrc binding for Xilinx ZynqMP Michal Simek
2017-08-07 7:39 ` [PATCH v2 2/6] edac: synopsys: Add platform specific structures for ddrc controller Michal Simek
2017-08-11 9:09 ` Borislav Petkov
2017-08-11 9:16 ` Michal Simek
2017-08-11 9:22 ` Borislav Petkov
2017-08-11 9:43 ` Michal Simek
2017-08-13 11:35 ` Borislav Petkov
2017-08-07 7:39 ` [PATCH v2 3/6] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC Michal Simek
2017-08-13 12:12 ` Borislav Petkov
2017-08-07 7:39 ` [PATCH v2 4/6] edac: synopsys: Add ECC error injection support Michal Simek
2017-08-13 13:02 ` Borislav Petkov
2017-08-07 7:39 ` [PATCH v2 5/6] edac: synopsys: Update ECC error message info Michal Simek
2017-08-13 13:08 ` Borislav Petkov
2017-08-07 7:39 ` Michal Simek [this message]
2017-08-10 20:44 ` [PATCH v2 1/6] devicetree: Extend synopsys ddrc binding for Xilinx ZynqMP Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01ba1fac5b05242546c4d97dbe9a2800c1019cd8.1502091561.git.michal.simek@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=bp@alien8.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=monstr@monstr.eu \
--cc=naga.sureshkumar.relli@xilinx.com \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®