From: Yongxing Mou <quic_yongmou@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Rob Clark <robin.clark@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jessica.zhang@oss.qualcomm.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
<linux-arm-msm@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<freedreno@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
"Abhinav Kumar" <quic_abhinavk@quicinc.com>
Subject: Re: [PATCH v2 33/38] drm/msm: initialize DRM MST encoders for DP controllers
Date: Thu, 14 Aug 2025 17:11:13 +0800 [thread overview]
Message-ID: <01ccebf2-1a2c-4996-8b56-1fb951a6d8c6@quicinc.com> (raw)
In-Reply-To: <hxqeilu5fcgsykghxwbhp4r3exu3o45n5lftzeupjxam7r7ux7@wdrfc6lor4gl>
On 2025/6/9 22:17, Dmitry Baryshkov wrote:
> On Mon, Jun 09, 2025 at 08:21:52PM +0800, Yongxing Mou wrote:
>> From: Abhinav Kumar <quic_abhinavk@quicinc.com>
>>
>> Initiliaze a DPMST encoder for each MST capable DP controller
>> and the number of encoders it supports depends on the number
>> of streams it supports.
>>
>> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
>> Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
>> ---
>> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 2 ++
>> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 23 ++++++++++++++++++++++-
>> drivers/gpu/drm/msm/dp/dp_display.c | 14 ++++++++++++++
>
> Please don't mix DP and DPU changes in a single patch.
>
Got it, thanks, will separate it.
>> drivers/gpu/drm/msm/msm_drv.h | 13 +++++++++++++
>> 4 files changed, 51 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h
>> index ca1ca2e51d7ead0eb34b27f3168e6bb06a71a11a..2eb4c39b111c1d8622e09e78ffafef017e28bbf6 100644
>> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h
>> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h
>> @@ -28,6 +28,7 @@
>> * @h_tile_instance: Controller instance used per tile. Number of elements is
>> * based on num_of_h_tiles
>> * @is_cmd_mode Boolean to indicate if the CMD mode is requested
>> + * @stream_id stream id for which the interface needs to be acquired
>> * @vsync_source: Source of the TE signal for DSI CMD devices
>> */
>> struct msm_display_info {
>> @@ -35,6 +36,7 @@ struct msm_display_info {
>> uint32_t num_of_h_tiles;
>> uint32_t h_tile_instance[MAX_H_TILES_PER_DISPLAY];
>> bool is_cmd_mode;
>> + int stream_id;
>> enum dpu_vsync_source vsync_source;
>> };
>>
>> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
>> index 1fd82b6747e9058ce11dc2620729921492d5ebdd..45fedf7e74e9c6dfed4bde57eb675e3dd1762fc7 100644
>> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
>> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
>> @@ -652,7 +652,8 @@ static int _dpu_kms_initialize_displayport(struct drm_device *dev,
>> struct msm_display_info info;
>> bool yuv_supported;
>> int rc;
>> - int i;
>> + int i, stream_id;
>> + int stream_cnt;
>>
>> for (i = 0; i < ARRAY_SIZE(priv->dp); i++) {
>> if (!priv->dp[i])
>> @@ -675,6 +676,26 @@ static int _dpu_kms_initialize_displayport(struct drm_device *dev,
>> DPU_ERROR("modeset_init failed for DP, rc = %d\n", rc);
>> return rc;
>> }
>> +
>> + stream_cnt = msm_dp_get_mst_max_stream(priv->dp[i]);
>> +
>> + if (stream_cnt > 1) {
>> + for (stream_id = 0; stream_id < stream_cnt; stream_id++) {
>> + info.stream_id = stream_id;
>> + encoder = dpu_encoder_init(dev, DRM_MODE_ENCODER_DPMST, &info);
>> + if (IS_ERR(encoder)) {
>> + DPU_ERROR("encoder init failed for dp mst display\n");
>> + return PTR_ERR(encoder);
>> + }
>> +
>> + rc = msm_dp_mst_bridge_init(priv->dp[i], encoder);
>> + if (rc) {
>> + DPU_ERROR("dp mst bridge %d init failed, %d\n",
>> + stream_id, rc);
>> + continue;
>> + }
>> + }
>> + }
>> }
>>
>> return 0;
>> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
>> index 9dbcf4553cad70c9e3722160a87403fc815765d7..ab1ad0cb6427eb4f86ee8ac6c76788b1a78892a8 100644
>> --- a/drivers/gpu/drm/msm/dp/dp_display.c
>> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
>> @@ -1417,6 +1417,20 @@ static int msm_dp_display_get_connector_type(struct platform_device *pdev,
>> return connector_type;
>> }
>>
>> +int msm_dp_get_mst_max_stream(struct msm_dp *dp_display)
>> +{
>> + struct msm_dp_display_private *dp_priv;
>> +
>> + dp_priv = container_of(dp_display, struct msm_dp_display_private, msm_dp_display);
>> +
>> + return dp_priv->max_stream;
>> +}
>> +
>> +int msm_dp_mst_bridge_init(struct msm_dp *dp_display, struct drm_encoder *encoder)
>> +{
>> + return msm_dp_mst_drm_bridge_init(dp_display, encoder);
>
> What's the point in this oneliner?
>
Emm, here we consider declaring the msm_dp_mst_drm_bridge_init() in
msm_drv.h and drop the one-line wrapper.
>> +}
>> +
>> static int msm_dp_display_probe(struct platform_device *pdev)
>> {
>> int rc = 0;
>> diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h
>> index a65077855201746c37ee742364b61116565f3794..dd403107b640ee5ef333d2773b52e38e3869155f 100644
>> --- a/drivers/gpu/drm/msm/msm_drv.h
>> +++ b/drivers/gpu/drm/msm/msm_drv.h
>> @@ -372,6 +372,9 @@ bool msm_dp_needs_periph_flush(const struct msm_dp *dp_display,
>> const struct drm_display_mode *mode);
>> bool msm_dp_wide_bus_available(const struct msm_dp *dp_display);
>>
>> +int msm_dp_get_mst_max_stream(struct msm_dp *dp_display);
>> +int msm_dp_mst_bridge_init(struct msm_dp *dp_display, struct drm_encoder *encoder);
>> +
>> #else
>> static inline int __init msm_dp_register(void)
>> {
>> @@ -388,6 +391,16 @@ static inline int msm_dp_modeset_init(struct msm_dp *dp_display,
>> return -EINVAL;
>> }
>>
>> +static inline int msm_dp_get_mst_max_stream(struct msm_dp *dp_display)
>> +{
>> + return -EINVAL;
>> +}
>> +
>> +static inline int msm_dp_mst_bridge_init(struct msm_dp *dp_display, struct drm_encoder *encoder)
>> +{
>> + return -EINVAL;
>> +}
>> +
>> static inline void msm_dp_snapshot(struct msm_disp_state *disp_state, struct msm_dp *dp_display)
>> {
>> }
>>
>> --
>> 2.34.1
>>
>
next prev parent reply other threads:[~2025-08-14 9:11 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 12:21 [PATCH v2 00/38] drm/msm/dp: Add MST support for MSM chipsets Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 01/38] drm/msm/dp: split msm_dp_panel_read_sink_caps() into two parts and drop panel drm_edid Yongxing Mou
2025-06-09 12:41 ` Dmitry Baryshkov
2025-06-25 8:43 ` Yongxing Mou
2025-06-25 13:32 ` Dmitry Baryshkov
2025-06-27 7:49 ` Yongxing Mou
2025-06-27 12:40 ` Dmitry Baryshkov
2025-08-06 9:03 ` Yongxing Mou
2025-08-06 10:39 ` Dmitry Baryshkov
2025-06-09 12:21 ` [PATCH v2 02/38] drm/msm/dp: remove dp_display's dp_mode and use dp_panel's instead Yongxing Mou
2025-06-09 12:48 ` Dmitry Baryshkov
2025-06-25 12:34 ` Yongxing Mou
2025-06-25 14:03 ` Dmitry Baryshkov
2025-06-27 8:40 ` Yongxing Mou
2025-06-27 12:44 ` Dmitry Baryshkov
2025-08-06 9:22 ` Yongxing Mou
2025-08-06 10:41 ` Dmitry Baryshkov
2025-06-27 13:37 ` Dmitry Baryshkov
2025-06-09 12:21 ` [PATCH v2 03/38] drm/msm/dp: break up dp_display_enable into two parts Yongxing Mou
2025-06-09 12:59 ` Dmitry Baryshkov
2025-08-06 9:24 ` Yongxing Mou
2025-08-13 9:36 ` Yongxing Mou
2025-08-13 12:59 ` Dmitry Baryshkov
2025-08-14 8:14 ` Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 04/38] drm/msm/dp: re-arrange dp_display_disable() into functional parts Yongxing Mou
2025-06-09 13:05 ` Dmitry Baryshkov
2025-08-06 9:30 ` Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 05/38] drm/msm/dp: allow dp_ctrl stream APIs to use any panel passed to it Yongxing Mou
2025-06-09 13:12 ` Dmitry Baryshkov
2025-08-13 9:52 ` Yongxing Mou
2025-08-13 13:20 ` Dmitry Baryshkov
2025-06-09 12:21 ` [PATCH v2 06/38] drm/msm/dp: move the pixel clock control to its own API Yongxing Mou
2025-06-09 13:16 ` Dmitry Baryshkov
2025-08-13 11:56 ` Yongxing Mou
2025-08-13 13:05 ` Dmitry Baryshkov
2025-08-13 13:21 ` Dmitry Baryshkov
2025-06-09 12:21 ` [PATCH v2 07/38] drm/msm/dp: split dp_ctrl_off() into stream and link parts Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 08/38] drm/msm/dp: make bridge helpers use dp_display to allow re-use Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 09/38] drm/msm/dp: separate dp_display_prepare() into its own API Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 10/38] drm/msm/dp: introduce the max_streams for dp controller Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 11/38] drm/msm/dp: introduce stream_id for each DP panel Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 12/38] drm/msm/dp: add support for programming p1/p2/p3 register block Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 13/38] drm/msm/dp: use stream_id to change offsets in dp_catalog Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 14/38] drm/msm/dp: Add catalog support for 3rd/4th stream MST Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 15/38] drm/msm/dp: add support to send ACT packets for MST Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 16/38] drm/msm/dp: add support to program mst support in mainlink Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 17/38] drm/msm/dp: no need to update tu calculation for mst Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 18/38] drm/msm/dp: add support for mst channel slot allocation Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 19/38] drm/msm/dp: add support to send vcpf packets in dp controller Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 20/38] drm/msm/dp: always program MST_FIFO_CONSTANT_FILL for MST Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 21/38] drm/msm/dp: abstract out the dp_display stream helpers to accept a panel Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 22/38] drm/msm/dp: move link related operations to dp_display_unprepare() Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 23/38] drm/msm/dp: replace power_on with active_stream_cnt for dp_display Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 24/38] drm/msm/dp: make the SST bridge disconnected when mst is active Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 25/38] drm/msm/dp: add an API to initialize MST on sink side Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 26/38] drm/msm/dp: skip reading the EDID for MST cases Yongxing Mou
2025-06-09 15:58 ` Dmitry Baryshkov
2025-08-14 8:22 ` Yongxing Mou
2025-08-14 9:27 ` Dmitry Baryshkov
2025-06-09 12:21 ` [PATCH v2 27/38] drm/msm/dp: add dp_display_get_panel() to initialize DP panel Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 28/38] drm/msm/dp: add dp_mst_drm to manage DP MST bridge operations Yongxing Mou
2025-06-09 15:57 ` Dmitry Baryshkov
2025-06-11 11:39 ` Yongxing Mou
2025-06-11 14:27 ` Dmitry Baryshkov
2025-06-09 12:21 ` [PATCH v2 29/38] drm/msm/dp: add connector abstraction for DP MST Yongxing Mou
2025-06-09 15:44 ` Dmitry Baryshkov
2025-06-11 12:06 ` Yongxing Mou
2025-06-11 14:31 ` Dmitry Baryshkov
2025-06-16 14:09 ` Yongxing Mou
2025-06-16 14:47 ` Dmitry Baryshkov
[not found] ` <bd0fba5c-9e38-4a40-adf9-cc70fa2d0f57@oss.qualcomm.com>
[not found] ` <ad1db558-c33e-4788-9f25-cac6c21713f1@quicinc.com>
2025-06-19 11:33 ` Dmitry Baryshkov
2025-06-24 9:56 ` Yongxing Mou
2025-06-24 22:25 ` Dmitry Baryshkov
2025-06-09 15:51 ` Dmitry Baryshkov
2025-06-16 12:43 ` Yongxing Mou
2025-06-16 13:48 ` Dmitry Baryshkov
2025-06-17 7:52 ` Yongxing Mou
2025-06-17 10:04 ` Dmitry Baryshkov
2025-06-09 12:21 ` [PATCH v2 30/38] drm/msm/dp: add HPD callback for dp MST Yongxing Mou
2025-06-09 15:01 ` Dmitry Baryshkov
2025-06-09 12:21 ` [PATCH v2 31/38] drm/msm/dp: propagate MST state changes to dp mst module Yongxing Mou
2025-06-09 14:56 ` Dmitry Baryshkov
2025-08-14 8:24 ` Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 32/38] drm/msm: add support for non-blocking commits Yongxing Mou
2025-06-09 14:50 ` Dmitry Baryshkov
2025-08-14 8:54 ` Yongxing Mou
2025-08-14 9:28 ` Dmitry Baryshkov
2025-06-09 12:21 ` [PATCH v2 33/38] drm/msm: initialize DRM MST encoders for DP controllers Yongxing Mou
2025-06-09 14:17 ` Dmitry Baryshkov
2025-08-14 9:11 ` Yongxing Mou [this message]
2025-08-14 9:29 ` Dmitry Baryshkov
2025-06-09 12:21 ` [PATCH v2 34/38] drm/msm/dp: initialize dp_mst module for each DP MST controller Yongxing Mou
2025-06-09 14:27 ` Dmitry Baryshkov
2025-06-09 12:21 ` [PATCH v2 35/38] drm/msm/dpu: use msm_dp_get_mst_intf_id() to get the intf id Yongxing Mou
2025-06-09 14:44 ` Dmitry Baryshkov
2025-06-09 12:21 ` [PATCH v2 36/38] drm/msm/dp: mark ST_DISCONNECTED only if all streams are disabled Yongxing Mou
2025-06-09 12:21 ` [PATCH v2 37/38] drm/msm/dp: fix the intf_type of MST interfaces Yongxing Mou
2025-06-09 14:45 ` Dmitry Baryshkov
2025-06-09 12:21 ` [PATCH v2 38/38] drm/msm/dp: Add MST stream support for SA8775P DP controller 0 and 1 Yongxing Mou
2025-06-09 14:47 ` Dmitry Baryshkov
2025-06-09 12:36 ` [PATCH v2 00/38] drm/msm/dp: Add MST support for MSM chipsets Dmitry Baryshkov
2025-06-10 4:47 ` Yongxing Mou
2025-06-10 8:30 ` Dmitry Baryshkov
2025-06-11 12:08 ` Yongxing Mou
2025-06-11 14:35 ` Dmitry Baryshkov
2025-06-09 16:07 ` Dmitry Baryshkov
2025-06-10 4:31 ` Yongxing Mou
2025-06-10 8:31 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01ccebf2-1a2c-4996-8b56-1fb951a6d8c6@quicinc.com \
--to=quic_yongmou@quicinc.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®