Re: [PATCH v2 00/38] drm/msm/dp: Add MST support for MSM chipsets

[Yongxing Mou <quic_yongmou@quicinc.com>]

On 2025/6/10 0:07, Dmitry Baryshkov wrote:
> On Mon, Jun 09, 2025 at 08:21:19PM +0800, Yongxing Mou wrote:
>> Add support for Multi-stream transport for MSM chipsets that allow
>> a single instance of DP controller to send multiple streams.
>>
>> This series has been validated on sa8775p ride platform using multiple
>> MST dongles and also daisy chain method on both DP0 and DP1 upto 1080P.
>>
>> With 4x4K monitors, due to lack of layer mixers that combination will not
>> work but this can be supported as well after some rework on the DPU side.
>>
>> In addition, SST was re-validated with all these changes to ensure there
>> were no regressions.
>>
>> This patch series was made on top of:
>>
>> [1] : https://patchwork.freedesktop.org/seriedds/142010/ (v2 to fix up HPD)
>>
>> Bindings for the pixel clock for additional stream is available at :
>>
>> [2] : https://patchwork.freedesktop.org/series/142016/
>>
>> Overall, the patch series has been organized in the following way:
>>
>> 1) First set are a couple of fixes made while debugging MST but applicable
>> to SST as well so go ahead of everything else
>> 2) Prepare the DP driver to get ready to handle multiple streams. This is the bulk
>> of the work as current DP driver design had to be adjusted to make this happen.
>> 3) Finally, new files to handle MST related operations
>>
>> Validation was done on the latest linux-next on top of above changes and
>> both FB console and weston compositors were validated with these changes.
> 
> I went about a halfway through the series. During that I noticed ignored
> feedback, missing reviewer tags, invalid or strange authorship / SoB
> tags, overgrown functions, one line wrappers, etc.
> 
> Please rebase on top of [3], review the patch series on your own,
> removing / reworking all the bits that can catch my eye, implement the
> feedback, ask questions where you don't understand it, etc. After that
> please post v3. I'll most likely skip the rest of the patches for now.
> 
> [3] https://lore.kernel.org/dri-devel/20250518-fd-dp-audio-fixup-v6-0-2f0ec3ec000d@oss.qualcomm.com
> 
Hi, Dmitry, thanks for your reviewing very much. Actually i have 
reviewed all the comments on Patch v1. Sorry for not cleaning up 
everything as expected. I will address and discuss all the remaining 
items in the comments for Patch v2, and will follow up with Patch v3 
accordingly.