mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Zhu Jun <zhujun2@cmss.chinamobile.com>,
	linux-sound@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Kuninori Morimoto" <kuninori.morimoto.gx@renesas.com>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"Weidong Wang" <wangweidong.a@awinic.com>
Subject: Re: [PATCH v2?] ASoC: codecs: aw88399: Fix error handling in aw_dev_get_dsp_status function
Date: Wed, 9 Oct 2024 10:43:51 +0200	[thread overview]
Message-ID: <01d7c030-1d80-4533-9279-2b6961e712ac@web.de> (raw)
In-Reply-To: <20241009073938.7472-1-zhujun2@cmss.chinamobile.com>

How do you think about to replace the word “function” (in the summary phrase)
by parentheses?


> Added proper error handling for register value check that

  Add?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n94


> return -EPERM when register value does not meet expected condition

* It is usually preferred to end such a sentence with a dot, isn't it?

* Would you like to add any tags (like “Fixes” and “Cc”) accordingly?


…
> ---
>  sound/soc/codecs/aw88399.c | 2 +-

Please take version information better into account.

See also:
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n321

* https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22


Regards,
Markus

  reply	other threads:[~2024-10-09  8:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09  7:39 [PATCH] ASoC: codecs: " Zhu Jun
2024-10-09  8:43 ` Markus Elfring [this message]
2024-10-09 10:40   ` [PATCH v2?] ASoC: codecs: aw88399: " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01d7c030-1d80-4533-9279-2b6961e712ac@web.de \
    --to=markus.elfring@web.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=heiko@sntech.de \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=nathan@kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=wangweidong.a@awinic.com \
    --cc=zhujun2@cmss.chinamobile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®