* [PATCH] ASoC: codecs: Fix error handling in aw_dev_get_dsp_status function
@ 2024-10-09 7:39 Zhu Jun
2024-10-09 8:43 ` [PATCH v2?] ASoC: codecs: aw88399: " Markus Elfring
0 siblings, 1 reply; 3+ messages in thread
From: Zhu Jun @ 2024-10-09 7:39 UTC (permalink / raw)
To: tiwai
Cc: perex, wangweidong.a, andriy.shevchenko, heiko,
kuninori.morimoto.gx, nathan, zhujun2, linux-sound, linux-kernel,
lgirdwood, broonie
Added proper error handling for register value check that
return -EPERM when register value does not meet expected condition
Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
---
sound/soc/codecs/aw88399.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/aw88399.c b/sound/soc/codecs/aw88399.c
index 8dc2b8aa6832..bba59885242d 100644
--- a/sound/soc/codecs/aw88399.c
+++ b/sound/soc/codecs/aw88399.c
@@ -656,7 +656,7 @@ static int aw_dev_get_dsp_status(struct aw_device *aw_dev)
if (ret)
return ret;
if (!(reg_val & (~AW88399_WDT_CNT_MASK)))
- ret = -EPERM;
+ return -EPERM;
return 0;
}
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2?] ASoC: codecs: aw88399: Fix error handling in aw_dev_get_dsp_status function
2024-10-09 7:39 [PATCH] ASoC: codecs: Fix error handling in aw_dev_get_dsp_status function Zhu Jun
@ 2024-10-09 8:43 ` Markus Elfring
2024-10-09 10:40 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Markus Elfring @ 2024-10-09 8:43 UTC (permalink / raw)
To: Zhu Jun, linux-sound, Jaroslav Kysela, Takashi Iwai
Cc: LKML, Andy Shevchenko, Heiko Stübner, Kuninori Morimoto,
Liam Girdwood, Mark Brown, Nathan Chancellor,
Uwe Kleine-König, Weidong Wang
How do you think about to replace the word “function” (in the summary phrase)
by parentheses?
> Added proper error handling for register value check that
Add?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n94
> return -EPERM when register value does not meet expected condition
* It is usually preferred to end such a sentence with a dot, isn't it?
* Would you like to add any tags (like “Fixes” and “Cc”) accordingly?
…
> ---
> sound/soc/codecs/aw88399.c | 2 +-
Please take version information better into account.
See also:
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n321
* https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2?] ASoC: codecs: aw88399: Fix error handling in aw_dev_get_dsp_status function
2024-10-09 8:43 ` [PATCH v2?] ASoC: codecs: aw88399: " Markus Elfring
@ 2024-10-09 10:40 ` Mark Brown
0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2024-10-09 10:40 UTC (permalink / raw)
To: Markus Elfring
Cc: Zhu Jun, linux-sound, Jaroslav Kysela, Takashi Iwai, LKML,
Andy Shevchenko, Heiko Stübner, Kuninori Morimoto,
Liam Girdwood, Nathan Chancellor, Uwe Kleine-König,
Weidong Wang
[-- Attachment #1: Type: text/plain, Size: 312 bytes --]
On Wed, Oct 09, 2024 at 10:43:51AM +0200, Markus Elfring wrote:
> How do you think about to replace the word “function” (in the summary phrase)
> by parentheses?
Feel free to ignore Markus, he has a long history of sending
unhelpful review comments and continues to ignore repeated requests
to stop.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-09 10:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-09 7:39 [PATCH] ASoC: codecs: Fix error handling in aw_dev_get_dsp_status function Zhu Jun
2024-10-09 8:43 ` [PATCH v2?] ASoC: codecs: aw88399: " Markus Elfring
2024-10-09 10:40 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®