mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Huang, Kai" <kai.huang@intel.com>
To: "seanjc@google.com" <seanjc@google.com>,
	"yosry@kernel.org" <yosry@kernel.org>
Cc: "jmattson@google.com" <jmattson@google.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] KVM: nVM: Ensure INVVPID is emulated on the correct physical CPU
Date: Thu, 18 Jun 2026 11:00:50 +0000	[thread overview]
Message-ID: <01df728334062de2da94c587c71f692004993653.camel@intel.com> (raw)
In-Reply-To: <20260616214652.2157032-4-yosry@kernel.org>

On Tue, 2026-06-16 at 21:46 +0000, Yosry Ahmed wrote:
> When emulating INVVPID, KVM executes INVVPID on the physical CPU using
> vpid02 (instead of the L1 assigned VPID), after doing some validations
> on the operands. However, it is possible that the physical CPU KVM
> executes INVVPID on is different from the CPU L2 is running on.
> 
> For example, in the following scenario:
> - L2 runs on CPU #1 and exits to L1 (vmx->nested.vmcs02.cpu=1)
> - L1 migrates to CPU #2 and executes INVVPID
> - KVM executes INVVPID on CPU #2
> - L1 migrates back to CPU #1 and runs L2 (vmx->nested.vmcs02.cpu=1)
> 
> The TLB entries on CPU #1 are never invalidated, because INVVPID was
> executed on CPU #2, and vmcs02 never ran on a different pCPU (i.e.
> vmx_vcpu_load_vmcs() will *not* request KVM_REQ_TLB_FLUSH).
> 
> Ensure that INVVPID is being executed on the same pCPU that L2 last ran
> on, and if not, fallback to clearing last_vpid=0 to trigger a full VPID
> flush on the next nested VM-Enter (as KVM will detect L1 using a
> different VPID for L2). If L2 ends up running on a different pCPU, KVM
> will flush the TLB anyway through vmx_vcpu_load_vmcs().
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Yosry Ahmed <yosry@kernel.org>
> 

Reviewed-by: Kai Huang <kai.huang@intel.com>

  reply	other threads:[~2026-06-18 11:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-16 21:46 [PATCH 0/3] KVM: nVMX: A few TLB flushing fixes Yosry Ahmed
2026-06-16 21:46 ` [PATCH 1/3] KVM: nVMX: Always flush vpid02 on first use Yosry Ahmed
2026-06-16 22:25   ` Jim Mattson
2026-06-17 11:30   ` Huang, Kai
2026-06-17 13:03     ` Sean Christopherson
2026-06-17 22:03       ` Huang, Kai
2026-06-17 22:04         ` Yosry Ahmed
2026-06-17 22:08           ` Huang, Kai
2026-06-17 22:09             ` Yosry Ahmed
2026-06-17 22:26           ` Sean Christopherson
2026-06-17 22:37             ` Huang, Kai
2026-06-16 21:46 ` [PATCH 2/3] KVM: nVMX: Decouple INVVPID operand checks from flushing of vpid02 Yosry Ahmed
2026-06-18 10:57   ` Huang, Kai
2026-06-18 15:59     ` Yosry Ahmed
2026-06-16 21:46 ` [PATCH 3/3] KVM: nVM: Ensure INVVPID is emulated on the correct physical CPU Yosry Ahmed
2026-06-18 11:00   ` Huang, Kai [this message]
2026-07-14 18:41 ` [PATCH 0/3] KVM: nVMX: A few TLB flushing fixes Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01df728334062de2da94c587c71f692004993653.camel@intel.com \
    --to=kai.huang@intel.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=stable@vger.kernel.org \
    --cc=yosry@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome