From: "Huang, Kai" <kai.huang@intel.com>
To: "seanjc@google.com" <seanjc@google.com>,
"yosry@kernel.org" <yosry@kernel.org>
Cc: "jmattson@google.com" <jmattson@google.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] KVM: nVMX: Always flush vpid02 on first use
Date: Wed, 17 Jun 2026 11:30:48 +0000 [thread overview]
Message-ID: <5b5a0f3f21bba5d25410382a9e0170a17c952738.camel@intel.com> (raw)
In-Reply-To: <20260616214652.2157032-2-yosry@kernel.org>
On Tue, 2026-06-16 at 21:46 +0000, Yosry Ahmed wrote:
> Make sure vpid02 is always flushed on first use by setting last_vpid=0
> when allocating vpid02. nested_vmx_transition_tlb_flush() will always
> detect a VPID change on first VM-Enter after VMXON, because VPID=0 in
> vmcb12 is not allowed if L1 enables VPID.
vmcs12 :-)
>
> This avoids using stale TLB entries from a previous lifetime of the
> VPID, that might have been associated with a different vCPU (or a
> completely different VM).
>
> Note that last_vpid is already being initialized as 0 when the vCPU is
> created, but it is not reset when vpid02 is freed on VMXOFF. Hence, the
> problem can only occur if L1 does VMXOFF -> VMXON, runs an L2, and KVM
> happens to reuse a VPID that has TLB entries on the physical CPU.
Not sure whether it's better to set it to 0 in free_nested(), which also resets
some other nested fields to clean slate AFAICT?
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Yosry Ahmed <yosry@kernel.org>
Anyway:
Reviewed-by: Kai Huang <kai.huang@intel.com>
next prev parent reply other threads:[~2026-06-17 11:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 21:46 [PATCH 0/3] KVM: nVMX: A few TLB flushing fixes Yosry Ahmed
2026-06-16 21:46 ` [PATCH 1/3] KVM: nVMX: Always flush vpid02 on first use Yosry Ahmed
2026-06-16 22:25 ` Jim Mattson
2026-06-17 11:30 ` Huang, Kai [this message]
2026-06-17 13:03 ` Sean Christopherson
2026-06-17 22:03 ` Huang, Kai
2026-06-17 22:04 ` Yosry Ahmed
2026-06-17 22:08 ` Huang, Kai
2026-06-17 22:09 ` Yosry Ahmed
2026-06-17 22:26 ` Sean Christopherson
2026-06-17 22:37 ` Huang, Kai
2026-06-16 21:46 ` [PATCH 2/3] KVM: nVMX: Decouple INVVPID operand checks from flushing of vpid02 Yosry Ahmed
2026-06-18 10:57 ` Huang, Kai
2026-06-18 15:59 ` Yosry Ahmed
2026-06-16 21:46 ` [PATCH 3/3] KVM: nVM: Ensure INVVPID is emulated on the correct physical CPU Yosry Ahmed
2026-06-18 11:00 ` Huang, Kai
2026-07-14 18:41 ` [PATCH 0/3] KVM: nVMX: A few TLB flushing fixes Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b5a0f3f21bba5d25410382a9e0170a17c952738.camel@intel.com \
--to=kai.huang@intel.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=stable@vger.kernel.org \
--cc=yosry@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®