Re: [Ext2-devel] [RFC][15/21]e2fsprogs modify variables for bitmap to exceed 2G

["Takashi Sato" <sho@bsd.tnes.nec.co.jp>]

Thank you for your comment, Ted.

> Generalized NACK.  We can't just blindly change function signatures of
> pre-existing functions in libext2fs, since this breaks the ABI with
> pre-existing applications linked with current shared libraries of
> libext2fs.

Though I checked if there are any commands which use the following
functions in RHEL4, no such commands were found except in e2fsprogs
itself.

ext2fs_allocate_generic_bitmap()
ext2fs_fudge_block_bitmap_end()
ext2fs_warn_bitmap()
ext2fs_test_generic_bitmap()
ext2fs_mark_block_bitmap()
ext2fs_unmark_block_bitmap()
ext2fs_test_block_bitmap()
ext2fs_fast_test_block_bitmap_range()
ext2fs_mark_block_bitmap_range()
ext2fs_fast_mark_block_bitmap_range()
ext2fs_unmark_block_bitmap_range()
ext2fs_fast_unmark_block_bitmap_range()
ext2fs_mark_generic_bitmap()
ext2fs_unmark_generic_bitmap()
ext2fs_resize_generic_bitmap()
ext2fs_resize_block_bitmap()

So I think changing these function signatures does not break the ABI
practically.  Am I missing something?

Cheers, sho