From: Arjan van de Ven <arjan@infradead.org>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: sho@tnes.nec.co.jp, Ext2-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [Ext2-devel] [RFC][15/21]e2fsprogs modify variables for bitmap to exceed 2G
Date: Mon, 17 Apr 2006 15:01:53 +0200 [thread overview]
Message-ID: <1145278913.2847.40.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20060413162028.GA23452@thunk.org>
On Thu, 2006-04-13 at 12:20 -0400, Theodore Ts'o wrote:
> On Thu, Apr 13, 2006 at 04:12:27PM +0900, sho@tnes.nec.co.jp wrote:
> > Summary of this patch:
> > [15/21] change the type of variables which manipulate bitmap
> > - Change the type of 4byte variables manipulating bitmap
> > from signed to unsigned.
>
> Generalized NACK. We can't just blindly change function signatures of
> pre-existing functions in libext2fs, since this breaks the ABI with
> pre-existing applications linked with current shared libraries of
> libext2fs.
>
> We could bump the major version number, but what I'd much rather do is
> to create new functions which use the 64-bit blk64_t (i.e.,
> ext2fs_mark_block_bitmap2). This will make the patches much bigger,
> but it allows us to preserve backwards compatibility.
would this be a time to consider using ELF function versioning (similar
to what glibc and others use for abi comat) in libext2fs ?
next prev parent reply other threads:[~2006-04-17 13:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-13 7:12 sho
2006-04-13 16:20 ` [Ext2-devel] " Theodore Ts'o
2006-04-17 12:30 ` Takashi Sato
2006-04-17 12:48 ` Adrian Bunk
2006-04-18 4:37 ` Takashi Sato
2006-04-17 13:01 ` Arjan van de Ven [this message]
2006-04-18 7:45 ` Takashi Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1145278913.2847.40.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=Ext2-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sho@tnes.nec.co.jp \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®