From: "Paul E. McKenney" <paulmck@kernel.org>
To: Jonas Oberhauser <jonas.oberhauser@huaweicloud.com>
Cc: Akira Yokosawa <akiyks@gmail.com>,
boqun.feng@gmail.com, dhowells@redhat.com, dlustig@nvidia.com,
frederic@kernel.org, hernan.poncedeleon@huaweicloud.com,
j.alglave@ucl.ac.uk, joel@joelfernandes.org,
linux-kernel@vger.kernel.org, lkmm@lists.linux.dev,
luc.maranget@inria.fr, npiggin@gmail.com, parri.andrea@gmail.com,
peterz@infradead.org, quic_neeraju@quicinc.com,
stern@rowland.harvard.edu, urezki@gmail.com, will@kernel.org
Subject: Re: [PATCH v4 5/5] tools/memory-model: Distinguish between syntactic and semantic tags
Date: Mon, 18 Nov 2024 07:05:05 -0800 [thread overview]
Message-ID: <02537f27-ac3b-4e2e-80a2-ad57230ac478@paulmck-laptop> (raw)
In-Reply-To: <245e4781-80b2-4e21-b4de-51ffeac9cc39@paulmck-laptop>
On Fri, Nov 08, 2024 at 10:35:24AM -0800, Paul E. McKenney wrote:
> On Fri, Nov 08, 2024 at 12:07:43PM +0100, Jonas Oberhauser wrote:
> >
> >
> > Am 11/8/2024 um 11:12 AM schrieb Akira Yokosawa:
> > > On Fri, 8 Nov 2024 10:10:48 +0100, Jonas Oberhauser wrote:
> > > > I hadn't done that before (because I thought I should not add other people's tags
> > > > especially if they hadn't reviewed that specific revision), so we may be missing
> > > > *a lot* of reviewed-by...
> > > >
> > >
> > > Section "Using Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: and Fixes:"
> > > of Documentation/process/submitting-patches.rst has this paragraph:
> > >
> > > Both Tested-by and Reviewed-by tags, once received on mailing list from tester
> > > or reviewer, should be added by author to the applicable patches when sending
> > > next versions. However if the patch has changed substantially in following
> > > version, these tags might not be applicable anymore and thus should be removed.
> > > Usually removal of someone's Tested-by or Reviewed-by tags should be mentioned
> > > in the patch changelog (after the '---' separator).
> > >
> > > Does this help you?
> >
> > Thanks so much, it does. My apologies to everyone whose reviewed-by tag I
> > failed to add :(
> >
> > I should have read that more document more carefully.
>
> No worries! The important part is your changes. The tags are easy
> to add. And now you know. ;-)
The first three of your patches could go in, but the last two require a
new herd7 release (for the lkmmv2 flag). Left to myself, I would hold
all five until we get a new herd7 release, but if it is important to
get the first three into the current merge window, please rebase them
to mainline some time this week. I would then send a pull request for
the for next week, the second and final week of the merge window.
Over to you!
Thanx, Paul
next prev parent reply other threads:[~2024-11-18 15:05 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 10:57 [PATCH v4 0/5] tools/memory-model: Define more of LKMM in tools/memory-model Jonas Oberhauser
2024-09-30 10:57 ` [PATCH v4 1/5] tools/memory-model: Legitimize current use of tags in LKMM macros Jonas Oberhauser
2024-10-28 22:11 ` Boqun Feng
2024-09-30 10:57 ` [PATCH v4 2/5] tools/memory-model: Define applicable tags on operation in tools/ Jonas Oberhauser
2024-10-28 22:12 ` Boqun Feng
2024-09-30 10:57 ` [PATCH v4 3/5] tools/memory-model: Define effect of Mb tags on RMWs " Jonas Oberhauser
2024-10-28 22:15 ` Boqun Feng
2024-09-30 10:57 ` [PATCH v4 4/5] tools/memory-model: Switch to softcoded herd7 tags Jonas Oberhauser
2024-10-02 17:34 ` Hernan Ponce de Leon
2024-10-29 0:04 ` Boqun Feng
2024-10-29 23:42 ` Paul E. McKenney
2024-10-30 11:50 ` Jonas Oberhauser
2024-10-30 13:46 ` Paul E. McKenney
2024-09-30 10:57 ` [PATCH v4 5/5] tools/memory-model: Distinguish between syntactic and semantic tags Jonas Oberhauser
2024-10-29 0:15 ` Boqun Feng
2024-10-29 23:41 ` Paul E. McKenney
2024-10-30 11:38 ` Jonas Oberhauser
2024-10-30 14:34 ` Boqun Feng
2024-10-30 16:27 ` Paul E. McKenney
2024-11-05 20:21 ` Paul E. McKenney
2024-11-06 10:28 ` Jonas Oberhauser
2024-11-06 15:04 ` Paul E. McKenney
2024-11-06 18:00 ` Paul E. McKenney
2024-11-07 9:05 ` Jonas Oberhauser
2024-11-07 10:51 ` Akira Yokosawa
2024-11-07 14:04 ` Paul E. McKenney
2024-11-08 9:10 ` Jonas Oberhauser
2024-11-08 10:12 ` Akira Yokosawa
2024-11-08 11:07 ` Jonas Oberhauser
2024-11-08 18:35 ` Paul E. McKenney
2024-11-18 15:05 ` Paul E. McKenney [this message]
2024-11-26 15:25 ` Jonas Oberhauser
2024-11-26 16:03 ` Paul E. McKenney
2024-10-28 20:16 ` [PATCH v4 0/5] tools/memory-model: Define more of LKMM in tools/memory-model Paul E. McKenney
2024-11-10 15:17 ` Akira Yokosawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02537f27-ac3b-4e2e-80a2-ad57230ac478@paulmck-laptop \
--to=paulmck@kernel.org \
--cc=akiyks@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=dhowells@redhat.com \
--cc=dlustig@nvidia.com \
--cc=frederic@kernel.org \
--cc=hernan.poncedeleon@huaweicloud.com \
--cc=j.alglave@ucl.ac.uk \
--cc=joel@joelfernandes.org \
--cc=jonas.oberhauser@huaweicloud.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkmm@lists.linux.dev \
--cc=luc.maranget@inria.fr \
--cc=npiggin@gmail.com \
--cc=parri.andrea@gmail.com \
--cc=peterz@infradead.org \
--cc=quic_neeraju@quicinc.com \
--cc=stern@rowland.harvard.edu \
--cc=urezki@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®