mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Jonas Oberhauser <jonas.oberhauser@huaweicloud.com>
Cc: Boqun Feng <boqun.feng@gmail.com>,
	stern@rowland.harvard.edu, parri.andrea@gmail.com,
	will@kernel.org, peterz@infradead.org, npiggin@gmail.com,
	dhowells@redhat.com, j.alglave@ucl.ac.uk, luc.maranget@inria.fr,
	akiyks@gmail.com, dlustig@nvidia.com, joel@joelfernandes.org,
	urezki@gmail.com, quic_neeraju@quicinc.com, frederic@kernel.org,
	linux-kernel@vger.kernel.org, lkmm@lists.linux.dev,
	hernan.poncedeleon@huaweicloud.com
Subject: Re: [PATCH v4 4/5] tools/memory-model: Switch to softcoded herd7 tags
Date: Wed, 30 Oct 2024 06:46:45 -0700	[thread overview]
Message-ID: <55719a66-aeb9-4c20-afa6-e46dbb54c22f@paulmck-laptop> (raw)
In-Reply-To: <ba2b6c1d-4930-4ede-ba21-d7a2fa46e5e1@huaweicloud.com>

On Wed, Oct 30, 2024 at 12:50:19PM +0100, Jonas Oberhauser wrote:
> 
> 
> Am 10/29/2024 um 1:04 AM schrieb Boqun Feng:
> > 
> > One bit below:
> >
> > On Mon, Sep 30, 2024 at 12:57:09PM +0200, Jonas Oberhauser wrote:
> > >       ------------------------------------------------------------------------------
> > >       |       RMW ops w/o return value |                                           |
> > >       ------------------------------------------------------------------------------
> > > -    |                     atomic_add | R*[noreturn] ->rmw W*[once]               |
> > > +    |                     atomic_add | R*[noreturn] ->rmw W*[noreturn]           |
> > 
> > Not in this patch, but don't you need to update this again to all cap
> > to match your changes in patch #5? ;-)
> > 
> 
> Hmmm, probably that is a good idea.
> I actually had thought about it for some of the other places in the doc that
> mention the tags, and concluded that we'll just use the semantic tags there.
> 
> But in fact, this file is about the syntactic representation in herd, and
> there is no noreturn semantic tag on the W*, so it wouldn't match it even if
> it were correct.
> 
> So I think this needs to be addressed in 5/5.

Thank you for checking!

Please send me either a replacement for 5/5 or a patch for me to fold
into 5/5.

							Thanx, Paul

  reply	other threads:[~2024-10-30 13:46 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-30 10:57 [PATCH v4 0/5] tools/memory-model: Define more of LKMM in tools/memory-model Jonas Oberhauser
2024-09-30 10:57 ` [PATCH v4 1/5] tools/memory-model: Legitimize current use of tags in LKMM macros Jonas Oberhauser
2024-10-28 22:11   ` Boqun Feng
2024-09-30 10:57 ` [PATCH v4 2/5] tools/memory-model: Define applicable tags on operation in tools/ Jonas Oberhauser
2024-10-28 22:12   ` Boqun Feng
2024-09-30 10:57 ` [PATCH v4 3/5] tools/memory-model: Define effect of Mb tags on RMWs " Jonas Oberhauser
2024-10-28 22:15   ` Boqun Feng
2024-09-30 10:57 ` [PATCH v4 4/5] tools/memory-model: Switch to softcoded herd7 tags Jonas Oberhauser
2024-10-02 17:34   ` Hernan Ponce de Leon
2024-10-29  0:04   ` Boqun Feng
2024-10-29 23:42     ` Paul E. McKenney
2024-10-30 11:50     ` Jonas Oberhauser
2024-10-30 13:46       ` Paul E. McKenney [this message]
2024-09-30 10:57 ` [PATCH v4 5/5] tools/memory-model: Distinguish between syntactic and semantic tags Jonas Oberhauser
2024-10-29  0:15   ` Boqun Feng
2024-10-29 23:41     ` Paul E. McKenney
2024-10-30 11:38       ` Jonas Oberhauser
2024-10-30 14:34         ` Boqun Feng
2024-10-30 16:27           ` Paul E. McKenney
2024-11-05 20:21           ` Paul E. McKenney
2024-11-06 10:28             ` Jonas Oberhauser
2024-11-06 15:04               ` Paul E. McKenney
2024-11-06 18:00                 ` Paul E. McKenney
2024-11-07  9:05                   ` Jonas Oberhauser
2024-11-07 10:51                     ` Akira Yokosawa
2024-11-07 14:04                       ` Paul E. McKenney
2024-11-08  9:10                       ` Jonas Oberhauser
2024-11-08 10:12                         ` Akira Yokosawa
2024-11-08 11:07                           ` Jonas Oberhauser
2024-11-08 18:35                             ` Paul E. McKenney
2024-11-18 15:05                               ` Paul E. McKenney
2024-11-26 15:25                                 ` Jonas Oberhauser
2024-11-26 16:03                                   ` Paul E. McKenney
2024-10-28 20:16 ` [PATCH v4 0/5] tools/memory-model: Define more of LKMM in tools/memory-model Paul E. McKenney
2024-11-10 15:17   ` Akira Yokosawa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55719a66-aeb9-4c20-afa6-e46dbb54c22f@paulmck-laptop \
    --to=paulmck@kernel.org \
    --cc=akiyks@gmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=dlustig@nvidia.com \
    --cc=frederic@kernel.org \
    --cc=hernan.poncedeleon@huaweicloud.com \
    --cc=j.alglave@ucl.ac.uk \
    --cc=joel@joelfernandes.org \
    --cc=jonas.oberhauser@huaweicloud.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkmm@lists.linux.dev \
    --cc=luc.maranget@inria.fr \
    --cc=npiggin@gmail.com \
    --cc=parri.andrea@gmail.com \
    --cc=peterz@infradead.org \
    --cc=quic_neeraju@quicinc.com \
    --cc=stern@rowland.harvard.edu \
    --cc=urezki@gmail.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®