hwmon: xgene: Add support for X-Gene hwmon driver

hwmon: xgene: Add support for X-Gene hwmon driver

[Itaru Kitayama]

Hi Hoan,

I've been testing your patch set on a Rev B0 system with ACPI, in dmesg
I see:

[    1.546444] xgene-slimpro-i2c APMC0D40:00: i2c mailbox channel 
request failed
[    1.570062] xgene-slimpro-hwmon APMC0D29:00: no pcc-channel property

what other packages or subsystems do we need to make this work on 
ACPI-based systems?

Itaru

Re: hwmon: xgene: Add support for X-Gene hwmon driver

[Hoan Tran]

Hi Itaru,


> On Jul 23, 2016, at 16:51, Itaru Kitayama <itaru.kitayama@riken.jp> wrote:
> 
> Hi Hoan,
> 
> I've been testing your patch set on a Rev B0 system with ACPI, in dmesg
> I see:
> 
> [    1.546444] xgene-slimpro-i2c APMC0D40:00: i2c mailbox channel request failed
> [    1.570062] xgene-slimpro-hwmon APMC0D29:00: no pcc-channel property
> 
> what other packages or subsystems do we need to make this work on ACPI-based systems?

You need the new firmware and BIOS which support ACPI PCC mailbox.

Thanks
Hoan

> 
> Itaru

Re: hwmon: xgene: Add support for X-Gene hwmon driver

[Itaru Kitayama]

Hi Hoan,

I didn't mention in my previous post, though I think I'm using fairly 
recent version of Tianocore F/W, and I can confirm there's the PCCT table,

[    0.000000] ACPI: PCCT 0x00000047FA826000 000300 (v01 APM    XGENE 
00000003      01000013)

is this still not enough? If that's the case, I'll talk to APM for
their latest development Tianocore version.
Also, if you or your folks can fold your patch set into APM's xgene-next
GitHub repo, that would help me to keep up with the development.

Itaru

On 7/24/16 12:00 PM, Hoan Tran wrote:
> You need the new firmware and BIOS which support ACPI PCC mailbox.
>
> Thanks
> Hoan

Re: hwmon: xgene: Add support for X-Gene hwmon driver

[Hoan Tran]

Hi Itaru,

On Sat, Jul 23, 2016 at 10:04 PM, Itaru Kitayama
<itaru.kitayama@riken.jp> wrote:
> Hi Hoan,
>
> I didn't mention in my previous post, though I think I'm using fairly recent
> version of Tianocore F/W, and I can confirm there's the PCCT table,
>
> [    0.000000] ACPI: PCCT 0x00000047FA826000 000300 (v01 APM    XGENE
> 00000003      01000013)
>
> is this still not enough? If that's the case, I'll talk to APM for
> their latest development Tianocore version.

Your version is missing the "pcc-channel" property of hwmon inside
ACPI Table. You need a newer version of Tianocore.

> Also, if you or your folks can fold your patch set into APM's xgene-next
> GitHub repo, that would help me to keep up with the development.

xgene-next is currently used for device tree patch only.

Thanks
Hoan

>
> Itaru
>
>
> On 7/24/16 12:00 PM, Hoan Tran wrote:
>>
>> You need the new firmware and BIOS which support ACPI PCC mailbox.
>>
>> Thanks
>> Hoan

Re: hwmon: xgene: Add support for X-Gene hwmon driver

[Loc Ho]

Hi Itaru,

On Sat, Jul 23, 2016 at 10:04 PM, Itaru Kitayama
<itaru.kitayama@riken.jp> wrote:
>
> Hi Hoan,
>
> I didn't mention in my previous post, though I think I'm using fairly recent version of Tianocore F/W, and I can confirm there's the PCCT table,
>
> [    0.000000] ACPI: PCCT 0x00000047FA826000 000300 (v01 APM    XGENE 00000003      01000013)
>
> is this still not enough? If that's the case, I'll talk to APM for
> their latest development Tianocore version.

You will need the to be released FW version 3.06.xx or above. This new
FW won't be official release until at least a few months. If you want
to test this new firmware, we can get you an earlier image but there
will be very limited support. Though, Hoan will support you when
possible.

> Also, if you or your folks can fold your patch set into APM's xgene-next
> GitHub repo, that would help me to keep up with the development.

This can only get pull into xgene-next if it had accepted upstream.

-Loc