mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Thomas Gleixner <tglx@linutronix.de>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] irq: ipi: fix NULL pointer deref in irq_data_get_affinity_mask()
Date: Sun, 19 Feb 2023 13:20:22 +0300	[thread overview]
Message-ID: <028ccd43-1474-1f90-653e-044641cc533f@omp.ru> (raw)
In-Reply-To: <875ycb2jwe.ffs@tglx>

On 2/9/23 1:49 PM, Thomas Gleixner wrote:
[...]

>>> Iff ipi_send_{mask|single}() get called with e.g. an invalid IRQ #, all the
>>> local variables there will be NULL -- the problem is that ipi_send_verify()
>>> (that's called first thing) doesn't verify its 'data' parameter, resulting
>>> in a kernel oops in irq_data_get_affinity_mask() as the passed NULL pointer
>>> gets dereferenced.  Add a missing NULL check in ipi_send_verify()...
>>>
>>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>>> analysis tool.
>>>
>>> Fixes: 3b8e29a82dd1 ("genirq: Implement ipi_send_mask/single()")
>>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>>
>>    Patch fell thru the cracks? :-/
> 
> Obviously :)
> 
> /me goes to find trash tongs to pick it up

   Need help? :-)

MBR, Sergey

  reply	other threads:[~2023-02-19 10:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17 20:00 Sergey Shtylyov
2023-02-08 18:35 ` Sergey Shtylyov
2023-02-09 10:49   ` Thomas Gleixner
2023-02-19 10:20     ` Sergey Shtylyov [this message]
2023-02-20 12:55 ` [tip: irq/urgent] genirq/ipi: Fix " tip-bot2 for Sergey Shtylyov
2023-02-24 10:37   ` Sergey Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=028ccd43-1474-1f90-653e-044641cc533f@omp.ru \
    --to=s.shtylyov@omp.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®