mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Thomas Gleixner <tglx@linutronix.de>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] irq: ipi: fix NULL pointer deref in irq_data_get_affinity_mask()
Date: Wed, 17 Aug 2022 23:00:45 +0300	[thread overview]
Message-ID: <b541232d-c2b6-1fe9-79b4-a7129459e4d0@omp.ru> (raw)

Iff ipi_send_{mask|single}() get called with e.g. an invalid IRQ #, all the
local variables there will be NULL -- the problem is that ipi_send_verify()
(that's called first thing) doesn't verify its 'data' parameter, resulting
in a kernel oops in irq_data_get_affinity_mask() as the passed NULL pointer
gets dereferenced.  Add a missing NULL check in ipi_send_verify()...

Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.

Fixes: 3b8e29a82dd1 ("genirq: Implement ipi_send_mask/single()")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>

---
The patch is against the 'tip.git' repo's 'master' branch...

 kernel/irq/ipi.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Index: tip/kernel/irq/ipi.c
===================================================================
--- tip.orig/kernel/irq/ipi.c
+++ tip/kernel/irq/ipi.c
@@ -188,9 +188,9 @@ EXPORT_SYMBOL_GPL(ipi_get_hwirq);
 static int ipi_send_verify(struct irq_chip *chip, struct irq_data *data,
 			   const struct cpumask *dest, unsigned int cpu)
 {
-	const struct cpumask *ipimask = irq_data_get_affinity_mask(data);
+	const struct cpumask *ipimask;
 
-	if (!chip || !ipimask)
+	if (!chip || !data)
 		return -EINVAL;
 
 	if (!chip->ipi_send_single && !chip->ipi_send_mask)
@@ -199,6 +199,10 @@ static int ipi_send_verify(struct irq_ch
 	if (cpu >= nr_cpu_ids)
 		return -EINVAL;
 
+	ipimask = irq_data_get_affinity_mask(data);
+	if (!ipimask)
+		return -EINVAL;
+
 	if (dest) {
 		if (!cpumask_subset(dest, ipimask))
 			return -EINVAL;

             reply	other threads:[~2022-08-17 20:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17 20:00 Sergey Shtylyov [this message]
2023-02-08 18:35 ` Sergey Shtylyov
2023-02-09 10:49   ` Thomas Gleixner
2023-02-19 10:20     ` Sergey Shtylyov
2023-02-20 12:55 ` [tip: irq/urgent] genirq/ipi: Fix " tip-bot2 for Sergey Shtylyov
2023-02-24 10:37   ` Sergey Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b541232d-c2b6-1fe9-79b4-a7129459e4d0@omp.ru \
    --to=s.shtylyov@omp.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®