mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Sascha Hauer" <s.hauer@pengutronix.de>
To: "Sergei Khomenkov" <shomenkow@gmail.com>
Cc: "Sascha Hauer" <s.hauer@pengutronix.de>,
	"Lucas Sinn" <lucas.sinn@wolfvision.net>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 2/4] media: rockchip: Add JPEG decoder driver
Date: Fri, 20 Nov 2026 13:54:15 +0000	[thread overview]
Message-ID: <028df402-a8df-4084-a4bc-7eca286a0c35@pengutronix.de> (raw)
In-Reply-To: <92CE2271-6485-4B33-AF75-480F9BD56980@gmail.com>

Hi Sergei,

On 2026-11-19 22:19, Sergei Khomenkov wrote:
> Hi Sascha,
> 
> On 2026-11-18 14:27, Sascha Hauer wrote:
> > I haven't been affected by this issue lately, but saw it when the series
> > was still based on the hantro driver. Yes, I'll change to 3 bytes per
> > pixel next round and make that the floor of sizeimage. Would be nice to
> > have a proper solution for this rather than either wasting tons of
> > memory or risk having too small buffers.
> 
> Thanks. A correction to my last mail: 3 bytes per pixel is not a worst
> case for 4:2:0, despite what tj3JPEGBufSize() suggests. Since then I
> built 4:2:0 test patterns that push the quality 100 scan as far as I
> could: libjpeg-turbo writes 3.35 bytes per pixel of scan data, byte
> stuffing included, for one of them (640x480), and the Hantro H1
> encoder on the RK3026 3.14. At quality 99 the largest I found was 3.08
> (libjpeg-turbo) and 2.88 (H1). The patterns, 96x48 and 640x480 JPEGs,
> the same frames as raw NV12 and a short script that makes them at any
> size, are at https://homenkow.ru/kernel/vpu/
> 
> With the Annex K Huffman tables and 8-bit samples, a baseline 4:2:0
> scan is at most about 3.3 bytes per pixel before byte stuffing and 4.9
> after it, at quality 100 (lower qualities are smaller). Other tables
> give a higher bound, and APPn/COM segments add any amount on top, so
> for a decoder any fixed factor is a trade-off.
> 
> So 3 bytes per pixel covers what the H1 wrote up to quality 99 and most
> of its quality 100 frames, but libjpeg-turbo goes over it from quality
> 99 up. If that trade-off is fine for you, I have no objection; I only
> would not call it the worst case in the commit message or a comment.

Ok, I'll rephrase that.

Sascha

--
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |


  reply	other threads:[~2026-11-20 13:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22 11:06 [PATCH v7 0/4] " Sascha Hauer
2026-10-22 11:06 ` [PATCH v7 1/4] media: dt-bindings: Add Rockchip JPEG decoder Sascha Hauer
2026-10-22 11:06 ` [PATCH v7 2/4] media: rockchip: Add JPEG decoder driver Sascha Hauer
2026-10-22 17:00   ` Torsten Duwe
2026-10-23  6:59     ` Sascha Hauer
2026-10-28 19:53     ` Nicolas Dufresne
2026-11-07 13:38   ` Sergei Khomenkov
2026-11-18 14:27     ` Sascha Hauer
2026-11-19 16:00       ` Nicolas Dufresne
2026-11-20 13:49         ` Sascha Hauer
2026-11-19 20:19       ` Sergei Khomenkov
2026-11-20 13:54         ` Sascha Hauer [this message]
2026-11-20 14:58   ` Philipp Zabel
2026-10-22 11:06 ` [PATCH v7 3/4] arm64: dts: rockchip: rk3588: Add JPEG decoder node Sascha Hauer
2026-10-22 11:06 ` [PATCH v7 4/4] arm64: dts: rockchip: rk356x: " Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=028df402-a8df-4084-a4bc-7eca286a0c35@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=lucas.sinn@wolfvision.net \
    --cc=mchehab@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=shomenkow@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®