From: "Sascha Hauer" <s.hauer@pengutronix.de>
To: "Nicolas Dufresne" <nicolas@ndufresne.ca>
Cc: "Sascha Hauer" <s.hauer@pengutronix.de>,
"Sergei Khomenkov" <shomenkow@gmail.com>,
"Lucas Sinn" <lucas.sinn@wolfvision.net>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 2/4] media: rockchip: Add JPEG decoder driver
Date: Fri, 20 Nov 2026 13:49:03 +0000 [thread overview]
Message-ID: <8bc5870a-2b38-4e3a-9f93-76b2673a79dd@pengutronix.de> (raw)
In-Reply-To: <41e428a6fcdcf3d0c10cada8743231797b3dd5f4.camel@ndufresne.ca>
Hi Nicolas,
On 2026-11-19 11:00, Nicolas Dufresne wrote:
> Le mercredi 18 novembre 2026 à 14:27 +0000, Sascha Hauer a écrit :
> > > Would 3 bytes per pixel be acceptable as the default, and as a floor
> > > for smaller requests, like the 2 bytes per pixel floor in 6/7 of your
> > > hantro-based v1? 4:4:4 at quality 100 would still not fit, but the
> > > subsampling is not known before the header is parsed.
> >
> > I haven't been affected by this issue lately, but saw it when the series
> > was still based on the hantro driver. Yes, I'll change to 3 bytes per
> > pixel next round and make that the floor of sizeimage. Would be nice to
> > have a proper solution for this rather than either wasting tons of
> > memory or risk having too small buffers.
>
> The hantro HW can run in ring buffer mode, that forces us to copy, but I think
> you can then perform decode without actually having the entire image in RAM.
> Would need some experimentation. We probably don't want copy to mmap + copy to
> ring buffer (double copy), and V4L2 read/write are deprecated. Note sure what to
> propose really.
The Rockchip JPEG decoder can stop on buffer ends and I just managed to
resume operation on the next buffer afterwards, so in principle we could
implement streaming mode.
Anyway, I'd say it's not worth adding the complexity to the driver to
handle that.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2026-11-20 13:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 11:06 [PATCH v7 0/4] " Sascha Hauer
2026-10-22 11:06 ` [PATCH v7 1/4] media: dt-bindings: Add Rockchip JPEG decoder Sascha Hauer
2026-10-22 11:06 ` [PATCH v7 2/4] media: rockchip: Add JPEG decoder driver Sascha Hauer
2026-10-22 17:00 ` Torsten Duwe
2026-10-23 6:59 ` Sascha Hauer
2026-10-28 19:53 ` Nicolas Dufresne
2026-11-07 13:38 ` Sergei Khomenkov
2026-11-18 14:27 ` Sascha Hauer
2026-11-19 16:00 ` Nicolas Dufresne
2026-11-20 13:49 ` Sascha Hauer [this message]
2026-11-19 20:19 ` Sergei Khomenkov
2026-11-20 13:54 ` Sascha Hauer
2026-11-20 14:58 ` Philipp Zabel
2026-10-22 11:06 ` [PATCH v7 3/4] arm64: dts: rockchip: rk3588: Add JPEG decoder node Sascha Hauer
2026-10-22 11:06 ` [PATCH v7 4/4] arm64: dts: rockchip: rk356x: " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bc5870a-2b38-4e3a-9f93-76b2673a79dd@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lucas.sinn@wolfvision.net \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=shomenkow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®