From: Yadu M G <yadu.mg@oss.qualcomm.com>
To: Shawn Lin <shawn.lin@rock-chips.com>,
jingoohan1@gmail.com, mani@kernel.org
Cc: lpieralisi@kernel.org, kwilczynski@kernel.org,
bhelgaas@google.com, robh@kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: dwc: Initialize pp->lock before MSI domain registration
Date: Thu, 23 Apr 2026 19:15:48 +0530 [thread overview]
Message-ID: <02ad9279-7bc5-49ca-86f1-a7c2cf79b91a@oss.qualcomm.com> (raw)
In-Reply-To: <68f9def1-5828-aa30-8887-4b6594595bad@rock-chips.com>
On 4/21/2026 6:52 AM, Shawn Lin wrote:
> Moreover, sophgo_pcie_host_init() calls sophgo_pcie_msi_enable() which
> need to acquires pp->lock with a uninitialized lock with your patch now.
> That could possible break all other variant drivers which need this lock
> in the .init() callback.
>
Agreed — pp->lock must be initialized even when MSI is disabled.
I'll keep the init in dw_pcie_host_init() and add a one-time init in
dw_pcie_allocate_domains() for direct callers, then resend.
Thanks,
Yadu
prev parent reply other threads:[~2026-04-23 13:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 6:52 Yadu M G
2026-04-21 1:22 ` Shawn Lin
2026-04-23 13:45 ` Yadu M G [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02ad9279-7bc5-49ca-86f1-a7c2cf79b91a@oss.qualcomm.com \
--to=yadu.mg@oss.qualcomm.com \
--cc=bhelgaas@google.com \
--cc=jingoohan1@gmail.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®