[PATCH] drm: panel-backlight-quirks: Add Framework 13 glossy and 2.8k panels

[PATCH] drm: panel-backlight-quirks: Add Framework 13 glossy and 2.8k panels

[Dustin L. Howett]

This patch depends on
20240812-amdgpu-min-backlight-quirk-v4-0-56a63ff897b7@weissschuh.net

I have tested these panels on the Framework Laptop 13 AMD with firmware
revision 3.05 (latest at time of submission).

---
Signed-off-by: Dustin L. Howett <dustin@howett.net>
---
 drivers/gpu/drm/drm_panel_backlight_quirks.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_backlight_quirks.c b/drivers/gpu/drm/drm_panel_backlight_quirks.c
index c58344cdbb6e..348cf68729f9 100644
--- a/drivers/gpu/drm/drm_panel_backlight_quirks.c
+++ b/drivers/gpu/drm/drm_panel_backlight_quirks.c
@@ -24,6 +24,24 @@ static const struct drm_panel_min_backlight_quirk drm_panel_min_backlight_quirks
 		.ident.name = "NE135FBM-N41",
 		.min_brightness = 0,
 	},
+	/* 13 inch glossy panel */
+	{
+		.dmi_match.field = DMI_BOARD_VENDOR,
+		.dmi_match.value = "Framework",
+		.ident.panel_id = drm_edid_encode_panel_id('B', 'O', 'E', 0x095f),
+		.ident.name = "NE135FBM-N41",
+		.quirk.overrides.pwm_min_brightness = true,
+		.quirk.pwm_min_brightness = 0,
+	},
+	/* 13 inch 2.8k panel */
+	{
+		.dmi_match.field = DMI_BOARD_VENDOR,
+		.dmi_match.value = "Framework",
+		.ident.panel_id = drm_edid_encode_panel_id('B', 'O', 'E', 0x0cb4),
+		.ident.name = "NE135A1M-NY1",
+		.quirk.overrides.pwm_min_brightness = true,
+		.quirk.pwm_min_brightness = 0,
+	},
 };
 
 static bool drm_panel_min_backlight_quirk_matches(const struct drm_panel_min_backlight_quirk *quirk,

---
base-commit: da62c6801838309f5c64cd0520f7bd758edb7d4b
change-id: 20240817-drm-add-additional-framework-laptop-displays-to-panel-backlight-quirks-804c13d639ef

Best regards,
-- 
Dustin L. Howett <dustin@howett.net>

Re: [PATCH] drm: panel-backlight-quirks: Add Framework 13 glossy and 2.8k panels

[Dustin Howett]

On Sat, Aug 17, 2024 at 1:59 PM Dustin L. Howett <dustin@howett.net> wrote:
>
> This patch depends on
> 20240812-amdgpu-min-backlight-quirk-v4-0-56a63ff897b7@weissschuh.net
>
> I have tested these panels on the Framework Laptop 13 AMD with firmware
> revision 3.05 (latest at time of submission).

I apologize for the noise. I built this against Thomas' earlier patch
version and obviously did inadequate testing when he submitted v4.

I will follow up with a new revision after a little while.

>
> +               .quirk.pwm_min_brightness = 0,
                   ^^^^^^
This is clearly incorrect for the updated quirks infrastructure.

Dustin

Re: [PATCH] drm: panel-backlight-quirks: Add Framework 13 glossy and 2.8k panels

[Thomas Weißschuh]

Hi Dustin,

On 2024-08-17 14:23:42+0000, Dustin Howett wrote:
> On Sat, Aug 17, 2024 at 1:59 PM Dustin L. Howett <dustin@howett.net> wrote:
> >
> > This patch depends on
> > 20240812-amdgpu-min-backlight-quirk-v4-0-56a63ff897b7@weissschuh.net
> >
> > I have tested these panels on the Framework Laptop 13 AMD with firmware
> > revision 3.05 (latest at time of submission).

Thanks for the tests and patch!

> I apologize for the noise. I built this against Thomas' earlier patch
> version and obviously did inadequate testing when he submitted v4.
> 
> I will follow up with a new revision after a little while.
> 
> >
> > +               .quirk.pwm_min_brightness = 0,
>                    ^^^^^^
> This is clearly incorrect for the updated quirks infrastructure.

If you want, I can incorporate your patch directly into my series.
This would make the value of the quirk infrastructure in the introducing
series clearer and it should be easier for everybody to keep track of
the different parts.
If you agree, please let me know and either send me your updated patch
privately or I can adapt the patch you posted on my own.

My plan is to send a new revision tomorrow.


Thomas