* [PATCH 1/2] ext4: Check stripe size compatibility on remount as well
@ 2024-08-16 7:57 Ojaswin Mujoo
2024-08-16 7:57 ` [PATCH 2/2] ext4: Convert EXT4_B2C(sbi->s_stripe) users to EXT4_NUM_B2C Ojaswin Mujoo
2024-08-19 12:31 ` [PATCH 1/2] ext4: Check stripe size compatibility on remount as well Kemeng Shi
0 siblings, 2 replies; 6+ messages in thread
From: Ojaswin Mujoo @ 2024-08-16 7:57 UTC (permalink / raw)
To: linux-ext4, Theodore Ts'o
Cc: Ritesh Harjani, linux-kernel, Kemeng Shi, syzbot+1ad8bac5af24d01e2cbd
We disable stripe size in __ext4_fill_super if it is not a multiple of
the cluster ratio however this check is missed when trying to remount.
This can leave us with cases where stripe < cluster_ratio after
remount:set making EXT4_B2C(sbi->s_stripe) become 0 that can cause some
unforeseen bugs like divide by 0.
Fix that by adding the check in remount path as well.
Additionally, change the users of EXT4_B2C(sbi->s_stripe) to
EXT4_NUM_B2C() so that if we ever accidentally hit this again, we can
avoid the value becoming 0. This should not change existing functionality.
Reported-by: syzbot+1ad8bac5af24d01e2cbd@syzkaller.appspotmail.com
Tested-by: syzbot+1ad8bac5af24d01e2cbd@syzkaller.appspotmail.com
Fixes: c3defd99d58c ("ext4: treat stripe in block unit")
Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
---
fs/ext4/super.c | 29 ++++++++++++++++++++++-------
1 file changed, 22 insertions(+), 7 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index e72145c4ae5a..9d495d78d262 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -5165,6 +5165,18 @@ static int ext4_block_group_meta_init(struct super_block *sb, int silent)
return 0;
}
+/*
+ * It's hard to get stripe aligned blocks if stripe is not aligned with
+ * cluster, just disable stripe and alert user to simpfy code and avoid
+ * stripe aligned allocation which will rarely successes.
+ */
+static bool ext4_is_stripe_incompatible(struct super_block *sb, unsigned long stripe)
+{
+ struct ext4_sb_info *sbi = EXT4_SB(sb);
+ return (stripe > 0 && sbi->s_cluster_ratio > 1 &&
+ stripe % sbi->s_cluster_ratio != 0);
+}
+
static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb)
{
struct ext4_super_block *es = NULL;
@@ -5272,13 +5284,7 @@ static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb)
goto failed_mount3;
sbi->s_stripe = ext4_get_stripe_size(sbi);
- /*
- * It's hard to get stripe aligned blocks if stripe is not aligned with
- * cluster, just disable stripe and alert user to simpfy code and avoid
- * stripe aligned allocation which will rarely successes.
- */
- if (sbi->s_stripe > 0 && sbi->s_cluster_ratio > 1 &&
- sbi->s_stripe % sbi->s_cluster_ratio != 0) {
+ if (ext4_is_stripe_incompatible(sb, sbi->s_stripe)) {
ext4_msg(sb, KERN_WARNING,
"stripe (%lu) is not aligned with cluster size (%u), "
"stripe is disabled",
@@ -6441,6 +6447,15 @@ static int __ext4_remount(struct fs_context *fc, struct super_block *sb)
}
+ if ((ctx->spec & EXT4_SPEC_s_stripe) &&
+ ext4_is_stripe_incompatible(sb, ctx->s_stripe)) {
+ ext4_msg(sb, KERN_WARNING,
+ "stripe (%lu) is not aligned with cluster size (%u), "
+ "stripe is disabled",
+ ctx->s_stripe, sbi->s_cluster_ratio);
+ ctx->s_stripe = 0;
+ }
+
/*
* Changing the DIOREAD_NOLOCK or DELALLOC mount options may cause
* two calls to ext4_should_dioread_nolock() to return inconsistent
--
2.43.5
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] ext4: Convert EXT4_B2C(sbi->s_stripe) users to EXT4_NUM_B2C
2024-08-16 7:57 [PATCH 1/2] ext4: Check stripe size compatibility on remount as well Ojaswin Mujoo
@ 2024-08-16 7:57 ` Ojaswin Mujoo
2024-08-19 12:51 ` Kemeng Shi
2024-08-19 12:31 ` [PATCH 1/2] ext4: Check stripe size compatibility on remount as well Kemeng Shi
1 sibling, 1 reply; 6+ messages in thread
From: Ojaswin Mujoo @ 2024-08-16 7:57 UTC (permalink / raw)
To: linux-ext4, Theodore Ts'o; +Cc: Ritesh Harjani, linux-kernel, Kemeng Shi
Although we have checks to make sure s_stripe is a multiple of cluster
size, in case we accidentally end up with a scenario where this is not
the case, use EXT4_NUM_B2C() so that we don't end up with unexpected
cases where EXT4_B2C(stripe) becomes 0.
Also make the is_stripe_aligned check in regular_allocator a bit more
robust while we are at it. This should ideally have no functional change
unless we have a bug somewhere causing (stripe % cluster_size != 0)
Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
---
fs/ext4/mballoc.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 9dda9cd68ab2..b2e836a4bd18 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -2553,7 +2553,7 @@ void ext4_mb_scan_aligned(struct ext4_allocation_context *ac,
do_div(a, sbi->s_stripe);
i = (a * sbi->s_stripe) - first_group_block;
- stripe = EXT4_B2C(sbi, sbi->s_stripe);
+ stripe = EXT4_NUM_B2C(sbi, sbi->s_stripe);
i = EXT4_B2C(sbi, i);
while (i < EXT4_CLUSTERS_PER_GROUP(sb)) {
if (!mb_test_bit(i, bitmap)) {
@@ -2929,8 +2929,9 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac)
ext4_mb_simple_scan_group(ac, &e4b);
else {
bool is_stripe_aligned = sbi->s_stripe &&
+ sbi->s_stripe >= sbi->s_cluster_ratio &&
!(ac->ac_g_ex.fe_len %
- EXT4_B2C(sbi, sbi->s_stripe));
+ EXT4_NUM_B2C(sbi, sbi->s_stripe));
if ((cr == CR_GOAL_LEN_FAST ||
cr == CR_BEST_AVAIL_LEN) &&
@@ -3707,7 +3708,7 @@ int ext4_mb_init(struct super_block *sb)
*/
if (sbi->s_stripe > 1) {
sbi->s_mb_group_prealloc = roundup(
- sbi->s_mb_group_prealloc, EXT4_B2C(sbi, sbi->s_stripe));
+ sbi->s_mb_group_prealloc, EXT4_NUM_B2C(sbi, sbi->s_stripe));
}
sbi->s_locality_groups = alloc_percpu(struct ext4_locality_group);
--
2.43.5
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ext4: Check stripe size compatibility on remount as well
2024-08-16 7:57 [PATCH 1/2] ext4: Check stripe size compatibility on remount as well Ojaswin Mujoo
2024-08-16 7:57 ` [PATCH 2/2] ext4: Convert EXT4_B2C(sbi->s_stripe) users to EXT4_NUM_B2C Ojaswin Mujoo
@ 2024-08-19 12:31 ` Kemeng Shi
2024-08-20 6:30 ` Ojaswin Mujoo
1 sibling, 1 reply; 6+ messages in thread
From: Kemeng Shi @ 2024-08-19 12:31 UTC (permalink / raw)
To: Ojaswin Mujoo, linux-ext4, Theodore Ts'o
Cc: Ritesh Harjani, linux-kernel, syzbot+1ad8bac5af24d01e2cbd
on 8/16/2024 3:57 PM, Ojaswin Mujoo wrote:
> We disable stripe size in __ext4_fill_super if it is not a multiple of
> the cluster ratio however this check is missed when trying to remount.
> This can leave us with cases where stripe < cluster_ratio after
> remount:set making EXT4_B2C(sbi->s_stripe) become 0 that can cause some
> unforeseen bugs like divide by 0.
>
> Fix that by adding the check in remount path as well.
>
> Additionally, change the users of EXT4_B2C(sbi->s_stripe) to
> EXT4_NUM_B2C() so that if we ever accidentally hit this again, we can
> avoid the value becoming 0. This should not change existing functionality.
It's better to mention this change is in following patch or simply remove
it from this patch.
Other than that, looks good to me. Feel free to add:
Reviewed-by: Kemeng Shi <shikemeng@huaweicloud.com>
>
> Reported-by: syzbot+1ad8bac5af24d01e2cbd@syzkaller.appspotmail.com
> Tested-by: syzbot+1ad8bac5af24d01e2cbd@syzkaller.appspotmail.com
> Fixes: c3defd99d58c ("ext4: treat stripe in block unit")
> Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
> ---
> fs/ext4/super.c | 29 ++++++++++++++++++++++-------
> 1 file changed, 22 insertions(+), 7 deletions(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index e72145c4ae5a..9d495d78d262 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -5165,6 +5165,18 @@ static int ext4_block_group_meta_init(struct super_block *sb, int silent)
> return 0;
> }
>
> +/*
> + * It's hard to get stripe aligned blocks if stripe is not aligned with
> + * cluster, just disable stripe and alert user to simpfy code and avoid
> + * stripe aligned allocation which will rarely successes.
> + */
> +static bool ext4_is_stripe_incompatible(struct super_block *sb, unsigned long stripe)
> +{
> + struct ext4_sb_info *sbi = EXT4_SB(sb);
> + return (stripe > 0 && sbi->s_cluster_ratio > 1 &&
> + stripe % sbi->s_cluster_ratio != 0);
> +}
> +
> static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb)
> {
> struct ext4_super_block *es = NULL;
> @@ -5272,13 +5284,7 @@ static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb)
> goto failed_mount3;
>
> sbi->s_stripe = ext4_get_stripe_size(sbi);
> - /*
> - * It's hard to get stripe aligned blocks if stripe is not aligned with
> - * cluster, just disable stripe and alert user to simpfy code and avoid
> - * stripe aligned allocation which will rarely successes.
> - */
> - if (sbi->s_stripe > 0 && sbi->s_cluster_ratio > 1 &&
> - sbi->s_stripe % sbi->s_cluster_ratio != 0) {
> + if (ext4_is_stripe_incompatible(sb, sbi->s_stripe)) {
> ext4_msg(sb, KERN_WARNING,
> "stripe (%lu) is not aligned with cluster size (%u), "
> "stripe is disabled",
> @@ -6441,6 +6447,15 @@ static int __ext4_remount(struct fs_context *fc, struct super_block *sb)
>
> }
>
> + if ((ctx->spec & EXT4_SPEC_s_stripe) &&
> + ext4_is_stripe_incompatible(sb, ctx->s_stripe)) {
> + ext4_msg(sb, KERN_WARNING,
> + "stripe (%lu) is not aligned with cluster size (%u), "
> + "stripe is disabled",
> + ctx->s_stripe, sbi->s_cluster_ratio);
> + ctx->s_stripe = 0;
> + }
> +
> /*
> * Changing the DIOREAD_NOLOCK or DELALLOC mount options may cause
> * two calls to ext4_should_dioread_nolock() to return inconsistent
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] ext4: Convert EXT4_B2C(sbi->s_stripe) users to EXT4_NUM_B2C
2024-08-16 7:57 ` [PATCH 2/2] ext4: Convert EXT4_B2C(sbi->s_stripe) users to EXT4_NUM_B2C Ojaswin Mujoo
@ 2024-08-19 12:51 ` Kemeng Shi
2024-08-20 6:29 ` Ojaswin Mujoo
0 siblings, 1 reply; 6+ messages in thread
From: Kemeng Shi @ 2024-08-19 12:51 UTC (permalink / raw)
To: Ojaswin Mujoo, linux-ext4, Theodore Ts'o; +Cc: Ritesh Harjani, linux-kernel
on 8/16/2024 3:57 PM, Ojaswin Mujoo wrote:
> Although we have checks to make sure s_stripe is a multiple of cluster
> size, in case we accidentally end up with a scenario where this is not
> the case, use EXT4_NUM_B2C() so that we don't end up with unexpected
> cases where EXT4_B2C(stripe) becomes 0.
>
> Also make the is_stripe_aligned check in regular_allocator a bit more
> robust while we are at it. This should ideally have no functional change
> unless we have a bug somewhere causing (stripe % cluster_size != 0)
>
> Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>> ---
> fs/ext4/mballoc.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 9dda9cd68ab2..b2e836a4bd18 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -2553,7 +2553,7 @@ void ext4_mb_scan_aligned(struct ext4_allocation_context *ac,
> do_div(a, sbi->s_stripe);
> i = (a * sbi->s_stripe) - first_group_block;
>
> - stripe = EXT4_B2C(sbi, sbi->s_stripe);
> + stripe = EXT4_NUM_B2C(sbi, sbi->s_stripe);
> i = EXT4_B2C(sbi, i);
> while (i < EXT4_CLUSTERS_PER_GROUP(sb)) {
> if (!mb_test_bit(i, bitmap)) {
> @@ -2929,8 +2929,9 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac)
> ext4_mb_simple_scan_group(ac, &e4b);
> else {
> bool is_stripe_aligned = sbi->s_stripe &&
> + sbi->s_stripe >= sbi->s_cluster_ratio &&
sbi->s_cluster_ratio is >= 1, so sbi->s_stripe >= sbi->s_cluster_ratio could
cover the case that sbi->s_stripe is non-zero. Non-zero check of sbi->s_stripe
seems not needed.
> !(ac->ac_g_ex.fe_len %
> - EXT4_B2C(sbi, sbi->s_stripe));
> + EXT4_NUM_B2C(sbi, sbi->s_stripe));
>
> if ((cr == CR_GOAL_LEN_FAST ||
> cr == CR_BEST_AVAIL_LEN) &&
> @@ -3707,7 +3708,7 @@ int ext4_mb_init(struct super_block *sb)
> */
> if (sbi->s_stripe > 1) {
> sbi->s_mb_group_prealloc = roundup(
> - sbi->s_mb_group_prealloc, EXT4_B2C(sbi, sbi->s_stripe));
> + sbi->s_mb_group_prealloc, EXT4_NUM_B2C(sbi, sbi->s_stripe));
> }
>
> sbi->s_locality_groups = alloc_percpu(struct ext4_locality_group);
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] ext4: Convert EXT4_B2C(sbi->s_stripe) users to EXT4_NUM_B2C
2024-08-19 12:51 ` Kemeng Shi
@ 2024-08-20 6:29 ` Ojaswin Mujoo
0 siblings, 0 replies; 6+ messages in thread
From: Ojaswin Mujoo @ 2024-08-20 6:29 UTC (permalink / raw)
To: Kemeng Shi; +Cc: linux-ext4, Theodore Ts'o, Ritesh Harjani, linux-kernel
On Mon, Aug 19, 2024 at 08:51:58PM +0800, Kemeng Shi wrote:
>
>
> on 8/16/2024 3:57 PM, Ojaswin Mujoo wrote:
> > Although we have checks to make sure s_stripe is a multiple of cluster
> > size, in case we accidentally end up with a scenario where this is not
> > the case, use EXT4_NUM_B2C() so that we don't end up with unexpected
> > cases where EXT4_B2C(stripe) becomes 0.
> >
> > Also make the is_stripe_aligned check in regular_allocator a bit more
> > robust while we are at it. This should ideally have no functional change
> > unless we have a bug somewhere causing (stripe % cluster_size != 0)
> >
> > Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>> ---
> > fs/ext4/mballoc.c | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> > index 9dda9cd68ab2..b2e836a4bd18 100644
> > --- a/fs/ext4/mballoc.c
> > +++ b/fs/ext4/mballoc.c
> > @@ -2553,7 +2553,7 @@ void ext4_mb_scan_aligned(struct ext4_allocation_context *ac,
> > do_div(a, sbi->s_stripe);
> > i = (a * sbi->s_stripe) - first_group_block;
> >
> > - stripe = EXT4_B2C(sbi, sbi->s_stripe);
> > + stripe = EXT4_NUM_B2C(sbi, sbi->s_stripe);
> > i = EXT4_B2C(sbi, i);
> > while (i < EXT4_CLUSTERS_PER_GROUP(sb)) {
> > if (!mb_test_bit(i, bitmap)) {
> > @@ -2929,8 +2929,9 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac)
> > ext4_mb_simple_scan_group(ac, &e4b);
> > else {
> > bool is_stripe_aligned = sbi->s_stripe &&
> > + sbi->s_stripe >= sbi->s_cluster_ratio &&
> sbi->s_cluster_ratio is >= 1, so sbi->s_stripe >= sbi->s_cluster_ratio could
> cover the case that sbi->s_stripe is non-zero. Non-zero check of sbi->s_stripe
> seems not needed.
That makes sense Kemeng, I'll send a v2 with this change.
Thanks,
ojaswin
> > !(ac->ac_g_ex.fe_len %
> > - EXT4_B2C(sbi, sbi->s_stripe));
> > + EXT4_NUM_B2C(sbi, sbi->s_stripe));
> >
> > if ((cr == CR_GOAL_LEN_FAST ||
> > cr == CR_BEST_AVAIL_LEN) &&
> > @@ -3707,7 +3708,7 @@ int ext4_mb_init(struct super_block *sb)
> > */
> > if (sbi->s_stripe > 1) {
> > sbi->s_mb_group_prealloc = roundup(
> > - sbi->s_mb_group_prealloc, EXT4_B2C(sbi, sbi->s_stripe));
> > + sbi->s_mb_group_prealloc, EXT4_NUM_B2C(sbi, sbi->s_stripe));
> > }
> >
> > sbi->s_locality_groups = alloc_percpu(struct ext4_locality_group);
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ext4: Check stripe size compatibility on remount as well
2024-08-19 12:31 ` [PATCH 1/2] ext4: Check stripe size compatibility on remount as well Kemeng Shi
@ 2024-08-20 6:30 ` Ojaswin Mujoo
0 siblings, 0 replies; 6+ messages in thread
From: Ojaswin Mujoo @ 2024-08-20 6:30 UTC (permalink / raw)
To: Kemeng Shi
Cc: linux-ext4, Theodore Ts'o, Ritesh Harjani, linux-kernel,
syzbot+1ad8bac5af24d01e2cbd
On Mon, Aug 19, 2024 at 08:31:26PM +0800, Kemeng Shi wrote:
>
>
> on 8/16/2024 3:57 PM, Ojaswin Mujoo wrote:
> > We disable stripe size in __ext4_fill_super if it is not a multiple of
> > the cluster ratio however this check is missed when trying to remount.
> > This can leave us with cases where stripe < cluster_ratio after
> > remount:set making EXT4_B2C(sbi->s_stripe) become 0 that can cause some
> > unforeseen bugs like divide by 0.
> >
> > Fix that by adding the check in remount path as well.
> >
> > Additionally, change the users of EXT4_B2C(sbi->s_stripe) to
> > EXT4_NUM_B2C() so that if we ever accidentally hit this again, we can
> > avoid the value becoming 0. This should not change existing functionality.
> It's better to mention this change is in following patch or simply remove
> it from this patch.
Oh yes you are right, I accidentally left it here. I'll fix it.
>
> Other than that, looks good to me. Feel free to add:
>
> Reviewed-by: Kemeng Shi <shikemeng@huaweicloud.com>
Thanks for the review!
Regards,
Ojaswin
> >
> > Reported-by: syzbot+1ad8bac5af24d01e2cbd@syzkaller.appspotmail.com
> > Tested-by: syzbot+1ad8bac5af24d01e2cbd@syzkaller.appspotmail.com
> > Fixes: c3defd99d58c ("ext4: treat stripe in block unit")
> > Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
> > ---
> > fs/ext4/super.c | 29 ++++++++++++++++++++++-------
> > 1 file changed, 22 insertions(+), 7 deletions(-)
> >
> > diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> > index e72145c4ae5a..9d495d78d262 100644
> > --- a/fs/ext4/super.c
> > +++ b/fs/ext4/super.c
> > @@ -5165,6 +5165,18 @@ static int ext4_block_group_meta_init(struct super_block *sb, int silent)
> > return 0;
> > }
> >
> > +/*
> > + * It's hard to get stripe aligned blocks if stripe is not aligned with
> > + * cluster, just disable stripe and alert user to simpfy code and avoid
> > + * stripe aligned allocation which will rarely successes.
> > + */
> > +static bool ext4_is_stripe_incompatible(struct super_block *sb, unsigned long stripe)
> > +{
> > + struct ext4_sb_info *sbi = EXT4_SB(sb);
> > + return (stripe > 0 && sbi->s_cluster_ratio > 1 &&
> > + stripe % sbi->s_cluster_ratio != 0);
> > +}
> > +
> > static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb)
> > {
> > struct ext4_super_block *es = NULL;
> > @@ -5272,13 +5284,7 @@ static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb)
> > goto failed_mount3;
> >
> > sbi->s_stripe = ext4_get_stripe_size(sbi);
> > - /*
> > - * It's hard to get stripe aligned blocks if stripe is not aligned with
> > - * cluster, just disable stripe and alert user to simpfy code and avoid
> > - * stripe aligned allocation which will rarely successes.
> > - */
> > - if (sbi->s_stripe > 0 && sbi->s_cluster_ratio > 1 &&
> > - sbi->s_stripe % sbi->s_cluster_ratio != 0) {
> > + if (ext4_is_stripe_incompatible(sb, sbi->s_stripe)) {
> > ext4_msg(sb, KERN_WARNING,
> > "stripe (%lu) is not aligned with cluster size (%u), "
> > "stripe is disabled",
> > @@ -6441,6 +6447,15 @@ static int __ext4_remount(struct fs_context *fc, struct super_block *sb)
> >
> > }
> >
> > + if ((ctx->spec & EXT4_SPEC_s_stripe) &&
> > + ext4_is_stripe_incompatible(sb, ctx->s_stripe)) {
> > + ext4_msg(sb, KERN_WARNING,
> > + "stripe (%lu) is not aligned with cluster size (%u), "
> > + "stripe is disabled",
> > + ctx->s_stripe, sbi->s_cluster_ratio);
> > + ctx->s_stripe = 0;
> > + }
> > +
> > /*
> > * Changing the DIOREAD_NOLOCK or DELALLOC mount options may cause
> > * two calls to ext4_should_dioread_nolock() to return inconsistent
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-08-20 6:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-16 7:57 [PATCH 1/2] ext4: Check stripe size compatibility on remount as well Ojaswin Mujoo
2024-08-16 7:57 ` [PATCH 2/2] ext4: Convert EXT4_B2C(sbi->s_stripe) users to EXT4_NUM_B2C Ojaswin Mujoo
2024-08-19 12:51 ` Kemeng Shi
2024-08-20 6:29 ` Ojaswin Mujoo
2024-08-19 12:31 ` [PATCH 1/2] ext4: Check stripe size compatibility on remount as well Kemeng Shi
2024-08-20 6:30 ` Ojaswin Mujoo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®