From: "Jason Zebchuk" <jason@consensys.com>
To: unlisted-recipients:; (no To-header on input)
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH] pci_do_scan_bus - 2.5.31
Date: Mon, 19 Aug 2002 12:56:17 -0400 [thread overview]
Message-ID: <030701c247a1$55d19320$4902a8c0@consensys.com> (raw)
Hi,
I've found a small problem in the patch I submitted last week to fix
pci_do_scan_bus. The pci_dev that was allocated was not properly
initialised and this could cause any number of problems with booting.
I've fixed that problem, and I also changed the BUG() to a panic() as
per Andi Kleen's suggestion.
Jason Zebchuk
Consensys RAIDZONE
--- linux-2.5.31/drivers/pci/probe.c Tue Aug 6 12:40:20 2002
+++ linux/drivers/pci/probe.c Mon Aug 19 09:41:43 2002
@@ -505,8 +505,8 @@
/* Create a device template */
dev0 = kmalloc(sizeof(struct pci_dev), GFP_ATOMIC);
if (dev0 == NULL)
- BUG();
- memset(dev0, 0, sizeof(dev0));
+ panic("Unable to allocate pci_dev!");
+ memset(dev0, 0, sizeof(*dev0));
dev0->bus = bus;
dev0->sysdata = bus->sysdata;
dev0->dev.parent = bus->dev;
reply other threads:[~2002-08-19 16:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='030701c247a1$55d19320$4902a8c0@consensys.com' \
--to=jason@consensys.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®