mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] pci_do_scan_bus - 2.5.31
@ 2002-08-19 16:56 Jason Zebchuk
  0 siblings, 0 replies; only message in thread
From: Jason Zebchuk @ 2002-08-19 16:56 UTC (permalink / raw)
  Cc: linux-kernel

Hi,

    I've found a small problem in the patch I submitted last week to fix
pci_do_scan_bus.  The pci_dev that was allocated was not properly
initialised and this could cause any number of problems with booting.

    I've fixed that problem, and I also changed the BUG() to a panic() as
per Andi Kleen's suggestion.


Jason Zebchuk
Consensys RAIDZONE


--- linux-2.5.31/drivers/pci/probe.c    Tue Aug  6 12:40:20 2002
+++ linux/drivers/pci/probe.c   Mon Aug 19 09:41:43 2002
@@ -505,8 +505,8 @@
        /* Create a device template */
        dev0 = kmalloc(sizeof(struct pci_dev), GFP_ATOMIC);
        if (dev0 == NULL)
-               BUG();
-       memset(dev0, 0, sizeof(dev0));
+               panic("Unable to allocate pci_dev!");
+       memset(dev0, 0, sizeof(*dev0));
        dev0->bus = bus;
        dev0->sysdata = bus->sysdata;
        dev0->dev.parent = bus->dev;


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2002-08-19 16:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-08-19 16:56 [PATCH] pci_do_scan_bus - 2.5.31 Jason Zebchuk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®