From: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux@armlinux.org.uk, vadim.fedorenko@linux.dev,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, git@amd.com
Subject: Re: [PATCH net-next v2 2/4] net: macb: Add ARP support to WOL
Date: Fri, 23 Feb 2024 10:16:26 +0530 [thread overview]
Message-ID: <03499bd0-323d-4f57-99a8-d47c5ae680ae@amd.com> (raw)
In-Reply-To: <8e4a779a-22e7-4db2-b65e-69cca5e6fac5@lunn.ch>
Hi Andrew,
On 23/02/24 1:02 am, Andrew Lunn wrote:
>> u32 wol;
>> + u32 wolopts;
>
>> + wol->supported |= (bp->wol & MACB_WOL_HAS_MAGIC_PACKET) ? WAKE_MAGIC : 0;
>> + wol->supported |= (bp->wol & MACB_WOL_HAS_ARP_PACKET) ? WAKE_ARP : 0;
>
>> + if (bp->caps & MACB_CAPS_WOL)
>> + bp->wol |= (MACB_WOL_HAS_ARP_PACKET | MACB_WOL_HAS_MAGIC_PACKET);
>
> So bp->wol is the capabilities of the hardware?
>
Yes, it holds the supported capabilities.
> And bp->wolopts is what has been enabled via ethtool?
>
Yes, it holds the selected options through ethtool.
> I just wounder if it would be easier to understand is bp->wol was
> renamed wol_caps, similar to bp->caps?
>
> Andrew
Sure, I will make the change.
🙏 vineeth
next prev parent reply other threads:[~2024-02-23 4:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 15:38 [PATCH net-next v2 0/4] net: macb: WOL enhancements Vineeth Karumanchi
2024-02-22 15:38 ` [PATCH net-next v2 1/4] net: macb: queue tie-off or disable during WOL suspend Vineeth Karumanchi
2024-02-22 15:38 ` [PATCH net-next v2 2/4] net: macb: Add ARP support to WOL Vineeth Karumanchi
2024-02-22 19:32 ` Andrew Lunn
2024-02-23 4:46 ` Vineeth Karumanchi [this message]
2024-03-28 9:05 ` claudiu beznea
2024-02-22 15:38 ` [PATCH net-next v2 3/4] net: macb: Enable queue disable and WOL Vineeth Karumanchi
2024-02-22 19:34 ` Andrew Lunn
2024-02-23 6:21 ` Vineeth Karumanchi
2024-02-23 13:26 ` Andrew Lunn
2024-02-27 5:04 ` Karumanchi, Vineeth
2024-03-05 14:45 ` Karumanchi, Vineeth
2024-02-22 15:38 ` [PATCH net-next v2 4/4] dt-bindings: net: cdns,macb: Deprecate magic-packet property Vineeth Karumanchi
2024-02-22 15:55 ` Krzysztof Kozlowski
2024-02-22 17:59 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03499bd0-323d-4f57-99a8-d47c5ae680ae@amd.com \
--to=vineeth.karumanchi@amd.com \
--cc=andrew@lunn.ch \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=git@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome