From: Andrew Lunn <andrew@lunn.ch>
To: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
Cc: nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux@armlinux.org.uk, vadim.fedorenko@linux.dev,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, git@amd.com
Subject: Re: [PATCH net-next v2 3/4] net: macb: Enable queue disable and WOL
Date: Fri, 23 Feb 2024 14:26:50 +0100 [thread overview]
Message-ID: <8c0efb9a-d92c-4b9b-be75-498d460f67bd@lunn.ch> (raw)
In-Reply-To: <78730bb7-4588-4038-9336-eec6e2635a75@amd.com>
> It is not specific to AMD versions. All Cadence GEM IP versions have the
> capability, but specific vendors might enable or disable it as per their
> requirements.
Do you mean it is an option to synthesizer it or not? So although the
basic IP licensed from Cadence has it, a silicon vendor could remove
it?
> WOL was previously enabled via the device-tree attribute. Some users might
> not leverage it.
This is not typical. If the hardware supports it, we let the end user
decided if they want to use it or not.
So if all silicon should have it, enable it everywhere. If there is an
option to save some gates and leave it out of the silicon, then we do
need some per device knowledge, or a register which tells us what the
synthesis options where.
Andrew
next prev parent reply other threads:[~2024-02-23 13:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 15:38 [PATCH net-next v2 0/4] net: macb: WOL enhancements Vineeth Karumanchi
2024-02-22 15:38 ` [PATCH net-next v2 1/4] net: macb: queue tie-off or disable during WOL suspend Vineeth Karumanchi
2024-02-22 15:38 ` [PATCH net-next v2 2/4] net: macb: Add ARP support to WOL Vineeth Karumanchi
2024-02-22 19:32 ` Andrew Lunn
2024-02-23 4:46 ` Vineeth Karumanchi
2024-03-28 9:05 ` claudiu beznea
2024-02-22 15:38 ` [PATCH net-next v2 3/4] net: macb: Enable queue disable and WOL Vineeth Karumanchi
2024-02-22 19:34 ` Andrew Lunn
2024-02-23 6:21 ` Vineeth Karumanchi
2024-02-23 13:26 ` Andrew Lunn [this message]
2024-02-27 5:04 ` Karumanchi, Vineeth
2024-03-05 14:45 ` Karumanchi, Vineeth
2024-02-22 15:38 ` [PATCH net-next v2 4/4] dt-bindings: net: cdns,macb: Deprecate magic-packet property Vineeth Karumanchi
2024-02-22 15:55 ` Krzysztof Kozlowski
2024-02-22 17:59 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c0efb9a-d92c-4b9b-be75-498d460f67bd@lunn.ch \
--to=andrew@lunn.ch \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=git@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=vadim.fedorenko@linux.dev \
--cc=vineeth.karumanchi@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®