From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: "'Michal Hocko'" <mhocko@kernel.org>,
"'Andrew Morton'" <akpm@linux-foundation.org>
Cc: "'Johannes Weiner'" <hannes@cmpxchg.org>,
"'Mel Gorman'" <mgorman@suse.de>,
"'Vlastimil Babka'" <vbabka@suse.cz>,
"'David Rientjes'" <rientjes@google.com>, <linux-mm@kvack.org>,
"'LKML'" <linux-kernel@vger.kernel.org>,
"'Michal Hocko'" <mhocko@suse.com>
Subject: Re: [PATCH 1/4] mm, page_alloc: do not report all nodes in show_mem
Date: Tue, 17 Jan 2017 17:30:32 +0800 [thread overview]
Message-ID: <034b01d270a4$5a0aa440$0e1fecc0$@alibaba-inc.com> (raw)
In-Reply-To: <20170117091543.25850-2-mhocko@kernel.org>
On Tuesday, January 17, 2017 5:16 PM Michal Hocko wrote:
>
> From: Michal Hocko <mhocko@suse.com>
>
> 599d0c954f91 ("mm, vmscan: move LRU lists to node") has added per numa
> node statistics to show_mem but it forgot to add skip_free_areas_node
> to fileter out nodes which are outside of the allocating task numa
> policy. Add this check to not pollute the output with the pointless
> information.
>
> Acked-by: Mel Gorman <mgorman@suse.de>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> Signed-off-by: Michal Hocko <mhocko@suse.com>
> ---
Acked-by: Hillf Danton <hillf.zj@alibaba-inc.com>
> mm/page_alloc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 8ff25883c172..8f4f306d804c 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -4345,6 +4345,9 @@ void show_free_areas(unsigned int filter)
> global_page_state(NR_FREE_CMA_PAGES));
>
> for_each_online_pgdat(pgdat) {
> + if (skip_free_areas_node(filter, pgdat->node_id))
> + continue;
> +
> printk("Node %d"
> " active_anon:%lukB"
> " inactive_anon:%lukB"
> --
> 2.11.0
next prev parent reply other threads:[~2017-01-17 9:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 9:15 [PATCH 0/4 v2] show_mem updates Michal Hocko
2017-01-17 9:15 ` [PATCH 1/4] mm, page_alloc: do not report all nodes in show_mem Michal Hocko
2017-01-17 9:30 ` Hillf Danton [this message]
2017-01-17 22:55 ` David Rientjes
2017-01-17 9:15 ` [PATCH 2/4] mm, page_alloc: warn_alloc print nodemask Michal Hocko
2017-01-17 9:32 ` Hillf Danton
2017-01-17 23:01 ` David Rientjes
2017-01-18 10:10 ` Michal Hocko
2017-01-17 9:15 ` [PATCH 3/4] arch, mm: remove arch specific show_mem Michal Hocko
2017-01-17 9:15 ` [PATCH 4/4] lib/show_mem.c: teach show_mem to work with the given nodemask Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='034b01d270a4$5a0aa440$0e1fecc0$@alibaba-inc.com' \
--to=hillf.zj@alibaba-inc.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome