mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Jonathan Corbet <corbet@lwn.net>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 3/4] hwmon: Add support for Amphenol ChipCap 2
Date: Thu, 9 Nov 2023 10:35:40 +0100	[thread overview]
Message-ID: <037f44d9-7240-4daf-9fe1-ac89fae9499c@linaro.org> (raw)
In-Reply-To: <f1c6efd3-fad1-453a-b922-41485495385b@gmail.com>

On 09/11/2023 09:59, Javier Carrasco wrote:
> 
> 
> On 09.11.23 09:40, Krzysztof Kozlowski wrote:
>> On 08/11/2023 17:35, Javier Carrasco wrote:
>>>>> +
>>>>> +	data->regulator = devm_regulator_get_optional(dev, "vdd");
>>>>> +	if (!IS_ERR(data->regulator)) {
>>>>> +		ret = cc2_retrive_alarm_config(data);
>>>>> +		if (ret)
>>>>> +			goto cleanup;
>>>>> +	} else {
>>>>> +		/* No access to EEPROM without regulator: no alarm control */
>>>>
>>>> Test your code with deferred probe. Are you sure you handle it
>>>> correctly? To me, it looks like you handle deferred probe the same as
>>>> any error.
>>>>
>>> The -EPROBE_DEFER is propagated to the probe function and it is the
>>> returned value. I clarified the error path in v2 so no error messages
>>
>> Really?
>>
>> I see:
>> if (!IS_ERR(data->regulator)) {
>> 	// so you do not go here
>> } else {
>> 	goto dev_register;
>> }
>> dev_register is not error path. So how do you return EPROBE_DEFER?
>>
>> Which line of code does it?
>>
> EPROBE_DEFER is returned if the command window was missed, which is

How "command window was missed" is related to the place I commented?

> checked in cc2_retrieve_alarm_config() (there is a typo I just corrected
> -> cc2_retrive_alarm_config() in the current version). It could then
> happen where you added a comment, but not because
> devm_regulator_get_optional() failed.
> 
> Are you expecting a probe deferring if devm_regulator_get_optional()
> fails as well? Like if the regulator is still not ready when the
> function is called.

We talk only about this place. Not others.


Best regards,
Krzysztof


  reply	other threads:[~2023-11-09  9:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-08 12:29 [PATCH 0/4] " Javier Carrasco
2023-11-08 12:29 ` [PATCH 1/4] dt-bindings: vendor-prefixes: add Amphenol Javier Carrasco
2023-11-08 12:31   ` Krzysztof Kozlowski
2023-11-08 12:29 ` [PATCH 2/4] hwmon: (core) Add support for humidity min/max alarm Javier Carrasco
2023-11-08 12:29 ` [PATCH 3/4] hwmon: Add support for Amphenol ChipCap 2 Javier Carrasco
2023-11-08 12:41   ` Krzysztof Kozlowski
2023-11-08 16:35     ` Javier Carrasco
2023-11-09  8:40       ` Krzysztof Kozlowski
2023-11-09  8:59         ` Javier Carrasco
2023-11-09  9:35           ` Krzysztof Kozlowski [this message]
2023-11-09  9:52             ` Javier Carrasco
2023-11-09 10:23               ` Krzysztof Kozlowski
2023-11-08 12:29 ` [PATCH 4/4] dt-bindings: hwmon: Add " Javier Carrasco
2023-11-08 12:34   ` Krzysztof Kozlowski
2023-11-08 12:44     ` Javier Carrasco
2023-11-09  8:41       ` Krzysztof Kozlowski
2023-11-09 14:47         ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=037f44d9-7240-4daf-9fe1-ac89fae9499c@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®