Re: [PATCH v2 0/4] Document ASUS RT-AC3200 and ASUS RT-AC5300 and add device trees

["Rafał Miłecki" <zajec5@gmail.com>]

Hi,

On 19.04.2024 09:22, Arınç ÜNAL via B4 Relay wrote:
> This patch series documents the compatible strings for ASUS RT-AC3200 and
> ASUS RT-AC5300, and adds the device trees for them.

I was on holidays and couldn't reply earlier.

This patchset looks good to me, thanks for your work!

Bot warnings come from .dtsi so they are not directly caused by your changes.

Nitpicking:
Try to put "reg" before "device_type" in future.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst?h=v6.8#n112


> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
> Changes in v2:
> - Patch 3
>    - Remove the chosen node as earlycon is not for mainline use, and the
>      stdout-path property which should be used instead of bootargs =
>      "console=" is already described in bcm4708.dtsi with the same value.
>    - Remove MAC address assignment to switch ports. To explain why shortly,
>      on the switch with CPU port architecture, the LLC Entity associated
>      with each port can be accessed without a distinct MAC address assigned
>      to each port. Therefore, it is unnecessary.
> - Patch 4
>    - Same as above.
> - Link to v1: https://lore.kernel.org/r/20240414-for-soc-asus-rt-ac3200-ac5300-v1-0-118c90bae6e5@arinc9.com
> 
> ---
> Arınç ÜNAL (4):
>        dt-bindings: arm: bcm: add bindings for ASUS RT-AC3200
>        dt-bindings: arm: bcm: add bindings for ASUS RT-AC5300
>        ARM: dts: BCM5301X: Add DT for ASUS RT-AC3200
>        ARM: dts: BCM5301X: Add DT for ASUS RT-AC5300
> 
>   .../devicetree/bindings/arm/bcm/brcm,bcm4708.yaml  |   2 +
>   arch/arm/boot/dts/broadcom/Makefile                |   2 +
>   .../boot/dts/broadcom/bcm4709-asus-rt-ac3200.dts   | 150 ++++++++++++++++++++
>   .../boot/dts/broadcom/bcm47094-asus-rt-ac5300.dts  | 156 +++++++++++++++++++++
>   4 files changed, 310 insertions(+)
> ---
> base-commit: 011d79ef1cfad701c2d8e7e80d8c77523af9c771
> change-id: 20240408-for-soc-asus-rt-ac3200-ac5300-5d6efc2c497b
> 
> Best regards,