From: "Arınç ÜNAL" <arinc.unal@arinc9.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>
Cc: Tom Brautaset <tbrautaset@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH v2 0/4] Document ASUS RT-AC3200 and ASUS RT-AC5300 and add device trees
Date: Tue, 23 Apr 2024 10:03:38 +0300 [thread overview]
Message-ID: <c59348dc-2f14-4d09-9ab9-36d1c25408f4@arinc9.com> (raw)
In-Reply-To: <0395c3a1-1211-4962-bafd-fbf20be98ce4@gmail.com>
On 23/04/2024 09:24, Rafał Miłecki wrote:
> Hi,
>
> On 19.04.2024 09:22, Arınç ÜNAL via B4 Relay wrote:
>> This patch series documents the compatible strings for ASUS RT-AC3200 and
>> ASUS RT-AC5300, and adds the device trees for them.
>
> I was on holidays and couldn't reply earlier.
>
> This patchset looks good to me, thanks for your work!
>
> Bot warnings come from .dtsi so they are not directly caused by your changes.
>
> Nitpicking:
> Try to put "reg" before "device_type" in future.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst?h=v6.8#n112
I'll address this in v3, thank you.
Arınç
prev parent reply other threads:[~2024-04-23 7:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240419-for-soc-asus-rt-ac3200-ac5300-v2-0-f95ff50c2a4d@arinc9.com>
2024-04-19 7:22 ` [PATCH v2 1/4] dt-bindings: arm: bcm: add bindings for ASUS RT-AC3200 Arınç ÜNAL via B4 Relay
2024-04-19 7:22 ` [PATCH v2 2/4] dt-bindings: arm: bcm: add bindings for ASUS RT-AC5300 Arınç ÜNAL via B4 Relay
2024-04-19 7:22 ` [PATCH v2 3/4] ARM: dts: BCM5301X: Add DT for ASUS RT-AC3200 Arınç ÜNAL via B4 Relay
2024-04-19 7:22 ` [PATCH v2 4/4] ARM: dts: BCM5301X: Add DT for ASUS RT-AC5300 Arınç ÜNAL via B4 Relay
2024-04-19 22:24 ` [PATCH v2 0/4] Document ASUS RT-AC3200 and ASUS RT-AC5300 and add device trees Rob Herring
2024-04-23 6:24 ` Rafał Miłecki
2024-04-23 7:03 ` Arınç ÜNAL [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c59348dc-2f14-4d09-9ab9-36d1c25408f4@arinc9.com \
--to=arinc.unal@arinc9.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=hauke@hauke-m.de \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tbrautaset@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®