* Re: [PATCH] mm: migrate: remove unused parameter in migrate_vma_insert_page()
[not found] <CANubcdUwCAMuUyamG2dkWP=cqSR9MAS=tHLDc95kQkqU-rEnAg@mail.gmail.com>
@ 2020-12-04 13:02 ` David Hildenbrand
0 siblings, 0 replies; only message in thread
From: David Hildenbrand @ 2020-12-04 13:02 UTC (permalink / raw)
To: Lee Bruce, akpm; +Cc: linux-mm, linux-kernel
On 04.12.20 12:54, Lee Bruce wrote:
> From 810f69c5438c66aafccf18ba8f43b99b64b85237 Mon Sep 17 00:00:00 2001
> From: Stephen Zhang <starzhangzsd@gmail.com <mailto:starzhangzsd@gmail.com>>
> Date: Fri, 4 Dec 2020 16:32:38 +0800
> Subject: [PATCH] mm: migrate: remove unused parameter in
> migrate_vma_insert_page()
>
> "dst" parameter to migrate_vma_insert_page() is not used anymore.
>
> Signed-off-by: Stephen Zhang <starzhangzsd@gmail.com
> <mailto:starzhangzsd@gmail.com>>
> ---
> mm/migrate.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/mm/migrate.c b/mm/migrate.c
> index 4385f2f..ee5e612 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -2894,8 +2894,7 @@ int migrate_vma_setup(struct migrate_vma *args)
> static void migrate_vma_insert_page(struct migrate_vma *migrate,
> unsigned long addr,
> struct page *page,
> - unsigned long *src,
> - unsigned long *dst)
> + unsigned long *src)
> {
> struct vm_area_struct *vma = migrate->vma;
> struct mm_struct *mm = vma->vm_mm;
> @@ -3056,8 +3055,7 @@ void migrate_vma_pages(struct migrate_vma *migrate)
> mmu_notifier_invalidate_range_start(&range);
> }
> migrate_vma_insert_page(migrate, addr, newpage,
> - &migrate->src[i],
> - &migrate->dst[i]);
> + &migrate->src[i]);
> continue;
> }
>
> --
> 1.8.3.1
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] only message in thread