From: John Garry <john.garry@huawei.com>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
Zhengjun Xing <zhengjun.xing@linux.intel.com>,
"Felix Fietkau" <nbd@nbd.name>, Qi Liu <liuqi115@huawei.com>,
Like Xu <likexu@tencent.com>, <linux-kernel@vger.kernel.org>,
<linux-perf-users@vger.kernel.org>,
Nick Forrington <nick.forrington@arm.com>,
Kajol Jain <kjain@linux.ibm.com>,
James Clark <james.clark@arm.com>,
Andrew Kilroy <andrew.kilroy@arm.com>,
"Paul A . Clarke" <pc@us.ibm.com>, Will Deacon <will@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
<ananth.narayan@amd.com>, <ravi.bangoria@amd.com>,
<santosh.shukla@amd.com>, <sandipan.das@amd.com>,
Caleb Biggers <caleb.biggers@intel.com>,
Perry Taylor <perry.taylor@intel.com>,
Kshipra Bopardikar <kshipra.bopardikar@intel.com>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v6 0/4] Rewrite jevents program in python
Date: Wed, 29 Jun 2022 17:50:17 +0100 [thread overview]
Message-ID: <03cab2a6-0217-d688-8c86-5fd58e847dde@huawei.com> (raw)
In-Reply-To: <CAP-5=fVxc7H75mb=j23gTD-eMYD3vru5U9QFGQDmODb57aykPA@mail.gmail.com>
On 29/06/2022 17:47, Ian Rogers wrote:
> On Mon, Jun 27, 2022 at 10:27 AM John Garry <john.garry@huawei.com> wrote:
>>
>> On 27/06/2022 03:57, Ian Rogers wrote:
>>> A challenge with this code is in avoiding regressions. For this reason
>>> the jevents.py produces identical output to jevents.c, validated with a
>>> test script and build target.
>>>
>>> v6. Adds Tested-by from Zhengjun Xing<zhengjun.xing@linux.intel.com>
>>> and Thomas Richter<tmricht@linux.ibm.com>. Fixes issues spotted
>>> by Jiri Olsa<jolsa@kernel.org>, jsmn.c wasn't deleted and the
>>> empty pmu-events.c didn't pass the pmu-events test. It also adds a
>>> missing mkdir which is necessary before creating pmu-events.c and
>>> tweaks the quiet display code in the empty case to display a gen.
>>> v5. Adds a 2>/dev/null as suggested by David Laight
>>
>>
>> Hmmm... shouldn't this be v7? Anyway what I got with message-id
>> 20220627025744.106527-1-irogers@google.com now seems to build and the
>> output looks ok.
>>
>> Thanks,
>> John
>
> Thanks John, I think I've confused myself by working on greater than 1
> machine wrt version numbers. I can re-send as v7, would it be okay to
> put on a Tested-by: John Garry <john.garry@huawei.com> ?
>
Sure,
Tested-by: John Garry <john.garry@huawei.com>
> .
next prev parent reply other threads:[~2022-06-29 16:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 2:57 Ian Rogers
2022-06-27 2:57 ` [PATCH v6 1/4] perf python: Prefer python3 Ian Rogers
2022-06-27 2:57 ` [PATCH v6 2/4] perf jevents: Add python converter script Ian Rogers
2022-06-29 16:56 ` John Garry
2022-06-29 18:11 ` Ian Rogers
2022-06-30 8:36 ` John Garry
2022-06-27 2:57 ` [PATCH v6 3/4] perf jevents: Switch build to use jevents.py Ian Rogers
2022-06-27 2:57 ` [PATCH v6 4/4] perf jevents: Remove jevents.c Ian Rogers
2022-06-27 17:27 ` [PATCH v6 0/4] Rewrite jevents program in python John Garry
2022-06-29 16:47 ` Ian Rogers
2022-06-29 16:50 ` John Garry [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-06-18 0:09 Ian Rogers
2022-06-18 0:23 ` Xing Zhengjun
2022-06-18 1:41 ` Ian Rogers
2022-06-18 2:40 ` Xing Zhengjun
2022-06-22 7:12 ` Jiri Olsa
2022-06-22 7:36 ` Jiri Olsa
2022-06-23 11:57 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03cab2a6-0217-d688-8c86-5fd58e847dde@huawei.com \
--to=john.garry@huawei.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth.narayan@amd.com \
--cc=andrew.kilroy@arm.com \
--cc=caleb.biggers@intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=kshipra.bopardikar@intel.com \
--cc=likexu@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=liuqi115@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nbd@nbd.name \
--cc=nick.forrington@arm.com \
--cc=pc@us.ibm.com \
--cc=perry.taylor@intel.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=sandipan.das@amd.com \
--cc=santosh.shukla@amd.com \
--cc=will@kernel.org \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®