From: John Meneghini <jmeneghi@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: kbusch@kernel.org, sagi@grimberg.me, loberman@redhat.com,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
emilne@redhat.com, bgurney@redhat.com
Subject: Re: [PATCH 2/4] nvme-multipath: add the NVME_MULTIPATH_PARAM config option
Date: Tue, 11 Mar 2025 22:35:40 -0400 [thread overview]
Message-ID: <03e7cc64-fafd-405e-a07a-4bc6d0e1d743@redhat.com> (raw)
In-Reply-To: <20250305143353.GB18526@lst.de>
On 3/5/25 9:33 AM, Christoph Hellwig wrote:
> On Thu, Feb 27, 2025 at 10:25:39PM -0500, John Meneghini wrote:
>> The NVME_MULTIPATH_PARAM option controls the core.nvme_multipath module
>> parameter. When NVME_MULTIPATH_PARAM=n the multipath parameter is removed
>> and core nvme multipathing is enabled. When NVME_MULTIPATH_PARAM=y
>> the multipath parameter is added and multipath support becomes
>> configurable with the core.nvme_multipath parameter.
>
> What's the point of adding yet another confusing option?
If you'll read the kConfig description, hopefully it's not confusing.
The whole point of this patch series is to remove the core.nvme_mulipath parameter.
This is what the patch at: https://lore.kernel.org/linux-nvme/20250204211158.43126-1-bgurney@redhat.com/
does, and this is what this patch does. Since people didn't want to remove core.nvme_multipath parameter
in https://lore.kernel.org/linux-nvme/20250204211158.43126-1-bgurney@redhat.com/ I've proposed this
patch as an alternative.
It provides a kConfig option to remove the core.nvme_multipath parameter so those who want it
can keep it, and those who don't and compile it out.
/John
next prev parent reply other threads:[~2025-03-12 2:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 3:25 [PATCH 0/4] nvme: make core.nvme_multipath configurable John Meneghini
2025-02-28 3:25 ` [PATCH 1/4] nvme-multipath: change the NVME_MULTIPATH config option John Meneghini
2025-03-05 14:33 ` Christoph Hellwig
2025-02-28 3:25 ` [PATCH 2/4] nvme-multipath: add the NVME_MULTIPATH_PARAM " John Meneghini
2025-02-28 6:28 ` Nilay Shroff
2025-02-28 13:07 ` John Meneghini
2025-03-05 14:33 ` Christoph Hellwig
2025-03-12 2:35 ` John Meneghini [this message]
2025-03-12 5:19 ` Christoph Hellwig
2025-03-13 21:46 ` John Meneghini
2025-03-17 18:00 ` Keith Busch
2025-02-28 3:25 ` [PATCH 3/4] nvme: update the multipath warning in nvme_init_ns_head John Meneghini
2025-02-28 6:28 ` Nilay Shroff
2025-02-28 13:14 ` John Meneghini
2025-03-02 17:28 ` Nilay Shroff
2025-02-28 3:25 ` [PATCH 4/4] nvme: add mulitipath warning to nvme_alloc_ns John Meneghini
2025-03-05 14:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03e7cc64-fafd-405e-a07a-4bc6d0e1d743@redhat.com \
--to=jmeneghi@redhat.com \
--cc=bgurney@redhat.com \
--cc=emilne@redhat.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=loberman@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®